FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 02-17-2010, 01:25 AM
Maciej Mrozowski
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

A as result of discussion http://www.mail-archive.com/gentoo-
dev@lists.gentoo.org/msg37300.html
ebeep and epause functions defined in eutils are not available in EAPI >= 3.
For interactive installs, PROPERTIES="interactive" should be used instead.

--
regards
MM
 
Old 02-17-2010, 01:14 PM
Jeremy Olexa
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

Maciej Mrozowski wrote:

A as result of discussion http://www.mail-archive.com/gentoo-
dev@lists.gentoo.org/msg37300.html
ebeep and epause functions defined in eutils are not available in EAPI >= 3.
For interactive installs, PROPERTIES="interactive" should be used instead.



Maybe ebeep and epause should be defined in EAPI>=3 but a qa warning so
things actually get fixed?


Something like this (not tested):

%% cvs di eutils.eclass
Index: eutils.eclass
================================================== =================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.330
diff -u -r1.330 eutils.eclass
--- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330
+++ eutils.eclass 17 Feb 2010 14:13:16 -0000
@@ -50,6 +50,15 @@
done
fi
}
+else
+ ebeep() {
+ eqawarn "ebeep is not defined in EAPI=3, please file a
bug at

+ http://bugs.gentoo.org"
+ }
+ epause() {
+ eqawarn "epause is not defined in EAPI=3, please file a
bug at

+ http://bugs.gentoo.org"
+ }

fi

-Jeremy
 
Old 02-17-2010, 01:33 PM
Torsten Veller
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

* Jeremy Olexa <darkside@gentoo.org>:
> Maciej Mrozowski wrote:
> >A as result of discussion http://www.mail-archive.com/gentoo-
> >dev@lists.gentoo.org/msg37300.html
> >ebeep and epause functions defined in eutils are not available in EAPI >= 3.
> >For interactive installs, PROPERTIES="interactive" should be used instead.
> >
>
> Maybe ebeep and epause should be defined in EAPI>=3 but a qa warning
> so things actually get fixed?
>
> Something like this (not tested):
>
> %% cvs di eutils.eclass
> Index: eutils.eclass
> ================================================== =================
> RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
> retrieving revision 1.330
> diff -u -r1.330 eutils.eclass

If you'd update your tree you can see that something like this was
committed.
http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/eutils.eclass?r1=1.330&r2=1.332

> --- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330
> +++ eutils.eclass 17 Feb 2010 14:13:16 -0000
> @@ -50,6 +50,15 @@
> done
> fi
> }
> +else
> + ebeep() {
> + eqawarn "ebeep is not defined in EAPI=3, please file

The problem here is that eqawarn isn't defined in EAPI 3.
 
Old 02-17-2010, 04:13 PM
Petteri Räty
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On 17.2.2010 16.33, Torsten Veller wrote:

>
>> --- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330
>> +++ eutils.eclass 17 Feb 2010 14:13:16 -0000
>> @@ -50,6 +50,15 @@
>> done
>> fi
>> }
>> +else
>> + ebeep() {
>> + eqawarn "ebeep is not defined in EAPI=3, please file
>
> The problem here is that eqawarn isn't defined in EAPI 3.
>

Just shows that committing things to central eclasses without review is
a bad thing. I improved the code so that it doesn't at least call
eqawarn without first checking if it exists. Instead of code like this
in the eclasses, I think this should be done by Portage grepping logs. I
think it's already running searches over it for gcc things any way.

Regards,
Petteri
betelgeuse@pena /usr/portage/eclass $ cvs diff eutils.eclass
Index: eutils.eclass
================================================== =================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.332
diff -u -r1.332 eutils.eclass
--- eutils.eclass 17 Feb 2010 02:22:43 -0000 1.332
+++ eutils.eclass 17 Feb 2010 17:10:00 -0000
@@ -54,11 +54,13 @@
else

ebeep() {
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please file a bug at http://bugs.gentoo.org"
+ [[ $(type -t eqawarn) == function ]] &&
+ eqawarn "QA Notice: ebeep is not defined in EAPI=3, please file a bug at http://bugs.gentoo.org"
}

epause() {
- eqawarn "QA Notice: epause is not defined in EAPI=3, please file a bug at http://bugs.gentoo.org"
+ [[ $(type -t eqawarn) == function ]] &&
+ eqawarn "QA Notice: epause is not defined in EAPI=3, please file a bug at http://bugs.gentoo.org"
}

fi
 
Old 02-17-2010, 05:03 PM
Jeremy Olexa
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On Wed, 17 Feb 2010 19:13:06 +0200, Petteri Räty <betelgeuse@gentoo.org>
wrote:
> On 17.2.2010 16.33, Torsten Veller wrote:
>
>>
>>> --- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330
>>> +++ eutils.eclass 17 Feb 2010 14:13:16 -0000
>>> @@ -50,6 +50,15 @@
>>> done
>>> fi
>>> }
>>> +else
>>> + ebeep() {
>>> + eqawarn "ebeep is not defined in EAPI=3, please file
>>
>> The problem here is that eqawarn isn't defined in EAPI 3.
>>
>
> Just shows that committing things to central eclasses without review is
> a bad thing. I improved the code so that it doesn't at least call
> eqawarn without first checking if it exists. Instead of code like this
> in the eclasses, I think this should be done by Portage grepping logs. I
> think it's already running searches over it for gcc things any way.

What is going on with all these undocumented changes? When I look at the
council logs to see what is in EAPI3, I don't see anything about removing
functions. This is just silly and wastes alot of people's time for no
practical gain. In my EAPI3 portage, bin/isolated-functions.sh still has
eqawarn() defined. So, what am I missing now?

Also, other people think it is OK to change the behavior of functions and
not document it in devmanual?

> Regards,
> Petteri
 
Old 02-17-2010, 05:11 PM
Ciaran McCreesh
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On Wed, 17 Feb 2010 18:03:42 +0000
Jeremy Olexa <darkside@gentoo.org> wrote:
> What is going on with all these undocumented changes? When I look at
> the council logs to see what is in EAPI3, I don't see anything about
> removing functions. This is just silly and wastes alot of people's
> time for no practical gain.

Being in eutils, none of this has anything to do with PMS or the
Council.

> In my EAPI3 portage, bin/isolated-functions.sh still has eqawarn()
> defined. So, what am I missing now?

eqawarn has never been defined in any EAPI. It's a Portage internal,
not something for ebuilds to use. If you'd like it to be in an EAPI, you
can propose it for EAPI 5.

--
Ciaran McCreesh
 
Old 02-17-2010, 05:21 PM
Jeremy Olexa
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On Wed, 17 Feb 2010 18:11:42 +0000, Ciaran McCreesh
<ciaran.mccreesh@googlemail.com> wrote:
> On Wed, 17 Feb 2010 18:03:42 +0000
> Jeremy Olexa <darkside@gentoo.org> wrote:
>> What is going on with all these undocumented changes? When I look at
>> the council logs to see what is in EAPI3, I don't see anything about
>> removing functions. This is just silly and wastes alot of people's
>> time for no practical gain.
>
> Being in eutils, none of this has anything to do with PMS or the
> Council.

So, I was highlighting a problem. No one wants to write docs, which is
quite bad for the health of Gentoo.

>
>> In my EAPI3 portage, bin/isolated-functions.sh still has eqawarn()
>> defined. So, what am I missing now?
>
> eqawarn has never been defined in any EAPI. It's a Portage internal,
> not something for ebuilds to use. If you'd like it to be in an EAPI, you
> can propose it for EAPI 5.

Yes, correct. For some reason, I thought it was valid to use eqawarn in
ebuilds. Now I guess a valid fix for eutils.eclass would be:

%% cvs di eutils.eclass
Index: eutils.eclass
================================================== =================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.333
diff -u -r1.333 eutils.eclass
--- eutils.eclass 17 Feb 2010 17:10:23 -0000 1.333
+++ eutils.eclass 17 Feb 2010 18:20:18 -0000
@@ -54,13 +54,11 @@
else

ebeep() {
- [[ $(type -t eqawarn) == function ]] &&
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org"
+ einfo "QA Notice: ebeep is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org"
}

epause() {
- [[ $(type -t eqawarn) == function ]] &&
- eqawarn "QA Notice: epause is not defined in EAPI=3,
please file a bug at http://bugs.gentoo.org"
+ einfo "QA Notice: epause is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org"
}

fi

(where einfo is used because it doesn't need to be logged)

-Jeremy
 
Old 02-17-2010, 11:46 PM
Petteri Räty
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On 17.2.2010 20.03, Jeremy Olexa wrote:

>
> What is going on with all these undocumented changes? When I look at the
> council logs to see what is in EAPI3, I don't see anything about removing
> functions. This is just silly and wastes alot of people's time for no
> practical gain. In my EAPI3 portage, bin/isolated-functions.sh still has
> eqawarn() defined. So, what am I missing now?
>

The canonical documentation for eclasses is eclass-manpages generated
man pages and those where changed in my original commit.

> Also, other people think it is OK to change the behavior of functions and
> not document it in devmanual?
>

devmanual should either have a pointer to eclass-manpages or
autogenerate from eclass-manpages. The relevant bug is here:
https://bugs.gentoo.org/show_bug.cgi?id=202656

Regards,
Petteri
 
Old 02-25-2010, 02:11 AM
Maciej Mrozowski
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On Wednesday 17 of February 2010 03:25:16 Maciej Mrozowski wrote:

If no objections, I'm going to commit in 5 days the following patch to
eutils.eclass

Index: eutils.eclass
================================================== =================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.333
diff -u -B -r1.333 eutils.eclass
--- eutils.eclass 17 Feb 2010 17:10:23 -0000 1.333
+++ eutils.eclass 25 Feb 2010 03:11:32 -0000
@@ -54,13 +54,11 @@
else

ebeep() {
- [[ $(type -t eqawarn) == function ]] &&
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org"
+ ewarn "QA Notice: ebeep is not defined in EAPI=${EAPI}, please file a
bug at http://bugs.gentoo.org"
}

epause() {
- [[ $(type -t eqawarn) == function ]] &&
- eqawarn "QA Notice: epause is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org"
+ ewarn "QA Notice: epause is not defined in EAPI=${EAPI}, please file a
bug at http://bugs.gentoo.org"
}

fi

--
regards
MM
 
Old 03-01-2010, 11:55 PM
Maciej Mrozowski
 
Default eutils changes wrt EAPI-3 - ebeep and epause no longer available

On Thursday 25 of February 2010 04:11:49 Maciej Mrozowski wrote:
> On Wednesday 17 of February 2010 03:25:16 Maciej Mrozowski wrote:
>
> If no objections, I'm going to commit in 5 days the following patch to
> eutils.eclass
>
> Index: eutils.eclass
> ================================================== =================
> RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
> retrieving revision 1.333
> diff -u -B -r1.333 eutils.eclass
> --- eutils.eclass 17 Feb 2010 17:10:23 -0000 1.333
> +++ eutils.eclass 25 Feb 2010 03:11:32 -0000
> @@ -54,13 +54,11 @@
> else
>
> ebeep() {
> - [[ $(type -t eqawarn) == function ]] &&
> - eqawarn "QA Notice: ebeep is not defined in EAPI=3, please
> file a bug at http://bugs.gentoo.org"
> + ewarn "QA Notice: ebeep is not defined in EAPI=${EAPI}, please file
> a bug at http://bugs.gentoo.org"
> }
>
> epause() {
> - [[ $(type -t eqawarn) == function ]] &&
> - eqawarn "QA Notice: epause is not defined in EAPI=3, please
> file a bug at http://bugs.gentoo.org"
> + ewarn "QA Notice: epause is not defined in EAPI=${EAPI}, please
> file a bug at http://bugs.gentoo.org"
> }
>
> fi

No objections, so commiting this one.

--
regards
MM
 

Thread Tools




All times are GMT. The time now is 01:31 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org