FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 01-17-2010, 07:38 PM
Petteri Ršty
 
Default RFC: don't define ebeep and epause in eutils in EAPI 3

With GLEP 42 and proper logging of e* messages I think we shouldn't
annoy users any more with ebeep or epause so attached is a patch only
defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to
keep these around for EAPI 3? If not I will apply the attached patch.

Regards,
Petteri
Index: eutils.eclass
================================================== =================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.328
diff -u -r1.328 eutils.eclass
--- eutils.eclass 10 Jan 2010 15:58:58 -0000 1.328
+++ eutils.eclass 17 Jan 2010 20:37:05 -0000
@@ -19,6 +19,8 @@

DESCRIPTION="Based on the ${ECLASS} eclass"

+if has "${EAPI:-0}" 0 1; then
+
# @FUNCTION: epause
# @USAGE: [seconds]
# @DESCRIPTION:
@@ -49,6 +51,8 @@
fi
}

+fi
+
# @FUNCTION: ecvs_clean
# @USAGE:[list of dirs]
# @DESCRIPTION:
 
Old 01-17-2010, 07:48 PM
Tom√°Ň° Chv√°tal
 
Default RFC: don't define ebeep and epause in eutils in EAPI 3

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 17.1.2010 21:38, Petteri Räty napsal(a):
> With GLEP 42 and proper logging of e* messages I think we shouldn't
> annoy users any more with ebeep or epause so attached is a patch only
> defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to
> keep these around for EAPI 3? If not I will apply the attached patch.
>
> Regards,
> Petteri
++ should really not be used.

Actualy i think since it is just eclass call we could make it not used
anywhere in ebuilds, and then mark the functions as deprecated and just
return true.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktTd5wACgkQHB6c3gNBRYdHegCfZfD7r0aQUB H+ObWdjNvIDYAt
IE4AnjY655N8l7HwY4qZPh4Ms3pY8g4H
=5kRF
-----END PGP SIGNATURE-----
 
Old 01-17-2010, 08:12 PM
David Leverton
 
Default RFC: don't define ebeep and epause in eutils in EAPI 3

On Sunday 17 January 2010 20:38:48 Petteri Ršty wrote:
> With GLEP 42 and proper logging of e* messages I think we shouldn't
> annoy users any more with ebeep or epause so attached is a patch only
> defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to
> keep these around for EAPI 3? If not I will apply the attached patch.

The eclass-manpages comments should be updated too.
 
Old 01-17-2010, 08:30 PM
Mike Frysinger
 
Default RFC: don't define ebeep and epause in eutils in EAPI 3

On Sunday 17 January 2010 16:12:29 David Leverton wrote:
> On Sunday 17 January 2010 20:38:48 Petteri Ršty wrote:
> > With GLEP 42 and proper logging of e* messages I think we shouldn't
> > annoy users any more with ebeep or epause so attached is a patch only
> > defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to
> > keep these around for EAPI 3? If not I will apply the attached patch.
>
> The eclass-manpages comments should be updated too.

you mean you should re-emerge it on your system
-mike
 
Old 01-18-2010, 06:21 AM
Torsten Veller
 
Default RFC: don't define ebeep and epause in eutils in EAPI 3

* Mike Frysinger <vapier@gentoo.org>:
> On Sunday 17 January 2010 16:12:29 David Leverton wrote:
> > On Sunday 17 January 2010 20:38:48 Petteri Ršty wrote:
> > > With GLEP 42 and proper logging of e* messages I think we shouldn't
> > > annoy users any more with ebeep or epause so attached is a patch only
> > > defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to
> > > keep these around for EAPI 3? If not I will apply the attached patch.

The patch only defines these functions for EAPI=0 and EAPI=1.

> > The eclass-manpages comments should be updated too.
>
> you mean you should re-emerge it on your system

I think he means that the patch should modify @DESCRIPTION too.
 

Thread Tools




All times are GMT. The time now is 12:14 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org