Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   Heads up: cmake-utils.eclass changes (http://www.linux-archive.org/gentoo-development/294603-heads-up-cmake-utils-eclass-changes.html)

Jonathan Callen 12-13-2009 01:28 PM

Heads up: cmake-utils.eclass changes
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Recently a change was made to cmake-utils.eclass, changing the
mycmakeargs parameter from a flat string to an array. This change was
also made to kde4-{base,meta}.eclass. The primary reason for this
change was to allow parameters passed to cmake to contain spaces (such
as "${S}" or "${EPREFIX}"). Currently, there is code in these eclasses
to properly convert a string to an array, keeping the previous behavior.
This code works in almost every case *except* if you want to change
mycmakeargs in src_test and call cmake-utils_src_configure again. The
few instances of this in the tree have been fixed to use arrays, as
should all new ebuilds.

The plan is to eventually remove this backwards-compatibility code, once
all usages in the tree have been converted.

- --
Jonathan Callen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.13 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksk+iEACgkQOypDUo0oQOqFhgCghP04XNdMb1 U9xVDNzhQuwDSB
zMkAnRty6dY5V8GkTxkz4bHcRK9dDL1C
=kNek
-----END PGP SIGNATURE-----

Petteri Räty 12-14-2009 11:43 AM

Heads up: cmake-utils.eclass changes
 
On 12/13/2009 04:28 PM, Jonathan Callen wrote:
> Recently a change was made to cmake-utils.eclass, changing the
> mycmakeargs parameter from a flat string to an array. This change was
> also made to kde4-{base,meta}.eclass. The primary reason for this
> change was to allow parameters passed to cmake to contain spaces (such
> as "${S}" or "${EPREFIX}"). Currently, there is code in these eclasses
> to properly convert a string to an array, keeping the previous behavior.
> This code works in almost every case *except* if you want to change
> mycmakeargs in src_test and call cmake-utils_src_configure again. The
> few instances of this in the tree have been fixed to use arrays, as
> should all new ebuilds.
>
> The plan is to eventually remove this backwards-compatibility code, once
> all usages in the tree have been converted.
>

The policy has been to not change the API of eclasses because you can
have user written ebuilds in overlays expecting certain behavior.

Regards,
Petteri


All times are GMT. The time now is 06:48 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.