Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass (http://www.linux-archive.org/gentoo-development/282612-code-review-main-tree-inclusion-java-mvn-src-eclass-java-pkg-simple-eclass.html)

Christian Faulhammer 11-18-2009 05:37 PM

Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass
 
Hi,

Andrey Kislyuk <weaver@gentoo.org>:
> ... and let's say after 30 days from this email pending resolution of
> any complaints mvg and I will push these to main tree.

You should review your docstrings. Some of them contain overlong
sentences, which are hard to grasp.

java-pkg-simple:
In my eyes, defining all local variables at the beginning of a function
makes it easier to read.

V-Li

--
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>

Christian Faulhammer 12-10-2009 12:28 PM

Code review and main tree inclusion for java-mvn-src.eclass and java-pkg-simple.eclass
 
Hi,

Martin von Gagern <Martin.vGagern@gmx.net>:

> Christian Faulhammer wrote:
> > java-pkg-simple:
> > In my eyes, defining all local variables at the beginning of a
> > function makes it easier to read.
>
> Sorry, Fauli, i totally missed your mail as it was only addressed to
> gentoo-dev, while I've been intently watching gentoo-java...

I am not subscribed to that list, so my mail would not get through.

> To sum things up: yes, I could change the local declarations, but I'd
> rather keep things as they are, unless you object more vehemently.

No problem, it was a matter of style.

V-Li

--
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://gentoo.faulhammer.org/>


All times are GMT. The time now is 08:29 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.