Hi,
I am currently messing with git.eclass and i would like to see some other sets
of eyes on it.
I am throwing in full new eclass [1] and its diff [2].
I will be really happy for comments and even more for diffs

[1]
http://git.overlays.gentoo.org/gitweb/?p=dev/scarabeus.git;a=blob;f=eclass/git.eclass
[2] http://dev.gentoo.org/~scarabeus/git.eclass.diff

Regards
Tomas

Tomáš Chvátal a écrit :

Hi,
I am currently messing with git.eclass and i would like to see some other sets
of eyes on it.

I am throwing in full new eclass [1] and its diff [2].
I will be really happy for comments and even more for diffs


Does/Can it fix bug #247187 ? Or is it something that needs to be fixed
in each Xorg ebuild or in the x-modular eclass?


Cheers

Rémi

https://bugs.gentoo.org/show_bug.cgi?id=247187

Tomáš Chvátal a écrit :

Hi,
I am currently messing with git.eclass and i would like to see some other sets
of eyes on it.

I am throwing in full new eclass [1] and its diff [2].
I will be really happy for comments and even more for diffs


Oh and by the way, the diff looks nice to me. Maybe we could put it
temporarily in the X11 overlay, it'd get a lot of testing in there.


Donnie, what do you say? Would running emerge --regen be too much
inconvenience ?


Cheers

Rémi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tomáš Chvátal wrote:
> I am throwing in full new eclass [1] and its diff [2].

Errr, maybe it's my eyes, but it looks as though the new eclass isn't
the same as the existing eclass with the diff applied (for instance,
git_src_prepare doesn't get called in the diff, but does in the new eclass).

Also, base_src_prepare doesn't get exported if EAPI != 2, so I'm not
sure what happens when it gets called from git_src_prepare (which can be
called when EAPI = 0|1). Has anyone actually tried this on a non-EAPI2
ebuild?

Lastly (and this happened in the old eclass, but I figured since it was
getting an update now would be a good time to fix it), because checking
out uses "--depth 1", it's possible for a checkout to fail (specifically
if EGIT_BRANCH/EGIT_TREE is set on first checkout) since the required
commitish may not exist in the shallow copy. The error messages thrown
out are along the lines of "not a tar file", but I believe the ebuild
continues, until it doesn't find the unpacked source. The possible
fixes would be to:

a) ask git to clone at a specific commitish (although I can see how to
do that in git clone --help)

b) see if there's a specific commit set, and then clone the whole tree

c) see if there's a specific commit set, and if so trap the error
message and offer a useful warning like "remove the repo and set
EGIT_FETCH_CMD='git clone --bare'"

Unfortunately a) and b) don't solve the problem of a specific commit
being set by a user after the initial clone's taken place (in which
case, if it's not in the clone there'll never be a way to get it from
that checked out copy).

Perhaps on an error during an update could clear out the git repository
from distfiles/git-src and try again without a --depth? Clones made
without a --depth entry that then fail would be an actual fail...

Mike 5
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (GNU/Linux)

iEYEARECAAYFAkmuZk4ACgkQu7rWomwgFXoZ9wCbBh2BH7ERu+ Ck/0W0IkLxHPU4
GW4An1DMBJ2rK+Hkb92U571QegW+VDhQ
=aB2B
-----END PGP SIGNATURE-----

Dne středa 04 Březen 2009 11:22:54 Rémi Cardona napsal(a):
> Tomáš Chvátal a écrit :
> > Hi,
> > I am currently messing with git.eclass and i would like to see some other
> > sets of eyes on it.
> > I am throwing in full new eclass [1] and its diff [2].
> > I will be really happy for comments and even more for diffs
>
> Does/Can it fix bug #247187 ? Or is it something that needs to be fixed
> in each Xorg ebuild or in the x-modular eclass?
>
> Cheers
>
> Rémi
>
> https://bugs.gentoo.org/show_bug.cgi?id=247187
As i said on irc.
It can be done by simple array PN->HOMEPAGE. :P
But of course somebody have to write that array down

Tomas

Dne středa 04 Březen 2009 11:29:44 Rémi Cardona napsal(a):
> Tomáš Chvátal a écrit :
> > Hi,
> > I am currently messing with git.eclass and i would like to see some other
> > sets of eyes on it.
> > I am throwing in full new eclass [1] and its diff [2].
> > I will be really happy for comments and even more for diffs
>
> Oh and by the way, the diff looks nice to me. Maybe we could put it
> temporarily in the X11 overlay, it'd get a lot of testing in there.
>
> Donnie, what do you say? Would running emerge --regen be too much
> inconvenience ?
>
> Cheers
>
> Rémi
It might be good idea to add it to the x11 overlay, but i would need access
there cause it would be really inconvinient to bug you around for every change
i would like to do :]

Tomas

Dne úterý 03 Březen 2009 20:47:28 Tomáš Chvátal napsal(a):
> [2] http://dev.gentoo.org/~scarabeus/git.eclass.diff

As for now the diff is really obsolete so use direct link and make diff
yourself (sorry but i preffer fast including patches :])

Tomas

On 11:29 Wed 04 Mar , Rémi Cardona wrote:
> Tomáš Chvátal a écrit :
>> Hi,
>> I am currently messing with git.eclass and i would like to see some
>> other sets of eyes on it.
>> I am throwing in full new eclass [1] and its diff [2].
>> I will be really happy for comments and even more for diffs
>
> Oh and by the way, the diff looks nice to me. Maybe we could put it
> temporarily in the X11 overlay, it'd get a lot of testing in there.
>
> Donnie, what do you say? Would running emerge --regen be too much
> inconvenience ?

Go nuts. Doesn't hurt me, I've already got many eclasses in overlays ...

--
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com