FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 02-27-2009, 01:08 PM
Torsten Veller
 
Default perl-module.eclass -- review

Please review the attached perl-module.eclass.
Patch linked below.

Changes (#239510):
~~~~~~~
- EAPI 2 support
- default license
- reduced EXPORT_FUNCTIONS for EAPI=2
- HOMEPAGE changed
- LDFLAGS support
- quoting
- removes updatepod()
- removes .packlist files
- removes empty *.bs files
- removed BUILDER_VER stuff


IDEAS
~~~~~
- remove esvn_clean
- cache perlinfo calls


TODO (no showstopper)
~~~~
- still no documentation
- perl-app.eclass not done


After that perl-module_src_prep calls in ebuilds should be updated
(perl-module_src_configure) or removed:
| app-pda/pilot-link
| dev-perl/GDTextUtil
| dev-tex/html2latex
| kde-base/dcopperl
| mail-filter/spamassassin
| sci-libs/gdal
| sci-libs/udunit

Ebuilds with a local perl-module_src_prep function should be fixed too
| dev-perl/Alien-wxWidgets
| dev-perl/HTML-Mason
| www-apps/Embperl/Embperl


git://github.com/tove/perl-eclass.git
http://people.gentoo.org/tove/files/perl-module.eclass.diff
# Copyright 1999-2004 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/perl-module.eclass,v 1.112 2008/09/30 08:28:44 robbat2 Exp $
#
# Author: Seemant Kulleen <seemant@gentoo.org>

# @ECLASS: perl-module.eclass
# @MAINTAINER:
# perl@gentoo.org
# @BLURB: eclass for perl modules
# @DESCRIPTION:
# The perl-module eclass is designed to allow easier installation of perl
# modules, and their incorporation into the Gentoo Linux system.

inherit eutils base

case "${EAPI:-0}" in
0|1)
EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm src_compile src_install src_test src_unpack
;;
*)
EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_test src_install
;;
esac

DESCRIPTION="Based on the $ECLASS eclass"

LICENSE="${LICENSE:-|| ( Artistic GPL-2 )}"

[ -z "${SRC_URI}" -a -z "${MODULE_A}" ] && MODULE_A="${MY_P:-${P}}.tar.gz"
[ -z "${SRC_URI}" -a -n "${MODULE_AUTHOR}" ] &&
SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION}/${MODULE_A}"
[ -z "${HOMEPAGE}" ] &&
HOMEPAGE="http://search.cpan.org/dist/${MY_PN:-${PN}}"

SRC_PREP="no"
SRC_TEST="skip"
PREFER_BUILDPL="yes"

PERL_VERSION=""
SITE_ARCH=""
SITE_LIB=""
VENDOR_LIB=""
VENDOR_ARCH=""
ARCH_LIB=""
pm_echovar=""

perl-module_src_unpack() {
base_src_unpack unpack
has "${EAPI:-0}" 0 1 && perl-module_src_prepare
}

perl-module_src_prepare() {
if [[ -n ${PATCHES} ]] ; then
base_src_unpack autopatch
fi
esvn_clean
}

perl-module_src_configure() {
perl-module_src_prep
}

perl-module_src_prep() {
[[ "${SRC_PREP}" = "yes" ]] && return 0
SRC_PREP="yes"

perlinfo

export PERL_MM_USE_DEFAULT=1
# Disable ExtUtils::AutoInstall from prompting
export PERL_EXTUTILS_AUTOINSTALL="--skipdeps"

if [[ "${PREFER_BUILDPL}" == "yes" && -f Build.PL ]] ; then
einfo "Using Module::Build"
perl Build.PL
--installdirs vendor
--libdoc=
--config installman3dir=
--destdir "${D}"
--create_packlist=0
--extra_linker_flags="${LDFLAGS}"
${myconf}
<<< ${pm_echovar}
|| die "Unable to build! (are you using USE="build"?)"
elif [[ -f Makefile.PL ]] ; then
einfo "Using ExtUtils::MakeMaker"
perl Makefile.PL
PREFIX=/usr
INSTALLDIRS=vendor
INSTALLMAN3DIR='none'
DESTDIR="${D}"
${myconf}
<<< ${pm_echovar}
|| die "Unable to build! (are you using USE="build"?)"
fi
if [[ ! -f Build.PL && ! -f Makefile.PL ]] ; then
einfo "No Make or Build file detected..."
return
fi
}

perl-module_src_compile() {
perlinfo

has "${EAPI:-0}" 0 1 && perl-module_src_prep

if [[ -f Build ]] ; then
./Build build || die "compilation failed"
elif [[ -f Makefile ]] ; then
#make ${mymake} OPTIMIZE="${CFLAGS}" OTHERLDFLAGS="${LDFLAGS}" || die "compilation failed"
make ${mymake} OTHERLDFLAGS="${LDFLAGS}" || die "compilation failed"
fi
}

perl-module_src_test() {
if [[ "${SRC_TEST}" == "do" ]] ; then
perlinfo
if [[ -f Build ]] ; then
./Build test || die "test failed"
elif [[ -f Makefile ]] ; then
make test || die "test failed"
fi
fi
}

perl-module_src_install() {
local f stat
perlinfo

[[ -z ${mytargets} ]] && mytargets="pure_install"

if [[ -f Build ]] ; then
./Build ${mytargets} || die
elif [[ -f Makefile ]] ; then
make ${myinst} ${mytargets} || die
fi

einfo "Cleaning out stray man files"
for f in $(find "${D}" -type f -name "*.3pm*" ) ; do
#einfo "Cleaning stray man files: ${f##*/}"
rm -f "${f}"
done
find "${D}"/usr/share/man -depth -type d -empty -delete 2>/dev/null

fixlocalpod

for f in Change* CHANGES README* ${mydoc}; do
[[ -s "${f}" ]] && dodoc ${f}
done

find "${D}/${VENDOR_LIB}" -type f -a ( -name .packlist
-o ( -name '*.bs' -a -empty ) ) -delete
find "${D}/${VENDOR_LIB}" -depth -mindepth 1 -type d -empty -delete


for f in $(find "${D}" -type f -not -name '*.so' ) ; do
stat=$(file "${f}" | grep -i " text" )
if [[ "${stat}x" != "x" ]] ; then
sed -i -e "s:${D}:/:g" "${f}"
fi
done
}

perl-module_pkg_setup() {
perlinfo
}

perl-module_pkg_preinst() {
perlinfo
}

perl-module_pkg_postinst() { : ; }
# einfo "Man pages are not installed for most modules now."
# einfo "Please use perldoc instead."
#}

perl-module_pkg_prerm() { : ; }

perl-module_pkg_postrm() { : ; }

perlinfo() {
local version
eval `perl '-V:version'`
PERL_VERSION=${version}

local installsitearch
eval `perl '-V:installsitearch'`
SITE_ARCH=${installsitearch}

local installsitelib
eval `perl '-V:installsitelib'`
SITE_LIB=${installsitelib}

local installarchlib
eval `perl '-V:installarchlib'`
ARCH_LIB=${installarchlib}

local installvendorlib
eval `perl '-V:installvendorlib'`
VENDOR_LIB=${installvendorlib}

local installvendorarch
eval `perl '-V:installvendorarch'`
VENDOR_ARCH=${installvendorarch}
}

fixlocalpod() {
find "${D}" -type f -name perllocal.pod -delete
find "${D}" -depth -mindepth 1 -type d -empty -delete
}
 
Old 03-02-2009, 05:56 AM
"Robin H. Johnson"
 
Default perl-module.eclass -- review

On Fri, Feb 27, 2009 at 03:08:52PM +0100, Torsten Veller wrote:
> Please review the attached perl-module.eclass.
> Patch linked below.
Are you going to include the changes from Bug 254980 so that s390 can
build their stages properly?

Specifically, going to EAPI2 and adding DEPEND="dev-lang/perl[!build]"
to the eclass.

--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : robbat2@gentoo.org
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
 
Old 03-02-2009, 11:08 AM
Torsten Veller
 
Default perl-module.eclass -- review

* "Robin H. Johnson" <robbat2@gentoo.org>:
> On Fri, Feb 27, 2009 at 03:08:52PM +0100, Torsten Veller wrote:
> > Please review the attached perl-module.eclass.
> > Patch linked below.
> Are you going to include the changes from Bug 254980 so that s390 can
> build their stages properly?
>
> Specifically, going to EAPI2 and adding DEPEND="dev-lang/perl[!build]"
> to the eclass.

Currently the eclass doesn't set any dependencies.
If it is used the ebuild has to depend on perl if needed.


I see the following options:

1) Don't add DEPEND to the eclass.
So if a package is used for stage-building we have to raise EAPI and
depend on dev-lang/perl[-build] in the ebuild.

The part I don't understand in the bug above is:
Does adding dev-lang/perl[-build] automagically reinstall
perl during stage-building
(here portage stops and complains).


2) Add DEPEND conditionally to the eclass.
To give ebuilds the chance to inherit perl-module.eclass
(and currently also perl-app.eclass) and support perl conditionally,
we have to add another global variable to check it.

(Checking CATEGORY and perl? probably could be added additonally)


3) Add DEPEND.
Always depend on dev-lang/perl and
if EAPI=2 then depend on dev-lang/perl[-build]


Comments?
 
Old 03-02-2009, 04:51 PM
Donnie Berkholz
 
Default perl-module.eclass -- review

On 13:08 Mon 02 Mar , Torsten Veller wrote:
> Currently the eclass doesn't set any dependencies. If it is used the
> ebuild has to depend on perl if needed.
>
>
> I see the following options:
>
> 1) Don't add DEPEND to the eclass.
> So if a package is used for stage-building we have to raise EAPI and
> depend on dev-lang/perl[-build] in the ebuild.
>
> The part I don't understand in the bug above is:
> Does adding dev-lang/perl[-build] automagically reinstall
> perl during stage-building
> (here portage stops and complains).
>
>
> 2) Add DEPEND conditionally to the eclass.
> To give ebuilds the chance to inherit perl-module.eclass
> (and currently also perl-app.eclass) and support perl conditionally,
> we have to add another global variable to check it.
>
> (Checking CATEGORY and perl? probably could be added additonally)
>
>
> 3) Add DEPEND.
> Always depend on dev-lang/perl and
> if EAPI=2 then depend on dev-lang/perl[-build]
>
>
> Comments?

Having not spent a lot of time thinking about this, I'm guessing the use
case of concern is packages that have an optional perl module always
pulling in dev-lang/perl. This would apparently be relevant on an
embedded system that lacked perl but required a package with an optional
perl module. To handle that miniscule use case, I'd tend to go with a
conditional variable (GENTOO_PERL="no"?) that defaults to "yes".

--
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com
 
Old 03-02-2009, 05:10 PM
"Robin H. Johnson"
 
Default perl-module.eclass -- review

On Mon, Mar 02, 2009 at 01:08:15PM +0100, Torsten Veller wrote:
> The part I don't understand in the bug above is:
> Does adding dev-lang/perl[-build] automagically reinstall
> perl during stage-building
> (here portage stops and complains).
Yes. Portage will rebuild Perl with USE=-build.

--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : robbat2@gentoo.org
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
 
Old 03-02-2009, 05:13 PM
"Robin H. Johnson"
 
Default perl-module.eclass -- review

On Mon, Mar 02, 2009 at 09:51:07AM -0800, Donnie Berkholz wrote:
> On 13:08 Mon 02 Mar , Torsten Veller wrote:
> > Currently the eclass doesn't set any dependencies. If it is used the
> > ebuild has to depend on perl if needed.
> >
> >
> > I see the following options:
Perl modules by definition need dev-lang/perl installed to build
(Makefile.PL is written in Perl).

How many Perl modules can be installed with a Perl that is built with
USE=build?

> Having not spent a lot of time thinking about this, I'm guessing the use
> case of concern is packages that have an optional perl module always
> pulling in dev-lang/perl. This would apparently be relevant on an
> embedded system that lacked perl but required a package with an optional
> perl module. To handle that miniscule use case, I'd tend to go with a
> conditional variable (GENTOO_PERL="no"?) that defaults to "yes".
Yes, this would be needed in any case, similar to how it's done for
stuff that had optional X dependencies.

--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : robbat2@gentoo.org
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
 

Thread Tools




All times are GMT. The time now is 02:13 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org