FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Desktop

 
 
LinkBack Thread Tools
 
Old 02-19-2010, 11:16 AM
Ales Kozumplik
 
Default Remove gui code we no longer need when mini-wm is gone (#520146)

On 02/18/2010 08:54 PM, Chris Lumens wrote:

def addFrame(dialog, title=None, showtitle = 1):

<loads of minus signs>

+ if title:
+ dialog.set_title(title)


This isn't your fault, but while you're working here you might as well
clean it up. Having both title= and showtitle= is ridiculous. We
should get rid of showtitle and fix all callers of addFrame to pass None
for the title if they don't want a title displayed.


Yeah, I have this in plan. I'll provide the patch soon.




In general, I like all the minus signs. It's hard to tell whether to
agree to this set without running through an install to see what it
looks like, though. It shouldn't be too hard for me to apply locally
and do a scratch build.



Great, let me know if you run into problems please. I did a compose with
this patch and metacity starts OK and looks OK.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 07:37 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org