Set serial flag when encountering console argument (#823861)
Short answer: ACK!
There was some further discussion on IRC. For the record:
On Tue, 2012-05-22 at 14:49 +0200, Martin Sivak wrote:
> We forgot to set flags.serial when console= was used to trigger serial
For master I'd like to remove 'flags.serial' and 'flags.virtpconsole'
entirely - their meanings/uses are vague and confusing. If you want to
check/set text mode, check opts.display_mode; if you want to check what
type of console is in use, check the "console=XXX" boot arg(s).
For F17, there are a few places outside of bootloader.py that change
behavior if 'flags.serial' is set, but as far as we can tell it's all
> Also the whole OptionParser block seems useles to me now, as systemd
> is not passing any direct arguments to anaconda call.
Actually, anaconda parses the boot args itself - see
anaconda_optparse.py for the details, but basically it
reads /proc/cmdline, /run/initramfs/etc/cmdline,
/run/initramfs/etc/cmdline.d/*.conf, and /etc/cmdline and sets options
So a kernel arg named "nofb" or "inst.nofb" is the same as passing
"--nofb" to anaconda, and "xdriver=vesa" is the same as