FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora User

 
 
LinkBack Thread Tools
 
Old 05-08-2012, 03:04 AM
"Michael K. Johnson"
 
Default Fix some broken tests by unaliasing modules

On an up-to-date as of an hour ago f17 system, on the newui branch,
with no modifications, running "make unittest" gives me 239 errors
and 14 failures.

The following small patches reduce that to 84 errors and 4 failures,
resolving 155 errors and 10 failures.

Beyond this, the rest of the failures look real, most likely due
to code changes without corresponding test suite changes.


diff --git a/tests/pyanaconda_test/backend_test.py b/tests/pyanaconda_test/backend_test.py
index 2dd278e..85b5919 100644
--- a/tests/pyanaconda_test/backend_test.py
+++ b/tests/pyanaconda_test/backend_test.py
@@ -9,8 +9,10 @@ class BackendTest(mock.TestCase):

self.setupModules(["_isys", "block", 'parted', 'storage',
'pyanaconda.storage.formats', 'logging',
+ 'logging.config',
'ConfigParser', 'pyanaconda.anaconda_log',
- 'pyanaconda.storage.storage_log'])
+ 'pyanaconda.storage.storage_log',
+ 'pyanaconda.yuminstall'])

import pyanaconda
pyanaconda.anaconda_log = mock.Mock()
diff --git a/tests/pyanaconda_test/dispatch_test.py b/tests/pyanaconda_test/dispatch_test.py
index 669ec53..9ee80eb 100644
--- a/tests/pyanaconda_test/dispatch_test.py
+++ b/tests/pyanaconda_test/dispatch_test.py
@@ -3,7 +3,8 @@ import mock
class StepTest(mock.TestCase):
def setUp(self):
self.setupModules(
- ['_isys', 'logging', 'pyanaconda.anaconda_log', 'block'])
+ ['_isys', 'logging', 'logging.config',
+ 'pyanaconda.anaconda_log', 'block'])

import pyanaconda
pyanaconda.anaconda_log = mock.Mock()
@@ -133,7 +134,8 @@ class StepTest(mock.TestCase):
class DispatchTest(mock.TestCase):
def setUp(self):
self.setupModules(
- ['_isys', 'logging', 'pyanaconda.anaconda_log', 'block'])
+ ['_isys', 'logging', 'logging.config',
+ 'pyanaconda.anaconda_log', 'block'])

import pyanaconda
pyanaconda.anaconda_log = mock.Mock()

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-09-2012, 02:33 PM
Chris Lumens
 
Default Fix some broken tests by unaliasing modules

> On an up-to-date as of an hour ago f17 system, on the newui branch,
> with no modifications, running "make unittest" gives me 239 errors
> and 14 failures.
>
> The following small patches reduce that to 84 errors and 4 failures,
> resolving 155 errors and 10 failures.
>
> Beyond this, the rest of the failures look real, most likely due
> to code changes without corresponding test suite changes.

Keeping the test cases up to date has not been a high priority of mine,
no.

I'll apply this patch. Thanks.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:51 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org