---
pyanaconda/ui/gui/spokes/software.py | 11 +++++++++++
1 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
index 4299de6..adbcea3 100644
--- a/pyanaconda/ui/gui/spokes/software.py
+++ b/pyanaconda/ui/gui/spokes/software.py
@@ -61,6 +61,17 @@ class SoftwareSelectionSpoke(NormalSpoke):
for group in self.selectedGroups:
self.payload.selectGroup(group)

+ # select some stuff people will want with their desktop
+ if row[2] != "base":
+ groups = ['base-x', 'fonts']#, 'editors', 'graphical-internet',
+ #'hardware-support', 'input-methods', 'java', 'office',
+ #'printing', 'sound-and-video']
+ else:
+ groups = ['text-internet']
+
+ for group in [g for g in groups if g not in self.excludedGroups]:
+ self.payload.selectGroup(group)
+
@property
def completed(self):
return self._get_selected_desktop() is not None
--
1.7.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
> index 4299de6..adbcea3 100644
> --- a/pyanaconda/ui/gui/spokes/software.py
> +++ b/pyanaconda/ui/gui/spokes/software.py
> @@ -61,6 +61,17 @@ class SoftwareSelectionSpoke(NormalSpoke):
> for group in self.selectedGroups:
> self.payload.selectGroup(group)
>
> + # select some stuff people will want with their desktop
> + if row[2] != "base":
> + groups = ['base-x', 'fonts']#, 'editors', 'graphical-internet',
> + #'hardware-support', 'input-methods', 'java', 'office',
> + #'printing', 'sound-and-video']
> + else:
> + groups = ['text-internet']
> +
> + for group in [g for g in groups if g not in self.excludedGroups]:
> + self.payload.selectGroup(group)
> +
> @property
> def completed(self):
> return self._get_selected_desktop() is not None

I understand why we need to do something like this, but I really dislike
that we have to keep around a list of extra groups still. I don't
suppose we are likely to see any changes in package requirements that
will make this easier on us. So I guess we are stuck with it.

For the base case, I don't think we want to include text-internet
though. Don't we want that to be a minimal install?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens (clumens@redhat.com) said:
> > diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
> > index 4299de6..adbcea3 100644
> > --- a/pyanaconda/ui/gui/spokes/software.py
> > +++ b/pyanaconda/ui/gui/spokes/software.py
> > @@ -61,6 +61,17 @@ class SoftwareSelectionSpoke(NormalSpoke):
> > for group in self.selectedGroups:
> > self.payload.selectGroup(group)
> >
> > + # select some stuff people will want with their desktop
> > + if row[2] != "base":
> > + groups = ['base-x', 'fonts']#, 'editors', 'graphical-internet',
> > + #'hardware-support', 'input-methods', 'java', 'office',
> > + #'printing', 'sound-and-video']
> > + else:
> > + groups = ['text-internet']
> > +
> > + for group in [g for g in groups if g not in self.excludedGroups]:
> > + self.payload.selectGroup(group)
> > +
> > @property
> > def completed(self):
> > return self._get_selected_desktop() is not None
>
> I understand why we need to do something like this, but I really dislike
> that we have to keep around a list of extra groups still. I don't
> suppose we are likely to see any changes in package requirements that
> will make this easier on us. So I guess we are stuck with it.
>
> For the base case, I don't think we want to include text-internet
> though. Don't we want that to be a minimal install?

Oops, deleted the first thread without looking closely.

Why is this in anaconda at all?

Bill

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

> Oops, deleted the first thread without looking closely.
>
> Why is this in anaconda at all?

In the old days, we had this list because the Requires: on all the
desktop stuff did not pull in any X server. You know, because you may
want to be installing the graphical programs but then running them
remotely and all that.

Is this not still the case? I'd be happy to see this code die.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens (clumens@redhat.com) said:
> > Oops, deleted the first thread without looking closely.
> >
> > Why is this in anaconda at all?
>
> In the old days, we had this list because the Requires: on all the
> desktop stuff did not pull in any X server. You know, because you may
> want to be installing the graphical programs but then running them
> remotely and all that.

Sure, but that's not how we selected desktops - we had install classes
that had tasks (as much as they sucked). There were people who just
did a kickstart with:

%packages
gnome-desktop
%end

but those people got what they asked for.

> Is this not still the case? I'd be happy to see this code die.

>From looking at it, the whole 'refresh' section just seems like a big
placeholder that is staying around until someone (me?) gets around to
defining the metadata that should be driving this screen, as I don't
think this sort of logic belongs in anaconda proper. Am I misunderstanding?

Bill


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

On Wed, 2012-05-02 at 16:26 -0400, Bill Nottingham wrote:
> Chris Lumens (clumens@redhat.com) said:
> > > Oops, deleted the first thread without looking closely.
> > >
> > > Why is this in anaconda at all?
> >
> > In the old days, we had this list because the Requires: on all the
> > desktop stuff did not pull in any X server. You know, because you may
> > want to be installing the graphical programs but then running them
> > remotely and all that.
>
> Sure, but that's not how we selected desktops - we had install classes
> that had tasks (as much as they sucked). There were people who just
> did a kickstart with:
>
> %packages
> gnome-desktop
> %end
>
> but those people got what they asked for.
>
> > Is this not still the case? I'd be happy to see this code die.
>
> >From looking at it, the whole 'refresh' section just seems like a big
> placeholder that is staying around until someone (me?) gets around to
> defining the metadata that should be driving this screen, as I don't
> think this sort of logic belongs in anaconda proper. Am I misunderstanding?

My intention, which I should have stated, was that this code be only a
placeholder until we get the new variant/addon model in place. It would
be ideal if there were no such code in anaconda.

Dave

>
> Bill
>
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list