FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora User

 
 
LinkBack Thread Tools
 
Old 03-31-2011, 07:16 PM
Chris Lumens
 
Default timeout= in yaboot.conf is in tenths of seconds (#692409)

> diff --git a/booty/ppc.py b/booty/ppc.py
> index 9626d62..a7c6af8 100644
> --- a/booty/ppc.py
> +++ b/booty/ppc.py
> @@ -70,7 +70,7 @@ class ppcBootloaderInfo(bootloaderInfo):
> % productName)
>
> f.write("partition=%s
" % partNumber)
> - f.write("timeout=%s
" % (self.timeout or 80))
> + f.write("timeout=%s
" % ((self.timeout * 10) or 80))
> f.write("install=/usr/lib/yaboot/yaboot
")
> f.write("delay=5
")
> f.write("enablecdboot
")

Should self.timeout ever be None (which the original expression is set
up to handle), the multiplication will result in a TypeError.

How about: "(self.timeout or 8) * 10" instead?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-31-2011, 07:39 PM
David Cantrell
 
Default timeout= in yaboot.conf is in tenths of seconds (#692409)

Chris Lumens <clumens@redhat.com> wrote:

> > diff --git a/booty/ppc.py b/booty/ppc.py
> > index 9626d62..a7c6af8 100644
> > --- a/booty/ppc.py
> > +++ b/booty/ppc.py
> > @@ -70,7 +70,7 @@ class ppcBootloaderInfo(bootloaderInfo):
> > % productName)
> >
> > f.write("partition=%s
" % partNumber)
> > - f.write("timeout=%s
" % (self.timeout or 80))
> > + f.write("timeout=%s
" % ((self.timeout * 10) or 80))
> > f.write("install=/usr/lib/yaboot/yaboot
")
> > f.write("delay=5
")
> > f.write("enablecdboot
")
>
> Should self.timeout ever be None (which the original expression is set
> up to handle), the multiplication will result in a TypeError.
>
> How about: "(self.timeout or 8) * 10" instead?

Yeah, that's safer. Changed.

--
David Cantrell <dcantrell@redhat.com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Honolulu, HI | UTC-10

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 02:37 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org