FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora User

 
 
LinkBack Thread Tools
 
Old 09-29-2010, 09:30 PM
"Brian C. Lane"
 
Default Fix a missing storage import (#636621).

On Wed, Sep 29, 2010 at 05:10:20PM -0400, Chris Lumens wrote:
> ---
> anaconda | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/anaconda b/anaconda
> index 00c8322..66bcb00 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -266,6 +266,8 @@ def setupEnvironment():
> os.environ["PIXMAPPATH"] = "/tmp/updates/pixmaps/:/tmp/updates/:/tmp/product/pixmaps/:/tmp/product/ixmaps/:/usr/share/anaconda/pixmaps/:/usr/share/pixmaps/:/usr/share/anaconda/:/usr/share/python-meh/:/usr/share/icons/Fedora/48x48/apps/"
>
> def setupLoggingFromOpts(opts):
> + from pyanaconda import storage
> +
> if opts.loglevel and anaconda_log.logLevelMap.has_key(opts.loglevel):
> level = anaconda_log.logLevelMap[opts.loglevel]
> anaconda_log.logger.tty_loglevel = level

Ack.

--
Brian C. Lane / Anaconda Team
Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 09-29-2010, 09:33 PM
David Lehman
 
Default Fix a missing storage import (#636621).

There's an 'import pyanaconda.storage.storage_log' shortly before the
call to setupLoggingFromOpts, around line 500, presumably for this
purpose. All that's needed is to qualify
pyanaconda.storage.storage_log.logger inside setupLoggingFromOpts. Your
approach works, too, but then that import statement from __main__ is
unneeded.

Dave

On Wed, 2010-09-29 at 17:10 -0400, Chris Lumens wrote:
> ---
> anaconda | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/anaconda b/anaconda
> index 00c8322..66bcb00 100755
> --- a/anaconda
> +++ b/anaconda
> @@ -266,6 +266,8 @@ def setupEnvironment():
> os.environ["PIXMAPPATH"] = "/tmp/updates/pixmaps/:/tmp/updates/:/tmp/product/pixmaps/:/tmp/product/ixmaps/:/usr/share/anaconda/pixmaps/:/usr/share/pixmaps/:/usr/share/anaconda/:/usr/share/python-meh/:/usr/share/icons/Fedora/48x48/apps/"
>
> def setupLoggingFromOpts(opts):
> + from pyanaconda import storage
> +
> if opts.loglevel and anaconda_log.logLevelMap.has_key(opts.loglevel):
> level = anaconda_log.logLevelMap[opts.loglevel]
> anaconda_log.logger.tty_loglevel = level


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 09-30-2010, 02:34 PM
Chris Lumens
 
Default Fix a missing storage import (#636621).

> There's an 'import pyanaconda.storage.storage_log' shortly before the
> call to setupLoggingFromOpts, around line 500, presumably for this
> purpose. All that's needed is to qualify
> pyanaconda.storage.storage_log.logger inside setupLoggingFromOpts. Your
> approach works, too, but then that import statement from __main__ is
> unneeded.

Okay, I'll do one or the other.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 09:13 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org