Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Packaging (http://www.linux-archive.org/fedora-packaging/)
-   -   should I include tests in the package? (http://www.linux-archive.org/fedora-packaging/661353-should-i-include-tests-package.html)

"Germán A. Racca" 04-30-2012 01:50 PM

should I include tests in the package?
 
Hi list:

I'm the packager of APLpy: http://aplpy.github.com/

I'm going to update it to a new version, which comes with a set of
tests, but I'm not sure about what to do with them. I asked upstream and
the answer is:


"The tests are there for us to diagnose any issues related to specific
dependency versions and platforms, and to make sure that we don't
break anything when making changes. It would be useful if you include
them so that we can ask users to run them if they are having issues we
can't reproduce, but you don't need to run the tests as part of the
build/setup."

I'm still not sure. Should I include them in the package?

Have a nice day,
Germán.

--
Germán A. Racca
Fedora Package Maintainer
https://fedoraproject.org/wiki/User:Skytux
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Jon Ciesla 04-30-2012 01:56 PM

should I include tests in the package?
 
On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
<german.racca@gmail.com> wrote:
> Hi list:
>
> I'm the packager of APLpy: http://aplpy.github.com/
>
> I'm going to update it to a new version, which comes with a set of tests,
> but I'm not sure about what to do with them. I asked upstream and the answer
> is:
>
> "The tests are there for us to diagnose any issues related to specific
> dependency versions and platforms, and to make sure that we don't
> break anything when making changes. It would be useful if you include
> them so that we can ask users to run them if they are having issues we
> can't reproduce, but you don't need to run the tests as part of the
> build/setup."
>
> I'm still not sure. Should I include them in the package?

Unless they impose huge build deps or something, run them in make check.

-J

> Have a nice day,
> Germán.
>
> --
> Germán A. Racca
> Fedora Package Maintainer
> https://fedoraproject.org/wiki/User:Skytux
> --
> packaging mailing list
> packaging@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/packaging



--
http://cecinestpasunefromage.wordpress.com/
------------------------------------------------
in your fear, seek only peace
in your fear, seek only love

-d. bowie
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Jon Ciesla 04-30-2012 01:57 PM

should I include tests in the package?
 
On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla <limburgher@gmail.com> wrote:
> On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
> <german.racca@gmail.com> wrote:
>> Hi list:
>>
>> I'm the packager of APLpy: http://aplpy.github.com/
>>
>> I'm going to update it to a new version, which comes with a set of tests,
>> but I'm not sure about what to do with them. I asked upstream and the answer
>> is:
>>
>> "The tests are there for us to diagnose any issues related to specific
>> dependency versions and platforms, and to make sure that we don't
>> break anything when making changes. It would be useful if you include
>> them so that we can ask users to run them if they are having issues we
>> can't reproduce, but you don't need to run the tests as part of the
>> build/setup."
>>
>> I'm still not sure. Should I include them in the package?
>
> Unless they impose huge build deps or something, run them in make check.

To more directly answer your question, yes, include and run tests
whenever possible. :)

-J

> -J
>
>> Have a nice day,
>> Germán.
>>
>> --
>> Germán A. Racca
>> Fedora Package Maintainer
>> https://fedoraproject.org/wiki/User:Skytux
>> --
>> packaging mailing list
>> packaging@lists.fedoraproject.org
>> https://admin.fedoraproject.org/mailman/listinfo/packaging
>
>
>
> --
> http://cecinestpasunefromage.wordpress.com/
> ------------------------------------------------
> in your fear, seek only peace
> in your fear, seek only love
>
> -d. bowie



--
http://cecinestpasunefromage.wordpress.com/
------------------------------------------------
in your fear, seek only peace
in your fear, seek only love

-d. bowie
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Paul Howarth 04-30-2012 02:02 PM

should I include tests in the package?
 
On 04/30/2012 02:57 PM, Jon Ciesla wrote:

On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla<limburgher@gmail.com> wrote:

On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
<german.racca@gmail.com> wrote:

Hi list:

I'm the packager of APLpy: http://aplpy.github.com/

I'm going to update it to a new version, which comes with a set of tests,
but I'm not sure about what to do with them. I asked upstream and the answer
is:

"The tests are there for us to diagnose any issues related to specific
dependency versions and platforms, and to make sure that we don't
break anything when making changes. It would be useful if you include
them so that we can ask users to run them if they are having issues we
can't reproduce, but you don't need to run the tests as part of the
build/setup."

I'm still not sure. Should I include them in the package?


Unless they impose huge build deps or something, run them in make check.


To more directly answer your question, yes, include and run tests
whenever possible. :)


Beware when including tests of introducing file conflicts, like in
https://bugzilla.redhat.com/show_bug.cgi?id=797813


Paul.
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Tom Lane 04-30-2012 02:09 PM

should I include tests in the package?
 
=?ISO-8859-1?Q?=22Germ=E1n_A=2E_Racca=22?= <german.racca@gmail.com> writes:
> I'm the packager of APLpy: http://aplpy.github.com/
> I'm going to update it to a new version, which comes with a set of
> tests, but I'm not sure about what to do with them.

I think you do want to make the tests available to users, but they don't
necessarily have to be part of the base package.
If the tests are large relative to the base package, a fairly common
solution is to split them out into a sub-package, say aplpy-test.

(This is in addition to running them during the build.)

regards, tom lane
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

"Germán A. Racca" 04-30-2012 02:11 PM

should I include tests in the package?
 
On 04/30/2012 10:57 AM, Jon Ciesla wrote:

On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla<limburgher@gmail.com> wrote:

On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
<german.racca@gmail.com> wrote:

Hi list:

I'm the packager of APLpy: http://aplpy.github.com/

I'm going to update it to a new version, which comes with a set of tests,
but I'm not sure about what to do with them. I asked upstream and the answer
is:

"The tests are there for us to diagnose any issues related to specific
dependency versions and platforms, and to make sure that we don't
break anything when making changes. It would be useful if you include
them so that we can ask users to run them if they are having issues we
can't reproduce, but you don't need to run the tests as part of the
build/setup."

I'm still not sure. Should I include them in the package?


Unless they impose huge build deps or something, run them in make check.


To more directly answer your question, yes, include and run tests
whenever possible. :)


Thanks Jon :)

This is a Python package. Under what directory should I put them?

The tests ran fine in my computer[*], but what should I do in case of a
negative outcome?


Germán.
[*] $ python runtests.py
=================== test session starts ====================
platform linux2 -- Python 2.7.2 -- pytest-2.2.0
collected 186 items

tests/test_axis_labels.py ......
tests/test_beam.py ................
tests/test_colorbar.py .......
tests/test_contour.py ..
tests/test_downsample.py .
tests/test_frame.py ..
tests/test_grid.py .......
tests/test_init_cube.py ............................
tests/test_init_image.py
.................................................. ......................

tests/test_save.py ........................
tests/test_scalebar.py ..........
tests/test_tick_labels.py .....
tests/test_ticks.py ......

=============== 186 passed in 106.97 seconds ===============

--
Germán A. Racca
Fedora Package Maintainer
https://fedoraproject.org/wiki/User:Skytux
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Jon Ciesla 04-30-2012 02:16 PM

should I include tests in the package?
 
On Mon, Apr 30, 2012 at 9:11 AM, "Germán A. Racca"
<german.racca@gmail.com> wrote:
> On 04/30/2012 10:57 AM, Jon Ciesla wrote:
>>
>> On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla<limburgher@gmail.com> *wrote:
>>>
>>> On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
>>> <german.racca@gmail.com> *wrote:
>>>>
>>>> Hi list:
>>>>
>>>> I'm the packager of APLpy: http://aplpy.github.com/
>>>>
>>>> I'm going to update it to a new version, which comes with a set of
>>>> tests,
>>>> but I'm not sure about what to do with them. I asked upstream and the
>>>> answer
>>>> is:
>>>>
>>>> "The tests are there for us to diagnose any issues related to specific
>>>> dependency versions and platforms, and to make sure that we don't
>>>> break anything when making changes. It would be useful if you include
>>>> them so that we can ask users to run them if they are having issues we
>>>> can't reproduce, but you don't need to run the tests as part of the
>>>> build/setup."
>>>>
>>>> I'm still not sure. Should I include them in the package?
>>>
>>>
>>> Unless they impose huge build deps or something, run them in make check.
>>
>>
>> To more directly answer your question, yes, include and run tests
>> whenever possible. :)
>
>
> Thanks Jon :)
>
> This is a Python package. Under what directory should I put them?

For users, probably in %doc.

> The tests ran fine in my computer[*], but what should I do in case of a
> negative outcome?

If they're in make check in the spec, if they fail, the RPM build will fail.

-J

> Germán.
>
>[*] $ python runtests.py
> =================== test session starts ====================
> platform linux2 -- Python 2.7.2 -- pytest-2.2.0
> collected 186 items
>
> tests/test_axis_labels.py ......
> tests/test_beam.py ................
> tests/test_colorbar.py .......
> tests/test_contour.py ..
> tests/test_downsample.py .
> tests/test_frame.py ..
> tests/test_grid.py .......
> tests/test_init_cube.py ............................
> tests/test_init_image.py
> .................................................. ......................
> tests/test_save.py ........................
> tests/test_scalebar.py ..........
> tests/test_tick_labels.py .....
> tests/test_ticks.py ......
>
> =============== 186 passed in 106.97 seconds ===============
>
> --
> Germán A. Racca
> Fedora Package Maintainer
> https://fedoraproject.org/wiki/User:Skytux
> --
> packaging mailing list
> packaging@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/packaging



--
http://cecinestpasunefromage.wordpress.com/
------------------------------------------------
in your fear, seek only peace
in your fear, seek only love

-d. bowie
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

"Germán A. Racca" 04-30-2012 02:22 PM

should I include tests in the package?
 
On 04/30/2012 11:09 AM, Tom Lane wrote:

=?ISO-8859-1?Q?=22Germ=E1n_A=2E_Racca=22?=<german.racca@gmail .com> writes:

I'm the packager of APLpy: http://aplpy.github.com/
I'm going to update it to a new version, which comes with a set of
tests, but I'm not sure about what to do with them.


I think you do want to make the tests available to users, but they don't
necessarily have to be part of the base package.
If the tests are large relative to the base package, a fairly common
solution is to split them out into a sub-package, say aplpy-test.

(This is in addition to running them during the build.)

regards, tom lane


Hi Tom:

$ du -sh aplpy/
300K aplpy/

$ du -sh tests/
192K tests/

So I think that a split is not needed in this case.

--
Germán A. Racca
Fedora Package Maintainer
https://fedoraproject.org/wiki/User:Skytux
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Ralf Corsepius 04-30-2012 02:48 PM

should I include tests in the package?
 
On 04/30/2012 04:22 PM, "Germán A. Racca" wrote:

On 04/30/2012 11:09 AM, Tom Lane wrote:

=?ISO-8859-1?Q?=22Germ=E1n_A=2E_Racca=22?=<german.racca@gmail .com>
writes:

I'm the packager of APLpy: http://aplpy.github.com/
I'm going to update it to a new version, which comes with a set of
tests, but I'm not sure about what to do with them.


I think you do want to make the tests available to users, but they don't
necessarily have to be part of the base package.
If the tests are large relative to the base package, a fairly common
solution is to split them out into a sub-package, say aplpy-test.

(This is in addition to running them during the build.)

regards, tom lane


Hi Tom:

$ du -sh aplpy/
300K aplpy/

$ du -sh tests/
192K tests/

So I think that a split is not needed in this case.


This reasoning is dangerous:

a) Testsuites usually pull in further dependencies, which are not
required by the corresponding runtimes and therefore cause bloat.


b) If everybody thinks the "These 100k more don't matter" way, the
distro very soon will have problems.



That said, my pragmatical recommendation would be

a) Only explicitly package a testsuite, if upstream explicitly support
this (I.e. if "make install" or similar install this testsuite). And if,
do so in a separate package.


b) Check carefully, if a test is actually designed to be externally
(often this does not apply) or if it's an internal "self-testsuite".


Apart of this, experience tells, *-test packages cause more trouble
thany they use and often are removed in not too distant future.



Ralf




--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Jon Ciesla 04-30-2012 02:54 PM

should I include tests in the package?
 
On Mon, Apr 30, 2012 at 9:48 AM, Ralf Corsepius <rc040203@freenet.de> wrote:
> On 04/30/2012 04:22 PM, "Germán A. Racca" wrote:
>>
>> On 04/30/2012 11:09 AM, Tom Lane wrote:
>>>
>>> =?ISO-8859-1?Q?=22Germ=E1n_A=2E_Racca=22?=<german.racca@gmail .com>
>>> writes:
>>>>
>>>> I'm the packager of APLpy: http://aplpy.github.com/
>>>> I'm going to update it to a new version, which comes with a set of
>>>> tests, but I'm not sure about what to do with them.
>>>
>>>
>>> I think you do want to make the tests available to users, but they don't
>>> necessarily have to be part of the base package.
>>> If the tests are large relative to the base package, a fairly common
>>> solution is to split them out into a sub-package, say aplpy-test.
>>>
>>> (This is in addition to running them during the build.)
>>>
>>> regards, tom lane
>>
>>
>> Hi Tom:
>>
>> $ du -sh aplpy/
>> 300K aplpy/
>>
>> $ du -sh tests/
>> 192K tests/
>>
>> So I think that a split is not needed in this case.
>
>
> This reasoning is dangerous:
>
> a) Testsuites usually pull in further dependencies, which are not required
> by the corresponding runtimes and therefore cause bloat.
>
> b) If everybody thinks the "These 100k more don't matter" way, the distro
> very soon will have problems.
>
>
> That said, my pragmatical recommendation would be
>
> a) Only explicitly package a testsuite, if upstream explicitly support this
> (I.e. if "make install" or similar install this testsuite). And if, do so in
> a separate package.
>
> b) Check carefully, if a test is actually designed to be externally (often
> this does not apply) or if it's an internal "self-testsuite".
>
> Apart of this, experience tells, *-test packages cause more trouble thany
> they use and often are removed in not too distant future.
>
Exactly, hence my suggestion to put it in %doc, to prevent deps,
though it doesn't help with disk space as much as leaving it out.

-J
>
> Ralf
>
>
>
>
> --
> packaging mailing list
> packaging@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/packaging



--
http://cecinestpasunefromage.wordpress.com/
------------------------------------------------
in your fear, seek only peace
in your fear, seek only love

-d. bowie
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging


All times are GMT. The time now is 09:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.