FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Packaging

 
 
LinkBack Thread Tools
 
Old 04-30-2012, 03:12 PM
Thomas Spura
 
Default should I include tests in the package?

On Mon, Apr 30, 2012 at 3:57 PM, Jon Ciesla <limburgher@gmail.com> wrote:
> On Mon, Apr 30, 2012 at 8:56 AM, Jon Ciesla <limburgher@gmail.com> wrote:
>> On Mon, Apr 30, 2012 at 8:50 AM, "Germán A. Racca"
>> <german.racca@gmail.com> wrote:
>>> Hi list:
>>>
>>> I'm the packager of APLpy: http://aplpy.github.com/
>>>
>>> I'm going to update it to a new version, which comes with a set of tests,
>>> but I'm not sure about what to do with them. I asked upstream and the answer
>>> is:
>>>
>>> "The tests are there for us to diagnose any issues related to specific
>>> dependency versions and platforms, and to make sure that we don't
>>> break anything when making changes. It would be useful if you include
>>> them so that we can ask users to run them if they are having issues we
>>> can't reproduce, but you don't need to run the tests as part of the
>>> build/setup."
>>>
>>> I'm still not sure. Should I include them in the package?
>>
>> Unless they impose huge build deps or something, run them in make check.
>
> To more directly answer your question, yes, include and run tests
> whenever possible.

This sounds like a SHOULD: include tests whenever possible...

It's enough to run it in %check and normally a user of the package
doesn't need to have the tests around.
I'd only include them, when upstream wants to have tham in and
installs them with "make" or "setup.py". And only in the latter case,
you need to decide to split the tests into a subpackage.

Greetings,
Tom
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging
 
Old 04-30-2012, 03:21 PM
Ralf Corsepius
 
Default should I include tests in the package?

On 04/30/2012 04:54 PM, Jon Ciesla wrote:

On Mon, Apr 30, 2012 at 9:48 AM, Ralf Corsepius<rc040203@freenet.de> wrote:

On 04/30/2012 04:22 PM, "Germán A. Racca" wrote:


On 04/30/2012 11:09 AM, Tom Lane wrote:


=?ISO-8859-1?Q?=22Germ=E1n_A=2E_Racca=22?=<german.racca@gmail .com>
writes:


I'm the packager of APLpy: http://aplpy.github.com/
I'm going to update it to a new version, which comes with a set of
tests, but I'm not sure about what to do with them.



I think you do want to make the tests available to users, but they don't
necessarily have to be part of the base package.
If the tests are large relative to the base package, a fairly common
solution is to split them out into a sub-package, say aplpy-test.

(This is in addition to running them during the build.)

regards, tom lane



Hi Tom:

$ du -sh aplpy/
300K aplpy/

$ du -sh tests/
192K tests/

So I think that a split is not needed in this case.



This reasoning is dangerous:

a) Testsuites usually pull in further dependencies, which are not required
by the corresponding runtimes and therefore cause bloat.

b) If everybody thinks the "These 100k more don't matter" way, the distro
very soon will have problems.


That said, my pragmatical recommendation would be

a) Only explicitly package a testsuite, if upstream explicitly support this
(I.e. if "make install" or similar install this testsuite). And if, do so in
a separate package.

b) Check carefully, if a test is actually designed to be externally (often
this does not apply) or if it's an internal "self-testsuite".

Apart of this, experience tells, *-test packages cause more trouble thany
they use and often are removed in not too distant future.


Exactly, hence my suggestion to put it in %doc, to prevent deps,
though it doesn't help with disk space as much as leaving it out.


This also is not safe. Probably all perl-package packagers have their
own story on installing testsuites as %doc.


Background: rpm and the rpm perl module deptracker repeatedly have
accidentally pulled in deps on certain kind of files in %doc. (I don't
know, if these issues are terminally resolved in all active versions of
Fedora and RHEL).


This experience has caused me to generally avoid packaging non-doc files
in %doc


Ralf

--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging
 

Thread Tools




All times are GMT. The time now is 07:24 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org