FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Packaging

 
 
LinkBack Thread Tools
 
Old 04-06-2008, 01:45 PM
Hans de Goede
 
Default Suggestion: require inclusion of cvs location in completed review request

David Timms wrote:

Hi all,

I am keen to get the packaging process modified to include a final item
after ACCEPTED and CVS action done. This is simply to require the
submitter to make a final entry into the review request that indicates
the URL to the spec file on the fedora cvs server {or any future package
source repo}. Preferably via the web interface viewcvs.


While some people think that the package submission, review, maintenance
can be burdensome, I think this would be an improvement to assist
learning packagers in seeing what the final completed .spec looks like.


At the moment, many .spec URLs that are hosted outside Fedora are taken
down the moment or shortly after the process is complete. Hence it makes
it difficult to learn from the efforts of others in a package review in
Fedora because the .spec is no longer linked in the spec/SRPM urls
provided by the submitter.


The second issue is that browsing the cvs server is quite slow - mainly
at the point where the "folder" has the complete list of {3000} package
folders. This means we could immediately click through to the correct
folder in the cvs server, rather than trawling from the top level.


Any comments, rejections to this idea ?



-1

This means yet another step in getting a package included, we need less steps
not more. For the rare circumstance when someone does need access to a spec
there are several ways, almost all of them easier then first going through a
bugzilla query to find the original review.


Regards,

Hans

--
Fedora-packaging mailing list
Fedora-packaging@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-packaging
 
Old 04-06-2008, 03:26 PM
Toshio Kuratomi
 
Default Suggestion: require inclusion of cvs location in completed review request

David Timms wrote:

At the moment, many .spec URLs that are hosted outside Fedora are taken
down the moment or shortly after the process is complete. Hence it makes
it difficult to learn from the efforts of others in a package review in
Fedora because the .spec is no longer linked in the spec/SRPM urls
provided by the submitter.


The second issue is that browsing the cvs server is quite slow - mainly
at the point where the "folder" has the complete list of {3000} package
folders. This means we could immediately click through to the correct
folder in the cvs server, rather than trawling from the top level.


This is only a partial help since it's not easily discoverable by a new
user but it will keep you from having to browse the complete foleder
list on the cvs server::

http://cvs.fedoraproject.org/viewcvs/rpms/PKGNAME


Any comments, rejections to this idea ?

Like Rathann, I'm against this if it's a manual requirement but if it
were automated it would be useful. If you would be willing to
contribute some code, the cvs request needs to become something that is
entered into the package database. The bugzilla address will be entered
as part of this so that the cvs admin can continue to verify the
reviews. So it would be possible to automate adding a link to viewcvs
at the end of this process.


In the meantime, if you think it is a good idea, it would be appreciated
for others to do this in any case - if that is allowed ?


If a packager wants to do this themselves they are welcome to do it.


===
Another idea along these lines would be to have a staging CVS server
that the reviewer would be required to commit the original and changes
to the spec under development. This could then be committed to the real
cvs server after acceptance. The submitter would still put his srpms on
his own url, not in the staging cvs server.


This would make it simpler to get a live diff on what the submitter's
changes have been, rather than viewing the spec as a whole and trying to
find the changes.


This could be useful but it would be a separate process for people to
learn and a separate cvs instance that would have to be maintained. I'm
not sure that we want to do this because of the overhead. At least,
we'd want to get the pkgdb's automated closing of package bugs written
first so we could see if we could make an automated opening as well.


(Note: This would require people, at minimum, to have signed the CLA
before submitting their first package.)


-Toshio

--
Fedora-packaging mailing list
Fedora-packaging@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-packaging
 
Old 04-06-2008, 07:54 PM
Jason L Tibbitts III
 
Default Suggestion: require inclusion of cvs location in completed review request

>>>>> "HdG" == Hans de Goede <j.w.r.degoede@hhs.nl> writes:

HdG> This means yet another step in getting a package included, we
HdG> need less steps not more.

I agree; it's also yet another bit of bugspam in a process that
generates a huge load of it as it is.

As long as we keep the package name in the summary correct, the
CVS location is trivially derived from that and thus entirely
redundant. So sure, better document how to get to imported packages
in the wiki all you want. But please, no additional demands on the
already burdensome review process.

- J<

--
Fedora-packaging mailing list
Fedora-packaging@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-packaging
 
Old 04-06-2008, 08:19 PM
Till Maas
 
Default Suggestion: require inclusion of cvs location in completed review request

On Sun April 6 2008, David Timms wrote:

> The second issue is that browsing the cvs server is quite slow - mainly
> at the point where the "folder" has the complete list of {3000} package
> folders. This means we could immediately click through to the correct
> folder in the cvs server, rather than trawling from the top level.
>
> Any comments, rejections to this idea ?

Here is a shell script that gives you the url to the relevant spec files for
any package, that is in Fedora cvs:

#!/bin/bash
PACKAGE_NAME=$1
echo CVS Basedir:
echo http://cvs.fedoraproject.org/viewcvs/rpms/$PACKAGE_NAME
echo CVS devel spec:
echo
http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/$PACKAGE_NAME/devel/$PACKAGE_NAME.spec
echo CVS imported spec:
echo
http://cvs.fedoraproject.org/viewcvs/*checkout*/rpms/$PACKAGE_NAME/devel/$PACKAGE_NAME.spec?rev=1.1

Regards,
Till
--
Fedora-packaging mailing list
Fedora-packaging@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-packaging
 
Old 04-06-2008, 09:05 PM
Till Maas
 
Default Suggestion: require inclusion of cvs location in completed review request

On Sun April 6 2008, Till Maas wrote:
> On Sun April 6 2008, David Timms wrote:
> > The second issue is that browsing the cvs server is quite slow - mainly
> > at the point where the "folder" has the complete list of {3000} package
> > folders. This means we could immediately click through to the correct
> > folder in the cvs server, rather than trawling from the top level.
> >
> > Any comments, rejections to this idea ?
>
> Here is a shell script that gives you the url to the relevant spec files
> for any package, that is in Fedora cvs:

And here is a JavaScript application:
http://till.fedorapeople.org/cvs_url.html


Regards,
Till
--
Fedora-packaging mailing list
Fedora-packaging@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-packaging
 

Thread Tools




All times are GMT. The time now is 07:11 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org