Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Packaging (http://www.linux-archive.org/fedora-packaging/)
-   -   pre-compiled binaries in SRPM/source tarball (http://www.linux-archive.org/fedora-packaging/499344-pre-compiled-binaries-srpm-source-tarball.html)

"jan.klepek" 03-09-2011 07:44 PM

pre-compiled binaries in SRPM/source tarball
 
Hi,

I have question, when I got tarball from upstream or I'm creating
tarball by myself from their git repo, which contains binary (exe) file.
Is there any packaging guideline that forces me to exclude this binary
file before tarball is created/used in srpm?

Christopher Aillon is trying to convince that below guideline has to be
applied to source tarball also.
http://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

However I don't see any reference to SRPM/source tarball and I was in
impression that this is only for final (builded) rpm as otherwise it
would break review guidelines (rule for comparing source tarball in SRPM
and tarball from upstream).

Thanks for answer.

Regards,
Jan Klepek


--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Rex Dieter 03-09-2011 07:47 PM

pre-compiled binaries in SRPM/source tarball
 
On 03/09/2011 02:44 PM, jan.klepek wrote:

> I have question, when I got tarball from upstream or I'm creating
> tarball by myself from their git repo, which contains binary (exe) file.
> Is there any packaging guideline that forces me to exclude this binary
> file before tarball is created/used in srpm?
>
> Christopher Aillon is trying to convince that below guideline has to be
> applied to source tarball also.
> http://fedoraproject.org/wiki/Packaging/Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
>
> However I don't see any reference to SRPM/source tarball and I was in
> impression that this is only for final (builded) rpm as otherwise it
> would break review guidelines (rule for comparing source tarball in SRPM
> and tarball from upstream).

It just says this:

When you encounter prebuilt binaries in a package you MUST:
* Remove all pre-built program binaries and program libraries in
%prep prior to the building of the package. Examples include, but are
not limited to, *.class, *.dll, *.DS_Store, *.exe, *.jar, *.o, *.pyc,
*.pyo, *.egg, *.so files.
* Ask upstream to remove the binaries in their next release.

so nuking the stuff in %prep is ok.

remaking a tarball is generally only required if it includes items that
aren't redistributable.

-- Rex
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Tom Callaway 03-09-2011 08:27 PM

pre-compiled binaries in SRPM/source tarball
 
On 03/09/2011 03:47 PM, Rex Dieter wrote:
> remaking a tarball is generally only required if it includes items that
> aren't redistributable.

Just in case it wasn't obvious, this is the answer, I say with my Fedora
Legal hat on. :)

~tom

==
Fedora Project
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

"jan.klepek" 03-09-2011 08:38 PM

pre-compiled binaries in SRPM/source tarball
 
On Wed, 2011-03-09 at 16:27 -0500, Tom Callaway wrote:
> remaking a tarball is generally only required if it includes items
> that
> > aren't redistributable.
>
>

Ok, so exe file in source tarball could stay (as it is not used by build
and it is just silently ignored and not used in final rpm).

Thanks for clarifying this.

Regards,
Jan

--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Tom Callaway 03-09-2011 09:13 PM

pre-compiled binaries in SRPM/source tarball
 
On 03/09/2011 04:38 PM, jan.klepek wrote:
> On Wed, 2011-03-09 at 16:27 -0500, Tom Callaway wrote:
>> remaking a tarball is generally only required if it includes items
>> that
>>> aren't redistributable.
>>
>>
>
> Ok, so exe file in source tarball could stay (as it is not used by build
> and it is just silently ignored and not used in final rpm).

If the licensing is clear and it permits unrestricted redistribution,
yes. If not, then the answer may be no.

~tom

==
Fedora Project
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

Christopher Aillon 03-09-2011 09:27 PM

pre-compiled binaries in SRPM/source tarball
 
On 03/09/2011 02:13 PM, Tom Callaway wrote:
> On 03/09/2011 04:38 PM, jan.klepek wrote:
>> On Wed, 2011-03-09 at 16:27 -0500, Tom Callaway wrote:
>>> remaking a tarball is generally only required if it includes items
>>> that
>>>> aren't redistributable.
>>>
>>>
>>
>> Ok, so exe file in source tarball could stay (as it is not used by build
>> and it is just silently ignored and not used in final rpm).
>
> If the licensing is clear and it permits unrestricted redistribution,
> yes. If not, then the answer may be no.

Then I'd ask for clarification of "When you encounter prebuilt binaries
in a package you MUST: "

since source packages are still packages.
--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

"Nicolas Mailhot" 03-10-2011 09:02 AM

pre-compiled binaries in SRPM/source tarball
 
Le Mer 9 mars 2011 22:38, jan.klepek a écrit :
>
> On Wed, 2011-03-09 at 16:27 -0500, Tom Callaway wrote:
>> remaking a tarball is generally only required if it includes items
>> that
>> > aren't redistributable.
>>
>>
>
> Ok, so exe file in source tarball could stay (as it is not used by build
> and it is just silently ignored and not used in final rpm).

The intent of removing the files in %prep is to make sure it's not used one
way or the other during the rpm build process

--
Nicolas Mailhot


--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging

"jan.klepek" 03-10-2011 10:09 AM

pre-compiled binaries in SRPM/source tarball
 
On Thu, 2011-03-10 at 11:02 +0100, Nicolas Mailhot wrote:
>
> Le Mer 9 mars 2011 22:38, jan.klepek a écrit :
> >
> > On Wed, 2011-03-09 at 16:27 -0500, Tom Callaway wrote:
> >> remaking a tarball is generally only required if it includes items
> >> that
> >> > aren't redistributable.
> >>
> >>
> >
> > Ok, so exe file in source tarball could stay (as it is not used by build
> > and it is just silently ignored and not used in final rpm).
>
> The intent of removing the files in %prep is to make sure it's not used one
> way or the other during the rpm build process

Yes, I understand why it should be removed during %prep, however in my
case %build is empty and %install consists of several copy commands and
desktop file install.
So I don't remove such file during %prep as I see it as useless as there
is guarantee that it is not used anyhow during %build/%install. And my
question was rather if such file could be present in source tarball from
upstream/repository, I'm not arguing about removal of such files during
%prep.

Jan

--
packaging mailing list
packaging@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/packaging


All times are GMT. The time now is 02:54 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.