Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Packaging (http://www.linux-archive.org/fedora-packaging/)
-   -   Fix: execWithRedirect() unexpectedkeyword argument 'searchPath' (#572853) (http://www.linux-archive.org/fedora-packaging/342442-fix-execwithredirect-unexpectedkeyword-argument-searchpath-572853-a.html)

David Lehman 03-16-2010 03:47 PM

Fix: execWithRedirect() unexpectedkeyword argument 'searchPath' (#572853)
 
Looks good to me. Those calls to udevadm settle should probably be
replaced with calls to udev.udev_settle at some point, but not now.

Dave

On Tue, 2010-03-16 at 10:07 +0100, Hans de Goede wrote:
> ---
> storage/fcoe.py | 18 ++++++------------
> 1 files changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/storage/fcoe.py b/storage/fcoe.py
> index fb42be7..4b8d807 100644
> --- a/storage/fcoe.py
> +++ b/storage/fcoe.py
> @@ -69,8 +69,7 @@ class fcoe(object):
> # I have no clue how long we need to wait, this ought to do the trick
> time.sleep(10)
> iutil.execWithRedirect("udevadm", [ "settle" ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
> if intf:
> w.pop()
>
> @@ -91,8 +90,7 @@ class fcoe(object):
> return
>
> iutil.execWithRedirect("dcbd", [ "-d" ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
> self.dcbdStarted = True
>
> def _startFcoemon(self):
> @@ -100,8 +98,7 @@ class fcoe(object):
> return
>
> iutil.execWithRedirect("fcoemon", [ ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
> self.fcoemonStarted = True
>
> def addSan(self, nic, dcb=False, intf=None):
> @@ -111,18 +108,15 @@ class fcoe(object):
> log.info("Activating FCoE SAN attached to %s, dcb: %s" % (nic, dcb))
>
> iutil.execWithRedirect("ip", [ "link", "set", nic, "up" ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
>
> if dcb:
> self._startDcbd()
> iutil.execWithRedirect("dcbtool", [ "sc", nic, "dcb", "on" ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
> iutil.execWithRedirect("dcbtool", [ "sc", nic, "app:fcoe",
> "e:1", "a:1", "w:1" ],
> - stdout = "/dev/tty5", stderr="/dev/tty5",
> - searchPath = 1)
> + stdout = "/dev/tty5", stderr="/dev/tty5")
> self._startFcoemon()
> else:
> f = open("/sys/module/fcoe/parameters/create", "w")


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 08:20 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.