This looks okay to me. It does make me wonder if the req_grow property
should be attached to StorageDevice and traverse all ancestors looking
for growable devices, but that might be mostly academic.

Dave

On Fri, 2010-05-07 at 14:56 +0200, Ales Kozumplik wrote:
> without the patch following ks line is a problem:
> part pv.hd --grow --size=1 --encrypted --passphrase=firsttest
>
> this creates a VG on a LUKSDevice that has a PartitionDevice as its
> "slave" device. the partition device has 'req_grow' set to true as to True
> but not the luks device so adding any logical volume to the VG fails with
> insufficient space.
> ---
> storage/devices.py | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/storage/devices.py b/storage/devices.py
> index 7e23b9e..ad4396c 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1681,6 +1681,10 @@ class LUKSDevice(DMCryptDevice):
> self.teardown()
>
> @property
> + def req_grow(self):
> + return getattr(self.slave, "req_grow", None)
> +
> + @property
> def slave(self):
> """ This device's backing device. """
> return self.parents[0]


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list