FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Marketing

 
 
LinkBack Thread Tools
 
Old 04-12-2010, 05:12 PM
Peter Jones
 
Default mpath: call to execWithRedirect needs searchPath=1 (#579654).

On 04/12/2010 12:39 PM, David Lehman wrote:
> On Mon, 2010-04-12 at 10:02 +0200, Ales Kozumplik wrote:
>> On 04/12/2010 09:57 AM, Ales Kozumplik wrote:
>>> ---
>>> storage/devices.py | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/storage/devices.py b/storage/devices.py
>>> index 387c4b4..03d143a 100644
>>> --- a/storage/devices.py
>>> +++ b/storage/devices.py
>>> @@ -3106,7 +3106,8 @@ class MultipathDevice(DMDevice):
>>> rc = iutil.execWithRedirect("multipath",
>>> [self.name],
>>> stdout = "/dev/tty5",
>>> - stderr = "/dev/tty5")
>>> + stderr = "/dev/tty5",
>>> + searchPath = 1)
>>> if rc:
>>> raise MPathError("multipath activation failed for '%s'" %
>>> self.name)
>>
>> This is also missing from f13-branch and should go there if we support
>> multipath for Fedora.
>
> searchPath was removed from iutil.execWithRedirect on master and
> f13-branch. (commit 7e9ddee96)

... there's something odd going on here. We took "searchPath" out because it
wasn't used, but execWithRedirect() doesn't currently seem to be searching PATH,
though at the time I think it did. I'm really not sure how this changed,
but it really needs to be always using PATH.

--
Peter

All parts should go together without forcing. You must remember that
the parts you are reassembling were disassembled by you. Therefore,
if you can't get them together again, there must be a reason. By all
means, do not use a hammer.
-- IBM maintenance manual, 1925

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-12-2010, 05:13 PM
Peter Jones
 
Default mpath: call to execWithRedirect needs searchPath=1 (#579654).

On 04/12/2010 01:12 PM, Peter Jones wrote:
> On 04/12/2010 12:39 PM, David Lehman wrote:
>> On Mon, 2010-04-12 at 10:02 +0200, Ales Kozumplik wrote:
>>> On 04/12/2010 09:57 AM, Ales Kozumplik wrote:
>>>> ---
>>>> storage/devices.py | 3 ++-
>>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>>
>>>> diff --git a/storage/devices.py b/storage/devices.py
>>>> index 387c4b4..03d143a 100644
>>>> --- a/storage/devices.py
>>>> +++ b/storage/devices.py
>>>> @@ -3106,7 +3106,8 @@ class MultipathDevice(DMDevice):
>>>> rc = iutil.execWithRedirect("multipath",
>>>> [self.name],
>>>> stdout = "/dev/tty5",
>>>> - stderr = "/dev/tty5")
>>>> + stderr = "/dev/tty5",
>>>> + searchPath = 1)
>>>> if rc:
>>>> raise MPathError("multipath activation failed for '%s'" %
>>>> self.name)
>>>
>>> This is also missing from f13-branch and should go there if we support
>>> multipath for Fedora.
>>
>> searchPath was removed from iutil.execWithRedirect on master and
>> f13-branch. (commit 7e9ddee96)
>
> ... there's something odd going on here. We took "searchPath" out because it
> wasn't used, but execWithRedirect() doesn't currently seem to be searching PATH,
> though at the time I think it did. I'm really not sure how this changed,
> but it really needs to be always using PATH.

By which I mean that execWithRedirect() should always search the path, and no
argument should be necessary.

--
Peter

All parts should go together without forcing. You must remember that
the parts you are reassembling were disassembled by you. Therefore,
if you can't get them together again, there must be a reason. By all
means, do not use a hammer.
-- IBM maintenance manual, 1925

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:58 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org