FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Marketing

 
 
LinkBack Thread Tools
 
Old 03-30-2010, 06:43 PM
Peter Jones
 
Default Copy install.img and remount no matter how many discs (#577196)

It seems we have unmount/reboot problems when using only one disc when
we don't copy the install.img. So always do that.
---
backend.py | 3 +--
yuminstall.py | 9 ++++-----
2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/backend.py b/backend.py
index 6ca14a8..65a6a67 100644
--- a/backend.py
+++ b/backend.py
@@ -153,8 +153,7 @@ class AnacondaBackend:
if self._loopbackFile and os.path.exists(self._loopbackFile):
return

- # If we've booted off the first CD (so, not the boot.iso or DVD) then
- # copy the install.img to the filesystem and switch loopback devices
+ # Copy the install.img to the filesystem and switch loopback devices
# to there. Otherwise we won't be able to unmount and swap media.
free = anaconda.storage.fsFreeSpace
self._loopbackFile = "%s%s/rhinstall-install.img" % (anaconda.rootPath,
diff --git a/yuminstall.py b/yuminstall.py
index 244702e..de7e974 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -899,11 +899,10 @@ class AnacondaYum(YumSorter):
mkeys = self.tsInfo.reqmedia.keys()
mkeys.sort(mediasort)

- if len(mkeys) > 1:
- stage2img = "%s/images/install.img" % self.tree
- if self.anaconda.backend.mountInstallImage(self.anaco nda, stage2img):
- self.anaconda.storage.umountFilesystems()
- return DISPATCH_BACK
+ stage2img = "%s/images/install.img" % self.tree
+ if self.anaconda.backend.mountInstallImage(self.anaco nda, stage2img):
+ self.anaconda.storage.umountFilesystems()
+ return DISPATCH_BACK

for i in mkeys:
self.tsInfo.curmedia = i
--
1.7.0.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-30-2010, 06:58 PM
Hans de Goede
 
Default Copy install.img and remount no matter how many discs (#577196)

Hi,

I'm not in favor of this fix, it seems like an awefully big hammer, for
a problem which judging from the bug report is not fully understood yet.

Also this will mean trading in one problem for another, as copy-ing
install.img to the HD is not without problems itself.

Regards,

Hans


On 03/30/2010 08:43 PM, Peter Jones wrote:

It seems we have unmount/reboot problems when using only one disc when
we don't copy the install.img. So always do that.
---
backend.py | 3 +--
yuminstall.py | 9 ++++-----
2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/backend.py b/backend.py
index 6ca14a8..65a6a67 100644
--- a/backend.py
+++ b/backend.py
@@ -153,8 +153,7 @@ class AnacondaBackend:
if self._loopbackFile and os.path.exists(self._loopbackFile):
return

- # If we've booted off the first CD (so, not the boot.iso or DVD) then
- # copy the install.img to the filesystem and switch loopback devices
+ # Copy the install.img to the filesystem and switch loopback devices
# to there. Otherwise we won't be able to unmount and swap media.
free = anaconda.storage.fsFreeSpace
self._loopbackFile = "%s%s/rhinstall-install.img" % (anaconda.rootPath,
diff --git a/yuminstall.py b/yuminstall.py
index 244702e..de7e974 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -899,11 +899,10 @@ class AnacondaYum(YumSorter):
mkeys = self.tsInfo.reqmedia.keys()
mkeys.sort(mediasort)

- if len(mkeys)> 1:
- stage2img = "%s/images/install.img" % self.tree
- if self.anaconda.backend.mountInstallImage(self.anaco nda, stage2img):
- self.anaconda.storage.umountFilesystems()
- return DISPATCH_BACK
+ stage2img = "%s/images/install.img" % self.tree
+ if self.anaconda.backend.mountInstallImage(self.anaco nda, stage2img):
+ self.anaconda.storage.umountFilesystems()
+ return DISPATCH_BACK

for i in mkeys:
self.tsInfo.curmedia = i


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:36 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org