from conversation on #xen.... current Solaris virt-install patches attached.
Disclaimers :-)
This are informational only (e.g. not proposing they be applied)..
They still need cleanup etc.. These patches are what are in the
current solaris builds.
We are currently still working on the lastest version of virt-install.
For the interested, the source is generally available @ the following
until we move the gate on the other side of the firewall, you can
download the xvm specific source @
http://dlc.sun.com/osol/on/downloads/b77/xvm-src.tar.bz2
(where b77 is the OpenSolaris build).
You'll see the following dirs in there, libvirt, sunos, and urlgrabber
are hg gates, urlgrabber and xen are hg mq gates (long story)... :-)
MRJ
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
12-04-2007, 09:54 AM
"Richard W.M. Jones"
solaris virt-install patches
Mark Johnson wrote:
from conversation on #xen.... current Solaris virt-install patches attached.
Disclaimers :-)
This are informational only (e.g. not proposing they be applied)..
They still need cleanup etc.. These patches are what are in the
current solaris builds.
We are currently still working on the lastest version of virt-install.
Hi Mark,
It was a bit hard to read your patches because they weren't attached
with a text MIME-type. Renaming them as '*.txt' or '*.patch', or
reconfiguring your MUA should fix that.
mac-address-parse: Looks fine
use-virsh-console: Sensible patch
outgoing:
This patch seems to be corrupt in some way. A diff of a diff?
solaris-support:
Solaris puts the Python interpreter in /bin instead of /usr/bin. This
will break things on Linux so we should fix this so it can find the
Python interpreter along the path. No idea how to fix this with Python
but I'm sure there's a standard way involving 'env' or something similar.
The rest of the patch looks sensible. In general all this code needs
rewriting to support capabilities and the storage API (once that's in
libvirt), but for a fix now it's fine.
Rich.
--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
12-04-2007, 12:05 PM
"Mark Johnson"
solaris virt-install patches
On Dec 4, 2007 5:54 AM, Richard W.M. Jones <rjones@redhat.com> wrote:
> Mark Johnson wrote:
> > from conversation on #xen.... current Solaris virt-install patches attached.
> >
> > Disclaimers :-)
> > This are informational only (e.g. not proposing they be applied)..
> > They still need cleanup etc.. These patches are what are in the
> > current solaris builds.
> > We are currently still working on the lastest version of virt-install.
>
> Hi Mark,
>
> It was a bit hard to read your patches because they weren't attached
> with a text MIME-type. Renaming them as '*.txt' or '*.patch', or
> reconfiguring your MUA should fix that.
Sorry about that.. :-(
> mac-address-parse: Looks fine
>
> use-virsh-console: Sensible patch
>
> outgoing:
> This patch seems to be corrupt in some way. A diff of a diff?
I was in a rush, included that file by mistake..
> solaris-support:
>
> Solaris puts the Python interpreter in /bin instead of /usr/bin. This
> will break things on Linux so we should fix this so it can find the
> Python interpreter along the path. No idea how to fix this with Python
> but I'm sure there's a standard way involving 'env' or something similar.
No need to. We shouldn't be changing that. It's a bug on
our end (/bin can be a sym link to /usr/bin).
> The rest of the patch looks sensible. In general all this code needs
> rewriting to support capabilities and the storage API (once that's in
> libvirt), but for a fix now it's fine.
Thanks,
MRJ
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
12-05-2007, 12:06 AM
"Daniel P. Berrange"
solaris virt-install patches
On Fri, Nov 30, 2007 at 11:13:03AM -0500, Mark Johnson wrote:
> from conversation on #xen.... current Solaris virt-install patches attached.
>
> Disclaimers :-)
> This are informational only (e.g. not proposing they be applied)..
> They still need cleanup etc.. These patches are what are in the
> current solaris builds.
> We are currently still working on the lastest version of virt-install.
I applied the MAC address patch since that was trivial. The xm console
stuff we already fixed. Likewise the vncviewer changes should disappear
when you re-base, since we now use virt-viewer.
The other changes all basically look sane. Some of them are actually
needed on Linux too - eg switching to use capabilities API instead of
touching /proc or /sys.
I'd recommend moving the SunOS_installxargs method to the OSDistro.py
file in the SolarisOSDistro class just to keep it all in one place.
Simiarly I'd prefer to see the loopback mount/unmount stuff kept in the
ImageFetcher module directly rather than in util.py