FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora/Linux Management Tools

 
 
LinkBack Thread Tools
 
Old 02-09-2009, 07:21 AM
Mark McLoughlin
 
Default virt-manager: remove disambiguity in "free space" dialog

Hi Guido,

On Sat, 2009-02-07 at 21:34 +0100, Guido GŁnther wrote:
> - res = self.err.yes_no(_("Not Enough Free Space"), ret[1])
> + res = self.err.yes_no(_("Not Enough Free Space"), _("%s. Continue anyway?") % ret[1])
> if not res:
> return False

See the GNOME HIG:

http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-button-order

I think what you want here is to change the buttons to Cancel/Continue -
i.e. a Cancel button and an affirmative verb button.

Cheers,
Mark.

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
 
Old 02-13-2009, 11:13 AM
Guido GŁnther
 
Default virt-manager: remove disambiguity in "free space" dialog

On Mon, Feb 09, 2009 at 08:21:29AM +0000, Mark McLoughlin wrote:
> Hi Guido,
>
> On Sat, 2009-02-07 at 21:34 +0100, Guido GŁnther wrote:
> > - res = self.err.yes_no(_("Not Enough Free Space"), ret[1])
> > + res = self.err.yes_no(_("Not Enough Free Space"), _("%s. Continue anyway?") % ret[1])
> > if not res:
> > return False
>
> See the GNOME HIG:
>
> http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-button-order
>
> I think what you want here is to change the buttons to Cancel/Continue -
> i.e. a Cancel button and an affirmative verb button.
I've changed this to "Ok/Cancel" in the attached patch. A simple Ok
looks more obvious to me in this case since I'd be unsure to continue
with what (it's not creating wizard in the case of add_hardware) and the
only thing the user has to do is to acknowledge.
-- Guido
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
 
Old 02-16-2009, 11:51 PM
Cole Robinson
 
Default virt-manager: remove disambiguity in "free space" dialog

Guido GŁnther wrote:
> On Mon, Feb 09, 2009 at 08:21:29AM +0000, Mark McLoughlin wrote:
>> Hi Guido,
>>
>> On Sat, 2009-02-07 at 21:34 +0100, Guido GŁnther wrote:
>>> - res = self.err.yes_no(_("Not Enough Free Space"), ret[1])
>>> + res = self.err.yes_no(_("Not Enough Free Space"), _("%s. Continue anyway?") % ret[1])
>>> if not res:
>>> return False
>> See the GNOME HIG:
>>
>> http://library.gnome.org/devel/hig-book/stable/windows-alert.html.en#alert-button-order
>>
>> I think what you want here is to change the buttons to Cancel/Continue -
>> i.e. a Cancel button and an affirmative verb button.
> I've changed this to "Ok/Cancel" in the attached patch. A simple Ok
> looks more obvious to me in this case since I'd be unsure to continue
> with what (it's not creating wizard in the case of add_hardware) and the
> only thing the user has to do is to acknowledge.
> -- Guido
>

Thanks, applied now:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/60940c2af2db

- Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
 

Thread Tools




All times are GMT. The time now is 09:44 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org