Hi all,

I've added some changes to the virtinst test suite that will affect
anyone writing patches. Two commands have been added to the setup.py script:

python setup.py check : runs a pylint wrapper against the

codebase
python setup.py test_urls: runs a url fetching test suite

A patch shouldn't change the output of 'check'. If you hit something
which you think is a false positive or an unnecessary check, bring it up
on the list (though I've tried to remove all the blatantly useless
checks already). 'check' uses the pylint utility.

'test_urls' only needs to be run if changes are against the url fetching
code (virtinst/OSDistro and some virtinst/Distromanager). It takes a
while to run and requires a network connection, so I didn't include it
as part of the regular test suite ('setup.py test', which should also be
run with any changes).

All the above info was added to a HACKING file as well. I'll also be
adding a similar pylint script to virt-manager in the near future.

Thanks,
Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

HI Cole,
On Mon, Nov 24, 2008 at 05:24:45PM -0500, Cole Robinson wrote:
> Hi all,
>
> I've added some changes to the virtinst test suite that will affect
> anyone writing patches. Two commands have been added to the setup.py script:
>
> python setup.py check : runs a pylint wrapper against the
>
> codebase
> python setup.py test_urls: runs a url fetching test suite
Cool thing! Would it make sense to release a new version? Hg acquired
quiet some new features and bugfixes, so I'd probably make sense. Having
virtinst release more often would help distros to get the new stuff out
quicker.
-- Guido

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Guido Günther wrote:
> HI Cole,
> On Mon, Nov 24, 2008 at 05:24:45PM -0500, Cole Robinson wrote:
>> Hi all,
>>
>> I've added some changes to the virtinst test suite that will affect
>> anyone writing patches. Two commands have been added to the setup.py script:
>>
>> python setup.py check : runs a pylint wrapper against the
>>
>> codebase
>> python setup.py test_urls: runs a url fetching test suite
> Cool thing! Would it make sense to release a new version? Hg acquired
> quiet some new features and bugfixes, so I'd probably make sense. Having
> virtinst release more often would help distros to get the new stuff out
> quicker.
> -- Guido
>

Completely agreed on releasing more often: the huge lapse between the
previous two releases was no good. I think pushing new virtinst +
virt-manager in a couple weeks would be fine, there are still a couple
other things I'd like to pick off until then. Going forward, my goal is
to have an actual schedule, and transparency wrt planned features,
timelines, etc.

Thanks,
Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools