Daniel P. Berrange wrote:
> On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
>> This adds the underlying support for disk signatures into virt-convert
>> disk class for each disk. Additional changes to follow in completing
>> implementation
>
> There's not much point in doing md5 and sha1, both are more or
> less equivalent strength and compromised algorithms. Doing both
> is just wasting CPU resources. Pick either md5 or sha1 for sake
> of compatability with old python, and then sha256 for strength.
>
OVF seems to offer sha-1 hashes for packaged files, so let's
use that and sha256.
Stick a new line after this to preserve the previous spacing.
>> def ensuredirs(path):
>> """
>> Make sure that all the containing directories of the given file
>> @@ -83,6 +88,7 @@
>> self.bus = bus
>> self.type = type
>> self.clean = []
>> + self.csum_dict = {}
>>
>> def cleanup(self):
>> """
>
Thanks,
Cole
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
10-09-2008, 01:45 PM
Joey Boggs
virt-convert - disk signature support - patch 1
Corrected spacing and removed md5
Cole Robinson wrote:
Daniel P. Berrange wrote:
On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
This adds the underlying support for disk signatures into virt-convert
disk class for each disk. Additional changes to follow in completing
implementation
There's not much point in doing md5 and sha1, both are more or
less equivalent strength and compromised algorithms. Doing both
is just wasting CPU resources. Pick either md5 or sha1 for sake
of compatability with old python, and then sha256 for strength.
OVF seems to offer sha-1 hashes for packaged files, so let's
use that and sha256.
Stick a new line after this to preserve the previous spacing.
def ensuredirs(path):
"""
Make sure that all the containing directories of the given file
@@ -83,6 +88,7 @@
self.bus = bus
self.type = type
self.clean = []
+ self.csum_dict = {}
def cleanup(self):
"""
Thanks,
Cole
_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
10-09-2008, 02:53 PM
Joey Boggs
virt-convert - disk signature support - patch 1
Did some more testing and made some syntax changes, should work now
Joey Boggs wrote:
Corrected spacing and removed md5
Cole Robinson wrote:
Daniel P. Berrange wrote:
On Wed, Oct 08, 2008 at 12:22:05PM -0400, Joey Boggs wrote:
This adds the underlying support for disk signatures into
virt-convert disk class for each disk. Additional changes to follow
in completing implementation
There's not much point in doing md5 and sha1, both are more or
less equivalent strength and compromised algorithms. Doing both
is just wasting CPU resources. Pick either md5 or sha1 for sake
of compatability with old python, and then sha256 for strength.
OVF seems to offer sha-1 hashes for packaged files, so let's
use that and sha256.
Stick a new line after this to preserve the previous spacing.
def ensuredirs(path):
"""
Make sure that all the containing directories of the given file
@@ -83,6 +88,7 @@
self.bus = bus
self.type = type
self.clean = []
+ self.csum_dict = {}
virt-convert - disk signature support - patch 1
