When generating error message about a bad reference from a drive to a disk,
use disk_id attribute for the drive and make it clearer that we are talking
about a problem in the XML, not that a file is actually missing.

diff -r 4227c03796d6 -r 11d9412efc34 virtinst/ImageParser.py
--- a/virtinst/ImageParser.py Tue Dec 04 15:17:10 2007 -0800
+++ b/virtinst/ImageParser.py Tue Dec 04 15:17:12 2007 -0800
@@ -60,8 +60,8 @@ class Image:
for boot in self.domain.boots:
for d in boot.disks:
if not self.storage.has_key(d.disk_id):
- raise ParserException(_("Disk '%s' not found")
- % d.file)
+ raise ParserException(_("Disk entry for '%s' not found")
+ % d.disk_id)
d.disk = self.storage[d.disk_id]

class Domain:

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

On Tue, Dec 04, 2007 at 04:44:57PM -0800, David Lutterkort wrote:
> When generating error message about a bad reference from a drive to a disk,
> use disk_id attribute for the drive and make it clearer that we are talking
> about a problem in the XML, not that a file is actually missing.

ACK


Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools