Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora/Linux Management Tools (http://www.linux-archive.org/fedora-linux-management-tools/)
-   -   cobbler buildiso add --systems option and fix --profiles selection. (http://www.linux-archive.org/fedora-linux-management-tools/109395-cobbler-buildiso-add-systems-option-fix-profiles-selection.html)

Jim Wildman 06-18-2008 10:19 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
On Wed, 18 Jun 2008, Dave Hatton wrote:


The attached patch is for the "cobbler buildiso" command
1. It fixes the --profile option so that you can now *really* specify which
profiles you wish to include in the kickstart.iso
2. It adds a --systems option to allow you add specific systems to the
kickstart.iso


What is the process for having this reviewed and if suitable, merged into
cobbler?




Probably starts with waiting for Mike to get back from the Summit in
Boston.

------------------------------------------------------------------------
Jim Wildman, CISSP, RHCE jim@rossberry.com http://www.rossberry.com
"Society in every state is a blessing, but Government, even in its best
state, is a necessary evil; in its worst state, an intolerable one."
Thomas Paine

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Michael DeHaan 06-21-2008 02:39 AM

cobbler buildiso add --systems option and fix --profiles selection.
 
Dave Hatton wrote:

The attached patch is for the "cobbler buildiso" command
1. It fixes the --profile option so that you can now *really* specify
which profiles you wish to include in the kickstart.iso
2. It adds a --systems option to allow you add specific systems to the
kickstart.iso


What is the process for having this reviewed and if suitable, merged
into cobbler?


Regards

Daveh


This looks great to me, I'll test and apply early next week.

Thanks!

--Michael



------------------------------------------------------------------------

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools


_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

"Joseph Boyer Jr." 06-24-2008 01:25 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Hello there...

I have made some updates to the updates that Dave H had made to the action_buildiso.py.

Here is the list of my updates: (P.S. I am new to python so if my coding sucks, please bear with me)

1. reordered the build iso menu so that systems are first.

2. Did not understand why we rely on DHCP when you have a "System". So I have added the networking information to the kernel line for systems, thus eliminating the need for DHCP. (This is what I needed in the boot iso).

3. Update the copy initrd and kernel so that only the initrd and kernel for the systems listed are copied. (did not see any need to have a huge boot iso, if you have many distros, and wanted to keep it as small as possible.)

4. The boot menu will only list systems if --system is given on the cmdline. By default bootiso will build the boot menu for all profiles list in cobbler.

Cheers,
joe

Joseph Boyer Jr
Enterprise Technology Services
Liquidnet Holdings, Inc.
Joseph.Boyer@liquidnet.com
T +1 646.660.8352
C +1 646.284.8394

-----Original Message-----
From: et-mgmt-tools-bounces@redhat.com [mailto:et-mgmt-tools-bounces@redhat.com] On Behalf Of Michael DeHaan
Sent: Friday, June 20, 2008 10:39 PM
To: Fedora/Linux Management Tools
Subject: Re: [et-mgmt-tools] [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

Dave Hatton wrote:
> The attached patch is for the "cobbler buildiso" command
> 1. It fixes the --profile option so that you can now *really* specify
> which profiles you wish to include in the kickstart.iso
> 2. It adds a --systems option to allow you add specific systems to the
> kickstart.iso
>
> What is the process for having this reviewed and if suitable, merged
> into cobbler?
>
> Regards
>
> Daveh

This looks great to me, I'll test and apply early next week.

Thanks!

--Michael


> ------------------------------------------------------------------------
>
> _______________________________________________
> et-mgmt-tools mailing list
> et-mgmt-tools@redhat.com
> https://www.redhat.com/mailman/listinfo/et-mgmt-tools

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

"Joseph Boyer Jr." 06-24-2008 03:40 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
I had a typo in network stanza (had a dash before, ip, subnet and gateway) not needed. Here is the fix buildiso.py

--joe

Joseph Boyer Jr
Enterprise Technology Services
Liquidnet Holdings, Inc.
Joseph.Boyer@liquidnet.com
T +1 646.660.8352
C +1 646.284.8394


-----Original Message-----
From: et-mgmt-tools-bounces@redhat.com [mailto:et-mgmt-tools-bounces@redhat.com] On Behalf Of Joseph Boyer Jr.
Sent: Tuesday, June 24, 2008 9:25 AM
To: Fedora/Linux Management Tools
Subject: RE: [et-mgmt-tools] [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

Hello there...

I have made some updates to the updates that Dave H had made to the action_buildiso.py.

Here is the list of my updates: (P.S. I am new to python so if my coding sucks, please bear with me)

1. reordered the build iso menu so that systems are first.

2. Did not understand why we rely on DHCP when you have a "System". So I have added the networking information to the kernel line for systems, thus eliminating the need for DHCP. (This is what I needed in the boot iso).

3. Update the copy initrd and kernel so that only the initrd and kernel for the systems listed are copied. (did not see any need to have a huge boot iso, if you have many distros, and wanted to keep it as small as possible.)

4. The boot menu will only list systems if --system is given on the cmdline. By default bootiso will build the boot menu for all profiles list in cobbler.

Cheers,
joe

Joseph Boyer Jr
Enterprise Technology Services
Liquidnet Holdings, Inc.
Joseph.Boyer@liquidnet.com
T +1 646.660.8352
C +1 646.284.8394

-----Original Message-----
From: et-mgmt-tools-bounces@redhat.com [mailto:et-mgmt-tools-bounces@redhat.com] On Behalf Of Michael DeHaan
Sent: Friday, June 20, 2008 10:39 PM
To: Fedora/Linux Management Tools
Subject: Re: [et-mgmt-tools] [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

Dave Hatton wrote:
> The attached patch is for the "cobbler buildiso" command 1. It fixes
> the --profile option so that you can now *really* specify which
> profiles you wish to include in the kickstart.iso 2. It adds a
> --systems option to allow you add specific systems to the
> kickstart.iso
>
> What is the process for having this reviewed and if suitable, merged
> into cobbler?
>
> Regards
>
> Daveh

This looks great to me, I'll test and apply early next week.

Thanks!

--Michael


> ----------------------------------------------------------------------
> --
>
> _______________________________________________
> et-mgmt-tools mailing list
> et-mgmt-tools@redhat.com
> https://www.redhat.com/mailman/listinfo/et-mgmt-tools

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Michael DeHaan 06-24-2008 04:27 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Dave Hatton wrote:

The attached patch is for the "cobbler buildiso" command
1. It fixes the --profile option so that you can now *really* specify
which profiles you wish to include in the kickstart.iso
2. It adds a --systems option to allow you add specific systems to the
kickstart.iso


What is the process for having this reviewed and if suitable, merged
into cobbler?


Regards

Daveh
------------------------------------------------------------------------

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools


Applied, thanks!

--Michael

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Michael DeHaan 06-24-2008 04:31 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Joseph Boyer Jr. wrote:

Hello there...

I have made some updates to the updates that Dave H had made to the action_buildiso.py.

Here is the list of my updates: (P.S. I am new to python so if my coding sucks, please bear with me)

1. reordered the build iso menu so that systems are first.

How about second with a seperator between the profiles and the systems,
or otherwise a 2-level menu that lets you pick first "profiles" or
"systems"?

2. Did not understand why we rely on DHCP when you have a "System". So I have added the networking information to the kernel line for systems, thus eliminating the need for DHCP. (This is what I needed in the boot iso).


This sounds good.


3. Update the copy initrd and kernel so that only the initrd and kernel for the systems listed are copied. (did not see any need to have a huge boot iso, if you have many distros, and wanted to keep it as small as possible.)



Also sounds good.

4. The boot menu will only list systems if --system is given on the cmdline. By default bootiso will build the boot menu for all profiles list in cobbler.



Also also good.


If you can resubmit this as a patch I'll review and apply it.


git-format-patch and git-send-email work really well for this.

--Michael

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Dave Hatton 06-24-2008 05:38 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Joseph, Michael

I'm the first to admit my python skills aren't great, so I'm pleased to
see an improvements.
I have made some updates to the updates that Dave H had made to the
action_buildiso.py.


Here is the list of my updates: (P.S. I am new to python so if my
coding sucks, please bear with me)


1. reordered the build iso menu so that systems are first.

How about second with a seperator between the profiles and the
systems, or otherwise a 2-level menu that lets you pick first
"profiles" or "systems"?
I really like seing the profiles on the CD as well as the system. This
allows me to carry out some diagnostics against the profiles if I screw
up the systems entries.
I'd be please to see what the code looked like to have a two level menu
- if only as a selfish learning exercise.



2. Did not understand why we rely on DHCP when you have a "System".
So I have added the networking information to the kernel line for
systems, thus eliminating the need for DHCP. (This is what I needed
in the boot iso).


This sounds good.
I think this is my poor understanding of how this works. I didn't want
to rely on dhcp either - I just couldn't workout how to append an IP
address.
This answers for me a problem I saw today.

Should the broadcast address be added as well? For completeness?


Dave

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Dave Hatton 06-24-2008 05:43 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Sorry, one more thing, to improve my python.

Why do you import item_distro/profile/system? I didn't see them being
used elsewhere, what am I missing?


Dave

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Michael DeHaan 06-24-2008 05:52 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
Dave Hatton wrote:

Joseph, Michael

I'm the first to admit my python skills aren't great, so I'm pleased
to see an improvements.
I have made some updates to the updates that Dave H had made to the
action_buildiso.py.


Here is the list of my updates: (P.S. I am new to python so if my
coding sucks, please bear with me)


1. reordered the build iso menu so that systems are first.

How about second with a seperator between the profiles and the
systems, or otherwise a 2-level menu that lets you pick first
"profiles" or "systems"?
I really like seing the profiles on the CD as well as the system. This
allows me to carry out some diagnostics against the profiles if I
screw up the systems entries.
I'd be please to see what the code looked like to have a two level
menu - if only as a selfish learning exercise.
Yeah, that can get a little bit complicated with syslinux, ideally if we
don't do that I'd like to see the profiles, a seperator, and then the
systems.





2. Did not understand why we rely on DHCP when you have a "System".
So I have added the networking information to the kernel line for
systems, thus eliminating the need for DHCP. (This is what I needed
in the boot iso).


This sounds good.
I think this is my poor understanding of how this works. I didn't want
to rely on dhcp either - I just couldn't workout how to append an IP
address. This answers for me a problem I saw today.


Right. If the system has the ip and other network info defined, we can
add the kernel arguments for that on the end of the append line if that
does not take the length of the append line to more than 255.




Should the broadcast address be added as well? For completeness?


Not required AFAIK.



Dave

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools


_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

"Joseph Boyer Jr." 06-24-2008 07:45 PM

cobbler buildiso add --systems option and fix --profiles selection.
 
I was attempting to do something else and left them in needlessly.

They can be removed.

--joe

Joseph Boyer Jr
Enterprise Technology Services
Liquidnet Holdings, Inc.
Joseph.Boyer@liquidnet.com
T +1 646.660.8352
C +1 646.284.8394


-----Original Message-----
From: et-mgmt-tools-bounces@redhat.com [mailto:et-mgmt-tools-bounces@redhat.com] On Behalf Of Dave Hatton
Sent: Tuesday, June 24, 2008 1:44 PM
To: Fedora/Linux Management Tools
Subject: Re: [et-mgmt-tools] [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

Sorry, one more thing, to improve my python.

Why do you import item_distro/profile/system? I didn't see them being
used elsewhere, what am I missing?

Dave

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools



_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@redhat.com
https://www.redhat.com/mailman/listinfo/et-mgmt-tools


All times are GMT. The time now is 04:11 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.