Remove extraneous notify on /etc/sysconfig/puppet
Since we're not using the puppet agent anymore, if the /etc/sysconfig/puppet
file is changed, there is no need to notify the puppet service. At best, this would be a no-op, and at worst it would start the agent, which we don't want. --- modules/puppet/manifests/init.pp | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/modules/puppet/manifests/init.pp b/modules/puppet/manifests/init.pp index c04f2e1..bd016aa 100644 --- a/modules/puppet/manifests/init.pp +++ b/modules/puppet/manifests/init.pp @@ -31,7 +31,6 @@ class puppet::client { file { "/etc/sysconfig/puppet": source => "puppet:///puppet/puppet.sysconfig", - notify => Service["puppet"], require => Package["puppet"], } file { "/usr/local/bin/run-puppet": -- 1.7.2.1 _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/infrastructure |
Remove extraneous notify on /etc/sysconfig/puppet
On Fri, 14 Sep 2012 02:54:45 +0000
Jon Stanley <jonstanley@gmail.com> wrote: > Since we're not using the puppet agent anymore, if > the /etc/sysconfig/puppet file is changed, there is no need to notify > the puppet service. At best, this would be a no-op, and at worst it > would start the agent, which we don't want. > --- > modules/puppet/manifests/init.pp | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/modules/puppet/manifests/init.pp > b/modules/puppet/manifests/init.pp index c04f2e1..bd016aa 100644 > --- a/modules/puppet/manifests/init.pp > +++ b/modules/puppet/manifests/init.pp > @@ -31,7 +31,6 @@ class puppet::client { > > file { "/etc/sysconfig/puppet": > source => "puppet:///puppet/puppet.sysconfig", > - notify => Service["puppet"], > require => Package["puppet"], > } > file { "/usr/local/bin/run-puppet": Sure, seems a simple and easy fix. +1 kevin _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/infrastructure |
Remove extraneous notify on /etc/sysconfig/puppet
On Thu, Sep 13, 2012 at 08:58:39PM -0600, Kevin Fenzi wrote:
> On Fri, 14 Sep 2012 02:54:45 +0000 > Jon Stanley <jonstanley@gmail.com> wrote: > > > Since we're not using the puppet agent anymore, if > > the /etc/sysconfig/puppet file is changed, there is no need to notify > > the puppet service. At best, this would be a no-op, and at worst it > > would start the agent, which we don't want. > > --- > > modules/puppet/manifests/init.pp | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/modules/puppet/manifests/init.pp > > b/modules/puppet/manifests/init.pp index c04f2e1..bd016aa 100644 > > --- a/modules/puppet/manifests/init.pp > > +++ b/modules/puppet/manifests/init.pp > > @@ -31,7 +31,6 @@ class puppet::client { > > > > file { "/etc/sysconfig/puppet": > > source => "puppet:///puppet/puppet.sysconfig", > > - notify => Service["puppet"], > > require => Package["puppet"], > > } > > file { "/usr/local/bin/run-puppet": > > Sure, seems a simple and easy fix. +1 > +1 Easy to revert if things go south. -Toshio _______________________________________________ infrastructure mailing list infrastructure@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/infrastructure |
| All times are GMT. The time now is 05:07 AM. |
VBulletin, Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.