FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Infrastructure

 
 
LinkBack Thread Tools
 
Old 10-27-2010, 04:42 PM
Luke Macken
 
Default Fix a bug in our masher sanity check

There is a bug in bodhi's new pre-push sanity checker that causes the
mashing lockfile to get wiped out when a push is resumed and the sanity
check fails.

I would like to push this patch out to releng2 and relepel01 only.

--- a/bodhi/masher.py
+++ b/bodhi/masher.py
@@ -641,7 +641,6 @@ class MashTask(Thread):
if self.resume:
if not self.safe_to_resume():
log.error("safe_to_resume failed! -- aborting")
- self._unlock()
masher.done(self)
return
else:

_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 
Old 10-27-2010, 04:50 PM
Ricky Zhou
 
Default Fix a bug in our masher sanity check

On 2010-10-27 12:42:04 PM, Luke Macken wrote:
> There is a bug in bodhi's new pre-push sanity checker that causes the
> mashing lockfile to get wiped out when a push is resumed and the sanity
> check fails.
>
> I would like to push this patch out to releng2 and relepel01 only.
>
> --- a/bodhi/masher.py
> +++ b/bodhi/masher.py
> @@ -641,7 +641,6 @@ class MashTask(Thread):
> if self.resume:
> if not self.safe_to_resume():
> log.error("safe_to_resume failed! -- aborting")
> - self._unlock()
> masher.done(self)
> return
> else:
+1

Thanks,
Ricky
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 
Old 10-27-2010, 04:52 PM
Dennis Gilmore
 
Default Fix a bug in our masher sanity check

On Wednesday, October 27, 2010 11:42:04 am Luke Macken wrote:
> There is a bug in bodhi's new pre-push sanity checker that causes the
> mashing lockfile to get wiped out when a push is resumed and the sanity
> check fails.
>
> I would like to push this patch out to releng2 and relepel01 only.
>
> --- a/bodhi/masher.py
> +++ b/bodhi/masher.py
> @@ -641,7 +641,6 @@ class MashTask(Thread):
> if self.resume:
> if not self.safe_to_resume():
> log.error("safe_to_resume failed! -- aborting")
> - self._unlock()
> masher.done(self)
> return
> else:
>
> _______________________________________________
> infrastructure mailing list
> infrastructure@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/infrastructure
+1

Dennis
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 

Thread Tools




All times are GMT. The time now is 09:35 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org