FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Infrastructure

 
 
LinkBack Thread Tools
 
Old 08-19-2010, 11:57 AM
"Jason L Tibbitts III"
 
Default Fix to /usr/local/bin/setup_git_package on pkgs

This one-character typo seems to be preventing commit mail from being
sent for all newly-created packages. I've fixed a couple already, but:

$ ls /srv/git/rpms/*/hooks/post.receive|wc -l
92

so I've more to fix. Not sure if I need +1s to make those changes, but I do
need +1s to push the following fix through puppet. I'm pretty sure that
this script simply lives in puppet; if there's another more upstream
repository, please let me know and I'll try to get this fixed there
first.

diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package
index ebe3165..4b438b2 100755
--- a/modules/gitolite/files/distgit/setup_git_package
+++ b/modules/gitolite/files/distgit/setup_git_package
@@ -111,7 +111,7 @@ popd >/dev/null
# Put our special update hooks in place
ln -s /usr/share/gitolite/hooks/common/update $GITROOT/$PACKAGE.git/hooks/
ln -s /usr/share/git-core/mail-hooks/gnome-post-receive-email
- $GITROOT/$PACKAGE.git/hooks/post.receive
+ $GITROOT/$PACKAGE.git/hooks/post-receive

- J<
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 
Old 08-19-2010, 01:13 PM
Mike McGrath
 
Default Fix to /usr/local/bin/setup_git_package on pkgs

On Thu, 19 Aug 2010, Jason L Tibbitts III wrote:

> This one-character typo seems to be preventing commit mail from being
> sent for all newly-created packages. I've fixed a couple already, but:
>
> $ ls /srv/git/rpms/*/hooks/post.receive|wc -l
> 92
>
> so I've more to fix. Not sure if I need +1s to make those changes, but I do
> need +1s to push the following fix through puppet. I'm pretty sure that
> this script simply lives in puppet; if there's another more upstream
> repository, please let me know and I'll try to get this fixed there
> first.
>
> diff --git a/modules/gitolite/files/distgit/setup_git_package b/modules/gitolite/files/distgit/setup_git_package
> index ebe3165..4b438b2 100755
> --- a/modules/gitolite/files/distgit/setup_git_package
> +++ b/modules/gitolite/files/distgit/setup_git_package
> @@ -111,7 +111,7 @@ popd >/dev/null
> # Put our special update hooks in place
> ln -s /usr/share/gitolite/hooks/common/update $GITROOT/$PACKAGE.git/hooks/
> ln -s /usr/share/git-core/mail-hooks/gnome-post-receive-email
> - $GITROOT/$PACKAGE.git/hooks/post.receive
> + $GITROOT/$PACKAGE.git/hooks/post-receive
>

+1 from me, have at it.

-Mike
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 
Old 08-19-2010, 01:22 PM
Dennis Gilmore
 
Default Fix to /usr/local/bin/setup_git_package on pkgs

On Thursday, August 19, 2010 08:13:33 am Mike McGrath wrote:
> On Thu, 19 Aug 2010, Jason L Tibbitts III wrote:
> > This one-character typo seems to be preventing commit mail from being
> > sent for all newly-created packages. I've fixed a couple already, but:
> >
> > $ ls /srv/git/rpms/*/hooks/post.receive|wc -l
> > 92
> >
> > so I've more to fix. Not sure if I need +1s to make those changes, but I
> > do need +1s to push the following fix through puppet. I'm pretty sure
> > that this script simply lives in puppet; if there's another more
> > upstream repository, please let me know and I'll try to get this fixed
> > there first.
> >
> > diff --git a/modules/gitolite/files/distgit/setup_git_package
> > b/modules/gitolite/files/distgit/setup_git_package index
> > ebe3165..4b438b2 100755
> > --- a/modules/gitolite/files/distgit/setup_git_package
> > +++ b/modules/gitolite/files/distgit/setup_git_package
> > @@ -111,7 +111,7 @@ popd >/dev/null
> >
> > # Put our special update hooks in place
> > ln -s /usr/share/gitolite/hooks/common/update
> > $GITROOT/$PACKAGE.git/hooks/ ln -s
> > /usr/share/git-core/mail-hooks/gnome-post-receive-email
> >
> > - $GITROOT/$PACKAGE.git/hooks/post.receive
> > + $GITROOT/$PACKAGE.git/hooks/post-receive
>
> +1 from me, have at it.
>
+1 here also
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 
Old 08-19-2010, 02:25 PM
"Jason L Tibbitts III"
 
Default Fix to /usr/local/bin/setup_git_package on pkgs

Thanks; I've pushed the fix, verified that it works, and fixed the 92
other repositories which had this problem.

- J<
_______________________________________________
infrastructure mailing list
infrastructure@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/infrastructure
 

Thread Tools




All times are GMT. The time now is 05:47 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org