FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Infrastructure

 
 
LinkBack Thread Tools
 
Old 01-22-2010, 03:25 PM
Hans de Goede
 
Default Remove BIOSRAID see if ignored again code from addUdevPartitionDevice

Hi,

On 01/22/2010 05:16 PM, David Lehman wrote:

On Thu, 2010-01-21 at 21:32 +0100, Hans de Goede wrote:

Since addUdevPartitionDevice now checks that the disk the partition
lives on has a disklabel format (which the member disks do not have), there
is no reason to call isIgnored again, esp as isIgnored no longer does
any partition -> disk checking.
---
storage/devicetree.py | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/storage/devicetree.py b/storage/devicetree.py
index 106810d..514e37b 100644
--- a/storage/devicetree.py
+++ b/storage/devicetree.py
@@ -1077,14 +1077,6 @@ class DeviceTree(object):
log.error("failure scanning device %s" % disk_name)
return

- # Now that we've the disk, check if this partition should be
- # ignored again. This catches cases when we scan the partition
- # before the disk and we have for example a disk which is part of
- # a BIOS raid set (and thus we should ignore the raw partitions)
- if self.isIgnored(info):
- log.debug("ignoring %s (%s)" % (name, sysfs_path))
- return
-
# Check that the disk has partitions. If it does not, we must have
# reinitialized the disklabel.
#


What about partitions on disks that are ignored by way of ignoredisk?



Same as in my other reply, if the disk is ignored we will never add it to
the tree, and thus never get here.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:29 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org