FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Infrastructure

 
 
LinkBack Thread Tools
 
Old 03-24-2009, 11:34 PM
David Lehman
 
Default Remove unnecessary istruefalse() function.

On Tue, 2009-03-24 at 14:27 -1000, David Cantrell wrote:
> ---
> iw/partition_ui_helpers_gui.py | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)

Woohoo. This function's very existence has always irked me.

>
> diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py
> index fb311df..e6324f6 100644
> --- a/iw/partition_ui_helpers_gui.py
> +++ b/iw/partition_ui_helpers_gui.py
> @@ -35,11 +35,6 @@ from storage.formats import *
> import gettext
> _ = lambda x: gettext.ldgettext("anaconda", x)
>
> -def istruefalse(val):
> - if val is None or not val:
> - return False
> - return True
> -
> class WideCheckList(checklist.CheckList):
> def toggled_item(self, data, row):
>
> @@ -318,7 +313,7 @@ def createPreExistFSOptionSection(origrequest, maintable, row, mountCombo,
>
> formatcb = gtk.CheckButton(label=_("_Format as:"))
> maintable.attach(formatcb, 0, 1, row, row + 1)
> - formatcb.set_active(istruefalse(not origfs.exists))
> + formatcb.set_active(not origfs.exists)
> rc["formatcb"] = formatcb
>
> fstypeCombo = createFSTypeMenu(origfs, fstypechangeCB,
> @@ -336,7 +331,7 @@ def createPreExistFSOptionSection(origrequest, maintable, row, mountCombo,
>
> if origfs.migratable:
> migratecb = gtk.CheckButton(label=_("Mi_grate filesystem to:"))
> - migratecb.set_active(istruefalse(origfs.migrate))
> + migratecb.set_active(origfs.migrate)
>
> migtypes = [origfs.migrationTarget]
>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 11:21 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org