Change request: fasClient
On Tue, 10 Mar 2009, Toshio Kuratomi wrote:
> I'd like to apply the following patch to the fasClient on bastion. I'll
> spin a new fasClient package with it applied but we probably won't
> update fas-clients on all the machines until after the change freeze.
> The patch changes how the email aliases are generated. The server is
> removing accounts that are marked inactive from having individual
> aliases. This change causes fasClient to eliminate those email
> addresses from the group aliases as well.
> Possible impact: We could break break email alias generation
> What it fixes: Currently group email aliases have many undeliverable
> Mitigating factors:
> - Tested this on fas1.stg. A brief look at the alias lists seems to
> be correct (only people who are inactive are left out).
> - This change will only be on bastion so it's easy to back out a
> change by copying fasClient from another machine.
> Can I get two +1's ?
> diff --git a/client/fasClient b/client/fasClient
> index ee83eae..8203e90 100644
> --- a/client/fasClient
> +++ b/client/fasClient
> @@ -500,6 +500,10 @@ class MakeShellAccounts(AccountSystem):
> for membership in self.memberships[name]:
> role_type = membership['role_type']
> person =
> + if person not in sorted_emails:
> + # If the person isn't in sorted_emails, their
> account has
> + # been inactivated. Don't add them to the group
> + continue
> except KeyError:
Fedora-infrastructure-list mailing list