FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Infrastructure

 
 
LinkBack Thread Tools
 
Old 07-27-2008, 08:53 PM
"Xavier Lamien"
 
Default Email aliases and new cvs requests

2008/7/27 Toshio Kuratomi <a.badger@gmail.com>

Hi guys,



Last week Seth implemented email aliases for the people who should be notified of changes to packages. *I used this new functionality to have getnotifylist, which looks up who to notify on cvs commits, stop querying the pkgdb directly (a slow operation with multiple points where it could fail) and instead just construct the alias from the packagename.




This works well except for one case: *When a new package is created, the *alias for the package does not yet exist. *This means that when someone makes the initial branch for a package they get a bounce message because we were unable to send to the non-existent email address.




I think the solution is going to have to be that the pkgdb has to do the branching. *Or, at least, the pkgdb is going to need to know which packages need branching and cvs-int will have to query for those with a cron job and perform the action. *That way the new package can be added to the pkgdb along with a branch request. *The packagedb will record the new package and add the need for cvs branches to a queue. *The packagedb will take the branch request through various stages until it is done.




Here's my idea for stages:



1) Request for new package with new branch is added to the packagedb.*+ email is sent to the related mailling list to notify that.



2) Request is marked approved by an admin

3) Packagedb create the record for the package

4) Packagedb waits for the email alias to be created (currently, the packagedb doesn't know for sure that the alias has been created... we'll just wait an appropriate length of time. *If this proves problematic we can create a URL that records that aliases has been created that is only authorized to certain users.)


5) Packagedb records that the package is ready to be branched.

6) cvs-int has a cron job that queries for packages to branch, branches them, and then records that they have been created.
Sound a nice plan/procedure.
By the way, Why don't make Packagedb able to run cvs-int with related arguments ?

(this will avoid to have cvs-int check when there are no packages to branch)

*




If anyone can think of a better way to solve this, please let me know. I'll start work on this about the middle of next week.




I'm really interesting by this task.


--
Xavier.t Lamien
--
http://fedoraproject.org/wiki/XavierLamien

GPG-Key ID: F3903DEB
Fingerprint: 0F2A 7A17 0F1B 82EE FCBF 1F51 76B7 A28D F390 3DEB


_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-27-2008, 09:10 PM
Toshio Kuratomi
 
Default Email aliases and new cvs requests

Xavier Lamien wrote:


Here's my idea for stages:

1) Request for new package with new branch is added to the packagedb.


+ email is sent to the related mailling list to notify that.


<nod> Right now only cvsadmins can branch packages so we can send them
mail so they can process the queue.




2) Request is marked approved by an admin
3) Packagedb create the record for the package
4) Packagedb waits for the email alias to be created (currently, the
packagedb doesn't know for sure that the alias has been created...
we'll just wait an appropriate length of time. If this proves
problematic we can create a URL that records that aliases has been
created that is only authorized to certain users.)
5) Packagedb records that the package is ready to be branched.
6) cvs-int has a cron job that queries for packages to branch,
branches them, and then records that they have been created.


Sound a nice plan/procedure.
By the way, Why don't make Packagedb able to run cvs-int with related
arguments ?

(this will avoid to have cvs-int check when there are no packages to branch)

Security. It's easier for us to audit cron jobs that are on the local
machine than it is for us to check what commands are being sent from the
packagedb over the network to cvs-int.


-Toshio

_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-27-2008, 09:29 PM
"Xavier Lamien"
 
Default Email aliases and new cvs requests

2008/7/27 Toshio Kuratomi <a.badger@gmail.com>

Xavier Lamien wrote:




* *Here's my idea for stages:



* *1) Request for new package with new branch is added to the packagedb.



*+ email is sent to the related mailling list to notify that.




<nod> *Right now only cvsadmins can branch packages so we can send them mail so they can process the queue.
it's what i'm talking about, send mail to cvsadmin, i thought they had a mailling list for that.









* *2) Request is marked approved by an admin

* *3) Packagedb create the record for the package

* *4) Packagedb waits for the email alias to be created (currently, the

* *packagedb doesn't know for sure that the alias has been created...

* *we'll just wait an appropriate length of time. *If this proves

* *problematic we can create a URL that records that aliases has been

* *created that is only authorized to certain users.)

* *5) Packagedb records that the package is ready to be branched.

* *6) cvs-int has a cron job that queries for packages to branch,

* *branches them, and then records that they have been created.





Sound a nice plan/procedure.

By the way, Why don't make Packagedb able to run cvs-int with related arguments ?

(this will avoid to have cvs-int check when there are no packages to branch)




Security. *It's easier for us to audit cron jobs that are on the local machine than it is for us to check what commands are being sent from the packagedb over the network to cvs-int.

*





-Toshio




_______________________________________________

Fedora-infrastructure-list mailing list

Fedora-infrastructure-list@redhat.com

https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list




--
Xavier.t Lamien
--
http://fedoraproject.org/wiki/XavierLamien
GPG-Key ID: F3903DEB
Fingerprint: 0F2A 7A17 0F1B 82EE FCBF 1F51 76B7 A28D F390 3DEB



_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-28-2008, 01:39 AM
Mike McGrath
 
Default Email aliases and new cvs requests

On Sun, 27 Jul 2008, Toshio Kuratomi wrote:

> Hi guys,
>
> Last week Seth implemented email aliases for the people who should be notified
> of changes to packages. I used this new functionality to have getnotifylist,
> which looks up who to notify on cvs commits, stop querying the pkgdb directly
> (a slow operation with multiple points where it could fail) and instead just
> construct the alias from the packagename.
>
> This works well except for one case: When a new package is created, the
> alias for the package does not yet exist. This means that when someone makes
> the initial branch for a package they get a bounce message because we were
> unable to send to the non-existent email address.
>
> I think the solution is going to have to be that the pkgdb has to do the
> branching. Or, at least, the pkgdb is going to need to know which packages
> need branching and cvs-int will have to query for those with a cron job and
> perform the action. That way the new package can be added to the pkgdb along
> with a branch request. The packagedb will record the new package and add the
> need for cvs branches to a queue. The packagedb will take the branch request
> through various stages until it is done.
>
> Here's my idea for stages:
>
> 1) Request for new package with new branch is added to the packagedb.
> 2) Request is marked approved by an admin
> 3) Packagedb create the record for the package
> 4) Packagedb waits for the email alias to be created (currently, the packagedb
> doesn't know for sure that the alias has been created... we'll just wait an
> appropriate length of time. If this proves problematic we can create a URL
> that records that aliases has been created that is only authorized to certain
> users.)
> 5) Packagedb records that the package is ready to be branched.
> 6) cvs-int has a cron job that queries for packages to branch, branches them,
> and then records that they have been created.
>
> If anyone can think of a better way to solve this, please let me know. I'll
> start work on this about the middle of next week.
>


"Seth implemented email aliases" What was the criteria for each alias?

Is there any way to just use the criteria to initially select who should
be on the other end of the alias and email them directly for package
creation and then use the alias after its been created?

-Mike

_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-28-2008, 01:40 AM
seth vidal
 
Default Email aliases and new cvs requests

On Sun, 2008-07-27 at 20:39 -0500, Mike McGrath wrote:

> "Seth implemented email aliases" What was the criteria for each alias?

toshio setup a path from the pkgdb to pull the notify list + commit
list, iirc from each pkg and that's what I used to generate the alias
list.

It's all checked into fedora infrastructure's git tree.


-sv


_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-28-2008, 04:31 AM
Toshio Kuratomi
 
Default Email aliases and new cvs requests

Mike McGrath wrote:

On Sun, 27 Jul 2008, Toshio Kuratomi wrote:


Hi guys,

Last week Seth implemented email aliases for the people who should be notified
of changes to packages. I used this new functionality to have getnotifylist,
which looks up who to notify on cvs commits, stop querying the pkgdb directly
(a slow operation with multiple points where it could fail) and instead just
construct the alias from the packagename.

This works well except for one case: When a new package is created, the
alias for the package does not yet exist. This means that when someone makes
the initial branch for a package they get a bounce message because we were
unable to send to the non-existent email address.

I think the solution is going to have to be that the pkgdb has to do the
branching. Or, at least, the pkgdb is going to need to know which packages
need branching and cvs-int will have to query for those with a cron job and
perform the action. That way the new package can be added to the pkgdb along
with a branch request. The packagedb will record the new package and add the
need for cvs branches to a queue. The packagedb will take the branch request
through various stages until it is done.

Here's my idea for stages:

1) Request for new package with new branch is added to the packagedb.
2) Request is marked approved by an admin
3) Packagedb create the record for the package
4) Packagedb waits for the email alias to be created (currently, the packagedb
doesn't know for sure that the alias has been created... we'll just wait an
appropriate length of time. If this proves problematic we can create a URL
that records that aliases has been created that is only authorized to certain
users.)
5) Packagedb records that the package is ready to be branched.
6) cvs-int has a cron job that queries for packages to branch, branches them,
and then records that they have been created.

If anyone can think of a better way to solve this, please let me know. I'll
start work on this about the middle of next week.




"Seth implemented email aliases" What was the criteria for each alias?

Is there any way to just use the criteria to initially select who should
be on the other end of the alias and email them directly for package
creation and then use the alias after its been created?

We can fallback to getting this information directly from the packagedb.
But only if we can figure out one of the following::


* If the cvs hook that returns the email address can detect that the
alias does not exist.
* If the cvs hook that sends out email can tell that this is the initial
branching of a package.


I wasn't able to think of a way to do either of these. If you can, then
we could definitely do this as a quick fix.


-Toshio

_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 
Old 07-28-2008, 04:26 PM
Kevin Fenzi
 
Default Email aliases and new cvs requests

On Sun, 27 Jul 2008 13:07:24 -0700
Toshio Kuratomi <a.badger@gmail.com> wrote:

> Hi guys,
>
> Last week Seth implemented email aliases for the people who should be
> notified of changes to packages. I used this new functionality to
> have getnotifylist, which looks up who to notify on cvs commits, stop
> querying the pkgdb directly (a slow operation with multiple points
> where it could fail) and instead just construct the alias from the
> packagename.
>
> This works well except for one case: When a new package is created,
> the alias for the package does not yet exist. This means that when
> someone makes the initial branch for a package they get a bounce
> message because we were unable to send to the non-existent email
> address.
>
> I think the solution is going to have to be that the pkgdb has to do
> the branching. Or, at least, the pkgdb is going to need to know
> which packages need branching and cvs-int will have to query for
> those with a cron job and perform the action. That way the new
> package can be added to the pkgdb along with a branch request. The
> packagedb will record the new package and add the need for cvs
> branches to a queue. The packagedb will take the branch request
> through various stages until it is done.

On advantage to this approach is that it might get us further toward
allowing people to request new package adds and branches directly in
packagedb, only needing cvsadmin approval, instead of the manual
process now with bugzilla cvs requests.

> Here's my idea for stages:
>
> 1) Request for new package with new branch is added to the packagedb.
> 2) Request is marked approved by an admin
> 3) Packagedb create the record for the package
> 4) Packagedb waits for the email alias to be created (currently, the
> packagedb doesn't know for sure that the alias has been created...
> we'll just wait an appropriate length of time. If this proves
> problematic we can create a URL that records that aliases has been
> created that is only authorized to certain users.)
> 5) Packagedb records that the package is ready to be branched.
> 6) cvs-int has a cron job that queries for packages to branch,
> branches them, and then records that they have been created.
>
> If anyone can think of a better way to solve this, please let me
> know. I'll start work on this about the middle of next week.

Well, the information is in several places, it's just a matter of which
one is the easiest/most reliable/least blocking way to get it.

The above sounds ok to me, as long as it also gets us closer to a more
automated way of processing new packages / new branches.

>
> -Toshio
>

kevin
_______________________________________________
Fedora-infrastructure-list mailing list
Fedora-infrastructure-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-infrastructure-list
 

Thread Tools




All times are GMT. The time now is 02:01 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org