FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Directory

 
 
LinkBack Thread Tools
 
Old 06-23-2011, 06:18 AM
Ales Kozumplik
 
Default Keep dracut settings in sets instead of many long strings.

On 06/22/2011 04:30 PM, Chris Lumens wrote:

+ if hasattr(cfg_obj, "dracutSetupArgs"):
+ setup_args = cfg_obj.dracutSetupArgs()
+ self.boot_args.update(setup_args)
+ self.dracut_args.update(setup_args)
+ else:
+ setup_string = cfg_obj.dracutSetupString()
+ self.boot_args.add(setup_string)
+ self.dracut_args.add(setup_string)


Does this mean you're leaving some dracutSetupString methods around?
If so, why not convert them as well. If not, is this just code you had
in for testing?

- Chris



Yes, one, the keyboard because I don't have control over it, it's in
system-config-keybaord. What I was going to do is push this patch, open
a bugzilla against sc-keyboard that the API has changed and once it is
resolved I can remove the branching in bootloader.py. This way nothing
ever gets broken.


Hope that's OK.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 06-24-2011, 07:00 AM
Ales Kozumplik
 
Default Keep dracut settings in sets instead of many long strings.

On 06/23/2011 04:20 PM, Chris Lumens wrote:

Yes, one, the keyboard because I don't have control over it, it's in
system-config-keybaord. What I was going to do is push this patch,
open a bugzilla against sc-keyboard that the API has changed and
once it is resolved I can remove the branching in bootloader.py.
This way nothing ever gets broken.


Makes sense to me. Thanks for the clarification.



NP, pushed, the new sc-keyboard bugzilla is
https://bugzilla.redhat.com/show_bug.cgi?id=716360.


Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 05:02 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org