Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Development (http://www.linux-archive.org/fedora-development/)
-   -   Improve checking if new biosboot partition is needed. (http://www.linux-archive.org/fedora-development/572733-improve-checking-if-new-biosboot-partition-needed.html)

Ales Kozumplik 09-07-2011 06:55 AM

Improve checking if new biosboot partition is needed.
 
Thanks for the review, what you suggested seems to work very well!
Sending new patch.

This is totally eligible for f16-branch.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Ales Kozumplik 09-07-2011 06:55 AM

Improve checking if new biosboot partition is needed.
 
It is wrong to simply skip biosboot whenever stage1_drive is not set (like
during kickstart install).

Resolves: rhbz#734861
---
pyanaconda/storage/partitioning.py | 20 +++++---------------
1 files changed, 5 insertions(+), 15 deletions(-)

diff --git a/pyanaconda/storage/partitioning.py b/pyanaconda/storage/partitioning.py
index 237e55e..82d35f5 100644
--- a/pyanaconda/storage/partitioning.py
+++ b/pyanaconda/storage/partitioning.py
@@ -132,21 +132,11 @@ def _schedulePartitions(storage, disks):
storage.bootLoaderDevice.format.mountpoint = "/boot/efi"
log.debug(storage.bootLoaderDevice)
continue
- elif request.fstype == "biosboot" and storage.anaconda:
- boot_disk = storage.anaconda.bootloader.stage1_drive
- if boot_disk and boot_disk.format.labelType != "gpt":
- # biosboot is only needed for gpt disklabels on non-efi x86
- log.info("skipping bios boot request for msdos disklabel")
- log.debug(request)
- continue
-
- gpt_check = getattr(storage.anaconda.bootloader,
- "_gpt_disk_has_bios_boot",
- None)
- if gpt_check and gpt_check(boot_disk):
- # there's already a bios boot partition on the gpt boot disk
- log.info("skipping bios boot request since boot disk has one")
- continue
+ elif request.fstype == "biosboot" and storage.bootLoaderDevice:
+ log.info("skipping unneeded stage1 biosboot request")
+ log.debug(request)
+ log.debug(storage.bootLoaderDevice)
+ continue

# This is a little unfortunate but let the backend dictate the rootfstype
# so that things like live installs can do the right thing
--
1.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

David Lehman 09-07-2011 09:59 PM

Improve checking if new biosboot partition is needed.
 
On Wed, 2011-09-07 at 08:55 +0200, Ales Kozumplik wrote:
> It is wrong to simply skip biosboot whenever stage1_drive is not set (like
> during kickstart install).

Now that bios boot is a requirement, rather than a suggestion, it should
be this simple.

Ack.

>
> Resolves: rhbz#734861
> ---
> pyanaconda/storage/partitioning.py | 20 +++++---------------
> 1 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/pyanaconda/storage/partitioning.py b/pyanaconda/storage/partitioning.py
> index 237e55e..82d35f5 100644
> --- a/pyanaconda/storage/partitioning.py
> +++ b/pyanaconda/storage/partitioning.py
> @@ -132,21 +132,11 @@ def _schedulePartitions(storage, disks):
> storage.bootLoaderDevice.format.mountpoint = "/boot/efi"
> log.debug(storage.bootLoaderDevice)
> continue
> - elif request.fstype == "biosboot" and storage.anaconda:
> - boot_disk = storage.anaconda.bootloader.stage1_drive
> - if boot_disk and boot_disk.format.labelType != "gpt":
> - # biosboot is only needed for gpt disklabels on non-efi x86
> - log.info("skipping bios boot request for msdos disklabel")
> - log.debug(request)
> - continue
> -
> - gpt_check = getattr(storage.anaconda.bootloader,
> - "_gpt_disk_has_bios_boot",
> - None)
> - if gpt_check and gpt_check(boot_disk):
> - # there's already a bios boot partition on the gpt boot disk
> - log.info("skipping bios boot request since boot disk has one")
> - continue
> + elif request.fstype == "biosboot" and storage.bootLoaderDevice:
> + log.info("skipping unneeded stage1 biosboot request")
> + log.debug(request)
> + log.debug(storage.bootLoaderDevice)
> + continue
>
> # This is a little unfortunate but let the backend dictate the rootfstype
> # so that things like live installs can do the right thing


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 12:20 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.