FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 07-07-2011, 11:36 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

2011/7/7 Nathanael D. Noblet <nathanael@gnat.ca>:
> On 07/07/2011 12:38 PM, Steve Clark wrote:
>> Hmmm... wonder if this is somehow related to glibc changing memcpy that
>> caused problem in flash and squashfs?
>
> I thought that happened in F14. so I would expect it to have been
> discovered already if that was the case?

Perhaps we should wait for the Andreas opinion. There was a lot fixes
between 2.13.90-9 and 2.14-4. I can do binary search between versions
if needed

>
> --
> Nathanael d. Noblet
> t 403.875.4613
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 04:21 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

Hi,

2011/7/8 Andreas Schwab <schwab@redhat.com>:
> Use valgrind.

I attach valgrind output.

==1312== 1 errors in context 1 of 116:
==1312== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
==1312== at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
==1312== by 0x401835: ??? (in /sbin/mount.ecryptfs)
==1312== by 0x5E3039C: (below main) (in /lib64/libc-2.14.so)

Could this be related to
- Fix static linking with checking x86/x86-64 memcpy (BZ#12653)
or is it an eCryptfs problem?

>
> Andreas.
>
> --
> Andreas Schwab, schwab@redhat.com
> GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 *5EC7 45C6 250E 6F00 984E
> "And now for something completely different."
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 04:21 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

Hi,

2011/7/8 Andreas Schwab <schwab@redhat.com>:
> Use valgrind.

I attach valgrind output.

==1312== 1 errors in context 1 of 116:
==1312== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
==1312== at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
==1312== by 0x401835: ??? (in /sbin/mount.ecryptfs)
==1312== by 0x5E3039C: (below main) (in /lib64/libc-2.14.so)

Could this be related to
- Fix static linking with checking x86/x86-64 memcpy (BZ#12653)
or is it an eCryptfs problem?

>
> Andreas.
>
> --
> Andreas Schwab, schwab@redhat.com
> GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 *5EC7 45C6 250E 6F00 984E
> "And now for something completely different."
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 04:32 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

W dniu 8 lipca 2011 18:21 użytkownik Michał Piotrowski
<mkkp4x4@gmail.com> napisał:
> Hi,
>
> 2011/7/8 Andreas Schwab <schwab@redhat.com>:
>> Use valgrind.
>
> I attach valgrind output.
>
> ==1312== 1 errors in context 1 of 116:
> ==1312== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
> ==1312== * *at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
> ==1312== * *by 0x401835: ??? (in /sbin/mount.ecryptfs)
> ==1312== * *by 0x5E3039C: (below main) (in /lib64/libc-2.14.so)

I installed ecryptfs-utils-debuginfo package and now it's more readable

==1815== 1 errors in context 1 of 116:
==1815== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
==1815== at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
==1815== by 0x401835: main (string3.h:52)


>
> Could this be related to
> *- Fix static linking with checking x86/x86-64 memcpy (BZ#12653)
> or is it an eCryptfs problem?
>
>>
>> Andreas.
>>
>> --
>> Andreas Schwab, schwab@redhat.com
>> GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 *5EC7 45C6 250E 6F00 984E
>> "And now for something completely different."
>> --
>> devel mailing list
>> devel@lists.fedoraproject.org
>> https://admin.fedoraproject.org/mailman/listinfo/devel
>>
>
>
>
> --
> Best regards,
> Michal
>
> http://eventhorizon.pl/
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 04:32 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

W dniu 8 lipca 2011 18:21 użytkownik Michał Piotrowski
<mkkp4x4@gmail.com> napisał:
> Hi,
>
> 2011/7/8 Andreas Schwab <schwab@redhat.com>:
>> Use valgrind.
>
> I attach valgrind output.
>
> ==1312== 1 errors in context 1 of 116:
> ==1312== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
> ==1312== * *at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
> ==1312== * *by 0x401835: ??? (in /sbin/mount.ecryptfs)
> ==1312== * *by 0x5E3039C: (below main) (in /lib64/libc-2.14.so)

I installed ecryptfs-utils-debuginfo package and now it's more readable

==1815== 1 errors in context 1 of 116:
==1815== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
==1815== at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
==1815== by 0x401835: main (string3.h:52)


>
> Could this be related to
> *- Fix static linking with checking x86/x86-64 memcpy (BZ#12653)
> or is it an eCryptfs problem?
>
>>
>> Andreas.
>>
>> --
>> Andreas Schwab, schwab@redhat.com
>> GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84 *5EC7 45C6 250E 6F00 984E
>> "And now for something completely different."
>> --
>> devel mailing list
>> devel@lists.fedoraproject.org
>> https://admin.fedoraproject.org/mailman/listinfo/devel
>>
>
>
>
> --
> Best regards,
> Michal
>
> http://eventhorizon.pl/
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 05:14 PM
Jakub Jelinek
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

On Fri, Jul 08, 2011 at 01:12:04PM -0400, Steve Clark wrote:
> So it does appear to be related to the memcpy change in libc.

So eCryptfs is buggy, just fix it.
The compatibility stuff that has been added to glibc to workaround
buggy old programs was just for programs linked against old glibc.
If you compile it again and you want it still working, fix it.
It isn't that hard.

Jakub
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 05:19 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

2011/7/8 Jakub Jelinek <jakub@redhat.com>:
> On Fri, Jul 08, 2011 at 01:12:04PM -0400, Steve Clark wrote:
>> So it does appear to be related to the memcpy change in libc.
>
> So eCryptfs is buggy, just fix it.
> The compatibility stuff that has been added to glibc to workaround
> buggy old programs was just for programs linked against old glibc.
> If you compile it again and you want it still working, fix it.
> It isn't that hard.

I'll try tomorrow, I hope it is obvious bug.

>
> * * * *Jakub
> --
> devel mailing list
> devel@lists.fedoraproject.org
> https://admin.fedoraproject.org/mailman/listinfo/devel
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-08-2011, 05:34 PM
Jakub Jelinek
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

On Fri, Jul 08, 2011 at 01:27:45PM -0400, Steve Clark wrote:
> memove should be used if areas overlap that are being copied.

If they overlap or may overlap.

Jakub
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-11-2011, 03:09 PM
Michal Hlavinka
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

>>>> W dniu 8 lipca 2011 18:21 użytkownik Michał Piotrowski
>>>>
>>>> <mkkp4x4@gmail.com> napisał:
>>>>> Hi,
>>>>>
>>>>> 2011/7/8 Andreas Schwab<schwab@redhat.com>:
>>>>>> Use valgrind.
>>>>>
>>>>> I attach valgrind output.
>>>>>
>>>>> ==1312== 1 errors in context 1 of 116:
>>>>> ==1312== Source and destination overlap in memcpy(0xaef1590, 0xaef1593,
>>>>> 76) ==1312== at 0x4C283B6: memcpy@@GLIBC_2.14
>>>>> (mc_replace_strmem.c:653) ==1312== by 0x401835: ??? (in
>>>>> /sbin/mount.ecryptfs)
>>>>> ==1312== by 0x5E3039C: (below main) (in /lib64/libc-2.14.so)
>>>>
>>>> I installed ecryptfs-utils-debuginfo package and now it's more readable
>>>>
>>>> ==1815== 1 errors in context 1 of 116:
>>>> ==1815== Source and destination overlap in memcpy(0xaef1590, 0xaef1593, 76)
>>>> ==1815== at 0x4C283B6: memcpy@@GLIBC_2.14 (mc_replace_strmem.c:653)
>>>> ==1815== by 0x401835: main (string3.h:52)
>>>>
>>>>> Could this be related to
>>>>> - Fix static linking with checking x86/x86-64 memcpy (BZ#12653)
>>>>> or is it an eCryptfs problem?
>> W dniu 8 lipca 2011 20:08 użytkownik Michal Hlavinka
>> <mhlavink@redhat.com> napisał:
>>> Hi,
>>>
>>> please check if this package changes anything for you:
>>>
>>> http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3187528/
>>
>> unfortunately there is no difference
>
> I'm attaching valgrind output. I checked your patch and it removes
> correctly all uses of memcpy so it seems that memcpy only covered the
> root of the problem.

ok, complain about memcpy in ecryptfs-utils is gone. I've checked all of
them and I think I've fixed those which needed it. I was not able to
reproduce original problem nor valgrind complaint, so please test if
following package produces memcpy complain in valgrind output or not:

http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3190860/

Anyway, I don't think there is any problem in ecryptfs-utils, because
it's just mount helper. It's not running when files are being
encrypted/decrypted and you said it works fine when you use ecryptfs
directly (without samba). We've fixed memcpy bug in ecryptfs which is
definitely a good think, but problem is elsewhere.

If you want, you can test following build of samba which has all
occurrences of memcpy replaced by memmove. I don't dare to guess if it
changes anything, but give it a try if you want:

http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3190918/

Could you describe your environment in more details so we can try to
reproduce it? For example what ecryptfs options you use (including fstab
line if you have any), samba configuration etc...

Michal

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 07-11-2011, 03:40 PM
Michał Piotrowski
 
Default glibc 2.14-4 eats my data ( F15 ext3, eCryptfs + samba = data corruption ( F15 "Error mounting eCryptfs: Input/output error" on different disks))

Hi,

W dniu 11 lipca 2011 17:09 użytkownik Michal Hlavinka
<mhlavink@redhat.com> napisał:
> ok, complain about memcpy in ecryptfs-utils is gone. I've checked all of
> them and I think I've fixed those which needed it. I was not able to
> reproduce original problem nor valgrind complaint, so please test if
> following package produces memcpy complain in valgrind output or not:
>
> http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3190860/

Your mtab handling patch fixed both issues - mount warning and data
corruption Huge thanks!

>
> Anyway, I don't think there is any problem in ecryptfs-utils, because it's
> just mount helper. It's not running when files are being encrypted/decrypted
> and you said it works fine when you use ecryptfs directly (without samba).
> We've fixed memcpy bug in ecryptfs which is definitely a good think, but
> problem is elsewhere.
>
> If you want, you can test following build of samba which has all occurrences
> of memcpy replaced by memmove. I don't dare to guess if it changes anything,
> but give it a try if you want:
>
> http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3190918/
>
> Could you describe your environment in more details so we can try to
> reproduce it? For example what ecryptfs options you use (including fstab
> line if you have any), samba configuration etc...

I do not think that it had any significance - it seems to me that
these options are pretty standard
mount -t ecryptfs /home/$SHARE/ /home/$SHARE/ -o
key=passphrase,ecryptfs_cipher=aes,ecryptfs_key_by tes=16,ecryptfs_passthrough=n,ecryptfs_fnek_sig=so me_value

It's a little strange that you could not reproduce that mount warning.

>
> Michal
>
>



--
Best regards,
Michal

http://eventhorizon.pl/
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 

Thread Tools




All times are GMT. The time now is 03:48 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org