FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 04-06-2011, 06:11 PM
Jeffrey Ness
 
Default Fedora SPEC Review Tool

Hello everyone,

As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.

With that said I have a simple Python tool (still in early beta stages) which does just that.

Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:

https://github.com/jness/spec_checks

This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:

http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

Thanks for your time
Jeffrey-

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-06-2011, 06:18 PM
Richard Shaw
 
Default Fedora SPEC Review Tool

On Wed, Apr 6, 2011 at 1:11 PM, Jeffrey Ness <jeffrey.ness@rackspace.com> wrote:
> Hello everyone,
>
> As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.
>
> With that said I have a simple Python tool (still in early beta stages) which does just that.
>
> Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:
>
> *https://github.com/jness/spec_checks
>
> This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:
>
> *http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

I'll test it out on mine tonight when I get home from work!

Richard
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-07-2011, 06:00 AM
Garrett Holmstrom
 
Default Fedora SPEC Review Tool

On 4/6/2011 11:11, Jeffrey Ness wrote:
> As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.
>
> With that said I have a simple Python tool (still in early beta stages) which does just that.
>
> Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:
>
> https://github.com/jness/spec_checks
>
> This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:
>
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

I was expecting some sort of automated spec file / RPM checker, but it
turned out to essentially be a checklist program. I guess I should have
read the readme first.

On that note, one thing that could improve it would be making it capable
of automatically providing relevant information to the reviewer.
Printing source file checksums, for instance, would be a small, but
relatively easy thing of this nature to do.

The review guidelines include the packaging guidelines by reference.
Your program does not. Though the packaging guidelines tend to leave
more up to reviewers' discretion, they might still be worth including,
at least in part.

If it helps, several people posted wiki pages with the lists of things
that they look for when reviewing packages. AFAIK mine is up to date
and fairly exhaustive, if you're interested in a starting point:
https://fedoraproject.org/wiki/Gholms/review_template

I hope at least some of that feedback helps. Anything that makes
reviewing easier is a good thing, so thanks for sharing your work!
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-07-2011, 08:38 AM
Petr Sabata
 
Default Fedora SPEC Review Tool

On Wed, Apr 06, 2011 at 01:11:26PM -0500, Jeffrey Ness wrote:
> Hello everyone,
>
> As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.
>
> With that said I have a simple Python tool (still in early beta stages) which does just that.
>
> Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:
>
> https://github.com/jness/spec_checks
>
> This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:
>
> http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
>
> Thanks for your time
> Jeffrey-

I've been putting something similar together [1], to simplify the process.
It doesn't do much at the moment (a checklist with mock/koji rebuild support)
and is quite ugly

I like your config files idea. I currently just use CSV templates with severity
and items...

[1] https://github.com/contyk/fedret

--
Petr 'contyk' Sabata, Red Hat
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-07-2011, 08:44 AM
Pierre-Yves Chibon
 
Default Fedora SPEC Review Tool

On Thu, 2011-04-07 at 10:38 +0200, Petr Sabata wrote:
> I've been putting something similar together [1], to simplify the
> process.
> It doesn't do much at the moment (a checklist with mock/koji rebuild
> support)
> and is quite ugly
>
> I like your config files idea. I currently just use CSV templates with
> severity
> and items...
>
> [1] https://github.com/contyk/fedret

I have made a quick script for this purpose.
It supports quite well R packages and does some basic things for other
type of packages:
http://project.pingoured.fr/reviewHelper/file/26f59aa687ef/reviewHelper.py

Pierre
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-07-2011, 12:03 PM
"tim.lauridsen@gmail.com"
 
Default Fedora SPEC Review Tool

On Wed, Apr 6, 2011 at 8:11 PM, Jeffrey Ness <jeffrey.ness@rackspace.com> wrote:

Hello everyone,



As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.



With that said I have a simple Python tool (still in early beta stages) which does just that.



Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:



*https://github.com/jness/spec_checks



This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:



*http://fedoraproject.org/wiki/Packaging/ReviewGuidelines



Thanks for your time

Jeffrey-



--

devel mailing list

devel@lists.fedoraproject.org

https://admin.fedoraproject.org/mailman/listinfo/devel



I am working on a tool too, there automates much of the dirty work when reviewing a package

Like:
- Downloading SRPM & SPEC from bugzilla report
- Download upstream source

- check md5sums
- do a total review report will both manual & automated checks, ready to complete and paste into the bugzilla report.

https://github.com/timlau/FedoraReview


checkout and cd to the src/ dir.

./review.py -b <bugzilla report number>

it will download the spec & srpm from the bugzilla report and build them in mock and run a number of test and generate

a report there will be opened in gedit along with the spec file, so the stuff no automated can be reviewed manually.

You will need to have mock installed and be member of the mock group for the build to work.


./review.py --help

Will show you the other options of the tools.

./review.py -b <bugzilla report number> -u <bugzilla user> -p <bugzilla password> --assign

Will assign the review to <bugzilla user> and set the review flags in the bugzilla report.


It is still under heavy development, but can be very useful.

Tim

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 04-13-2011, 02:58 PM
Toshio Kuratomi
 
Default Fedora SPEC Review Tool

On Wed, Apr 06, 2011 at 11:00:08PM -0700, Garrett Holmstrom wrote:
> On 4/6/2011 11:11, Jeffrey Ness wrote:
> > As I'm new to the community and RPM Package Review (and development), I figured a tool to assist with reviews would be a nice time saver.
> >
> > With that said I have a simple Python tool (still in early beta stages) which does just that.
> >
> > Keeping with the concept of sharing, I wanted to hand this tool out to the community and get any feedback from y'all:
> >
> > https://github.com/jness/spec_checks
> >
> > This tool uses the "Package Review Guidelines" written by Tom 'spot' Callaway:
> >
> > http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
>
> I was expecting some sort of automated spec file / RPM checker, but it
> turned out to essentially be a checklist program. I guess I should have
> read the readme first.
>
> On that note, one thing that could improve it would be making it capable
> of automatically providing relevant information to the reviewer.
> Printing source file checksums, for instance, would be a small, but
> relatively easy thing of this nature to do.
>
> The review guidelines include the packaging guidelines by reference.
> Your program does not. Though the packaging guidelines tend to leave
> more up to reviewers' discretion, they might still be worth including,
> at least in part.
>
> If it helps, several people posted wiki pages with the lists of things
> that they look for when reviewing packages. AFAIK mine is up to date
> and fairly exhaustive, if you're interested in a starting point:
> https://fedoraproject.org/wiki/Gholms/review_template
>
> I hope at least some of that feedback helps. Anything that makes
> reviewing easier is a good thing, so thanks for sharing your work!
>
Ah -- if this is a checklist app, you could also look at:

http://svn.berlios.de/viewvc/qa-assistant/trunk/

I wrote that for doing reviews of fedora.us packages as my first serious
pygtk program. It has a generic way of defining the checklist via an xml
file and I had started to include ways to load code to automate tests about
the time that I stopped working on it.

-Toshio
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 

Thread Tools




All times are GMT. The time now is 04:06 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org