FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 06-03-2010, 03:47 PM
Iain Arnell
 
Default Package maintainers -- want test results by mail?

On Thu, Jun 3, 2010 at 5:09 PM, seth vidal <skvidal@fedoraproject.org> wrote:
> On Thu, 2010-06-03 at 10:57 -0400, Matt McCutchen wrote:
>> On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote:
>> > When the shebang is to allow running some sort of unittest I generally just
>> > leave it alone (the end user won't want to run it and upstream does want to
>> > run the code when they're testing).
>>
>> There is still no reason to have a shebang on a non-executable file.
>> The file must have started out executable in order for upstream to run
>> it. *The proper solution would be to remove the shebang in the same
>> place the executability gets removed.
>
> another option is to not flag things which impact NOT AT ALL
> functionality

Indeed. Only warn about non-executable shebang scripts in $PATH (or
non-executable anything in $PATH); otherwise it's just a comment that
me be useful elsewhere for test purposes.

--
Iain.
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-03-2010, 06:30 PM
Adam Williamson
 
Default Package maintainers -- want test results by mail?

On Thu, 2010-06-03 at 11:09 -0400, seth vidal wrote:
> On Thu, 2010-06-03 at 10:57 -0400, Matt McCutchen wrote:
> > On Wed, 2010-06-02 at 14:46 -0400, Toshio Kuratomi wrote:
> > > When the shebang is to allow running some sort of unittest I generally just
> > > leave it alone (the end user won't want to run it and upstream does want to
> > > run the code when they're testing).
> >
> > There is still no reason to have a shebang on a non-executable file.
> > The file must have started out executable in order for upstream to run
> > it. The proper solution would be to remove the shebang in the same
> > place the executability gets removed.
>
> another option is to not flag things which impact NOT AT ALL
> functionality

Well, the test's just a test. It's not magic. It doesn't *know* whether
they affect functionality. The test is obviously designed to catch the
case where the packager screws up and doesn't mark a script that
actually _needs_ to be executable as executable. Just because in this
case it happens that these scripts don't need to be executable, doesn't
mean that's always the case.
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Fedora Talk: adamwill AT fedoraproject DOT org
http://www.happyassassin.net

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-05-2010, 08:54 AM
Ville Skyttä
 
Default Package maintainers -- want test results by mail?

On Thursday 03 June 2010, Adam Williamson wrote:

> One thing I'd dearly like to see suppressed in most cases is the spell
> checking. Most package descriptions need to use jargon which spell
> checkers just don't recognize.

Some of this particular flavor of noise is now reduced in upstream post-0.97
svn.
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-06-2010, 11:37 AM
Mat Booth
 
Default Package maintainers -- want test results by mail?

On 3 June 2010 07:44, Ville Skyttä <ville.skytta@iki.fi> wrote:
> On Thursday 03 June 2010, Adam Williamson wrote:
>> On Wed, 2010-06-02 at 23:05 +0100, Mat Booth wrote:
>> > It doesn't even know all English words. In one review I did recently
>> > rpmlint flagged the word "decryption" as a spelling error. Which I
>> > didn't believe, so I looked it up. It's a valid noun form of the verb
>> > "decrypt" in the English dictionary I have here...
>>
>> OED agrees, 'decryption' is listed as a valid form under its entry for
>> decrypt.
>
> rpmlint uses python-enchant, and enchant in Fedora is configured to use
> myspell for English by default [0]. *myspell means that enchant actually uses
> hunspell in Fedora under the hood, and thus the place to fix dictionary
> omissions/bugs for English for all software that ends up using hunspell
> (directly or via enchant), not only rpmlint, is currently the hunspell-en
> package.
>
> $ echo decryption | hunspell -d en_US
> Hunspell 1.2.8
> & decryption 4 0: encryption, deception, description, decoration
>
> [0] /usr/share/enchant/enchant.ordering


Thanks for the hint.

https://bugzilla.redhat.com/show_bug.cgi?id=600860


--
Mat Booth
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-06-2010, 02:27 PM
Richard Fearn
 
Default Package maintainers -- want test results by mail?

Hi,

Thanks for this.

Just a couple of points:

The package name is converted to lower case. Should it be doing that?
For example, the jFormatString opt-in files are in
/srv/people/site/packages/j/jformatstring.

Also autoqa-optin doesn't validate the package name: I missed it out
at one point and ended up creating files in
/srv/people/site/packages/d/devel. I've cleared them up now :-)

Regards,

Rich
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-07-2010, 03:02 AM
Toshio Kuratomi
 
Default Package maintainers -- want test results by mail?

On Sun, Jun 06, 2010 at 03:27:33PM +0100, Richard Fearn wrote:
> Hi,
>
> Thanks for this.
>
> Just a couple of points:
>
> The package name is converted to lower case. Should it be doing that?
> For example, the jFormatString opt-in files are in
> /srv/people/site/packages/j/jformatstring.
>
As long as all the code paths are lowercasing before comparing it should be
fine for Fedora -- we have a policy not to have two packages with names that
are only differentiated by case.

-Toshio
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-08-2010, 11:12 PM
Kevin Kofler
 
Default Package maintainers -- want test results by mail?

Toshio Kuratomi wrote:
> As long as all the code paths are lowercasing before comparing it should
> be fine for Fedora -- we have a policy not to have two packages with names
> that are only differentiated by case.

Are we sure this is being followed everywhere?

Kevin Kofler

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 06-09-2010, 03:41 AM
Seth Vidal
 
Default Package maintainers -- want test results by mail?

On Wed, 9 Jun 2010, Kevin Kofler wrote:

> Toshio Kuratomi wrote:
>> As long as all the code paths are lowercasing before comparing it should
>> be fine for Fedora -- we have a policy not to have two packages with names
>> that are only differentiated by case.
>
> Are we sure this is being followed everywhere?
>

If it is not some folks are going to be in for a rude awakening for
certain list and search operations in yum.

-sv



--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 

Thread Tools




All times are GMT. The time now is 05:14 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org