FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 03-16-2010, 05:08 PM
Christoph Wickert
 
Default rpms/remmina/F-13 import.log,1.1,1.2 remmina.spec,1.4,1.5

Am Dienstag, den 16.03.2010, 17:36 +0000 schrieb Damien Durand:
> Author: splinux
>
> Update of /cvs/pkgs/rpms/remmina/F-13
> In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv21694/F-13
>
> Modified Files:
> import.log remmina.spec
> Log Message:

Damian,
please give a log message and please DO NOT use cvs-import.sh for
package updates, just commit the changes. With cvs-import you have no
option to change the changes.

> -Requires: rdesktop, xorg-x11-server-Xephyr
> +Requires: rdesktop, xorg-x11-server-Xephyr
>
> -Provides: grdc = %{version}
> -Obsoletes: grdc < 0.6.1
> +Provides: grdc = %{version}
> +Obsoletes: grdc < 0.6.1

Although this minor, you broke the formatting and made the spec harder
to read.

> %description
> -Remmina is a remote desktop client written in GTK+, aiming to be useful for
> -system administrators and travelers, who need to work with lots of remote
> -computers in front of either large monitors or tiny netbooks.
> +Remmina is a remote desktop client written in GTK+, aiming to be useful
> +for system administrators and travellers, who need to work with lots
> +of remote computers in front of either large monitors or tiny netbooks.
>
> -Remmina supports multiple network protocols in an integrated and consistent
> -user interface. Currently RDP, VNC, XDMCP and SSH are supported.
> +Remmina supports multiple network protocols in an integrated and consistant
> + user interface. Currently RDP, VNC, XDMCP and SSH are supported.

You brought all the typos back that I fixed yesterday! Please use
rpmlint to check the spelling.

> %changelog
> +* Tue Mar 16 2010 Damien Durand <splinux@fedoraproject.org> - 0.7.4-3
> +- Fix changelog
> +
> * Tue Mar 16 2010 Christoph Wickert <cwickert@fedoraproject.org> - 0.7.4-2
> - Add patch to fix DSO issue
>
> @@ -87,7 +90,7 @@ gtk-update-icon-cache %{_datadir}/icons/
> - Upstream release
> - Add rdesktop, xorg-x11-server-Xephyr in Requires
> - Add grdc in Provides/Obsoletes
> -- Add --enable-vnc=dl in %%configure
> +- Add enable-vnc=dl in configure

As you see the changelog was already fixed. There was no need fix
anything, I already fixed everything yesterday but you overwrote my
changes again.

Your updates are completely useless. Please DO NOT push them on any
branch.

Regards,
Christoph

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 03-16-2010, 05:09 PM
Christoph Wickert
 
Default rpms/remmina/F-13 import.log,1.1,1.2 remmina.spec,1.4,1.5

Am Dienstag, den 16.03.2010, 19:08 +0100 schrieb Christoph Wickert:
> With cvs-import you have no option to change the changes.

s/change/check

Christoph

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 03-17-2010, 10:47 AM
"Nicolas Mailhot"
 
Default rpms/remmina/F-13 import.log,1.1,1.2 remmina.spec,1.4,1.5

Le Mar 16 mars 2010 19:09, Christoph Wickert a écrit :
>
> Am Dienstag, den 16.03.2010, 19:08 +0100 schrieb Christoph Wickert:
>> With cvs-import you have no option to change the changes.
>
> s/change/check

Of course you have it shows a diff with previous files and asks confirmation

--
Nicolas Mailhot


--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 
Old 03-17-2010, 10:58 AM
Christoph Wickert
 
Default rpms/remmina/F-13 import.log,1.1,1.2 remmina.spec,1.4,1.5

Am Mittwoch, den 17.03.2010, 12:47 +0100 schrieb Nicolas Mailhot:
>
> Le Mar 16 mars 2010 19:09, Christoph Wickert a écrit :
> >
> > Am Dienstag, den 16.03.2010, 19:08 +0100 schrieb Christoph Wickert:
> >> With cvs-import you have no option to change the changes.
> >
> > s/change/check
>
> Of course you have it shows a diff with previous files and asks confirmation

Thanks for that info, I didn't know that as I don't use cvs-import for
updates.

If it really shows a diff, I wonder why people repeatedly revert changes
with cvs-import.sh.

Regards,
Christoph

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
 

Thread Tools




All times are GMT. The time now is 09:27 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org