On 03/04/2010 12:07 PM, Richard Hughes wrote:
> On 3 March 2010 21:45, Tom "spot" Callaway<tcallawa@redhat.com> wrote:
>> Here are the list of changes to the Fedora Packaging Guidelines:
>
> I've done some updates, and now rpmlint reports:
>
> argyllcms.spec: W: no-cleaning-of-buildroot %install
> argyllcms.spec: W: no-buildroot-tag
>
> Does rpmlint need an update?

Also, should rpmdev-newspec templates get an update to not include
buildroot tag?

--
Kalev
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

On 03/04/2010 03:37 PM, Richard Hughes wrote:
> On 3 March 2010 21:45, Tom "spot" Callaway <tcallawa@redhat.com> wrote:
>
>> Here are the list of changes to the Fedora Packaging Guidelines:
>>
> I've done some updates, and now rpmlint reports:
>
> argyllcms.spec: W: no-cleaning-of-buildroot %install
> argyllcms.spec: W: no-buildroot-tag
>
> Does rpmlint need an update?
>

It was flagged as an error for a long time and I filed a bug report and
it was downgraded to warning and I believe it is still misleading and
only really applies to EPEL and not to Fedora anymore and the template
and http://fedoraproject.org/wiki/Packaging/ReviewGuidelines should be
updated as well

Rahul
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

On 03/04/2010 05:21 AM, Kalev Lember wrote:
> On 03/04/2010 12:07 PM, Richard Hughes wrote:
>> On 3 March 2010 21:45, Tom "spot" Callaway<tcallawa@redhat.com> wrote:
>>> Here are the list of changes to the Fedora Packaging Guidelines:
>>
>> I've done some updates, and now rpmlint reports:
>>
>> argyllcms.spec: W: no-cleaning-of-buildroot %install
>> argyllcms.spec: W: no-buildroot-tag
>>
>> Does rpmlint need an update?
>
> Also, should rpmdev-newspec templates get an update to not include
> buildroot tag?

Yes, and yes, IMHO.

~spot
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

On Thu, 4 Mar 2010, Tom spot Callaway wrote:

> On 03/04/2010 05:21 AM, Kalev Lember wrote:
>> On 03/04/2010 12:07 PM, Richard Hughes wrote:
>>> On 3 March 2010 21:45, Tom "spot" Callaway<tcallawa@redhat.com> wrote:
>>>> Here are the list of changes to the Fedora Packaging Guidelines:
>>>
>>> I've done some updates, and now rpmlint reports:
>>>
>>> argyllcms.spec: W: no-cleaning-of-buildroot %install
>>> argyllcms.spec: W: no-buildroot-tag
>>>
>>> Does rpmlint need an update?
>>
>> Also, should rpmdev-newspec templates get an update to not include
>> buildroot tag?
>
> Yes, and yes, IMHO.

Speaking of these... what about getting rid of %clean too? Automatic
%clean is only added in F >= 13 currently, but the patch is small and
could be easily backported to F11-12 too (I mean, a 7-line patch couldn't
possibly break anything right? Har-de-har...)

- Panu -
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

On 03/04/2010 09:35 AM, Panu Matilainen wrote:
> Speaking of these... what about getting rid of %clean too? Automatic
> %clean is only added in F >= 13 currently, but the patch is small and
> could be easily backported to F11-12 too (I mean, a 7-line patch couldn't
> possibly break anything right? Har-de-har...)

You should really talk to the Fedora RPM package maintainer about adding
that. *cough*

~spot

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel