FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 01-22-2010, 02:20 PM
Chris Lumens
 
Default Update exclusiveDisks when handling mdraid BIOSRAID in isIgnored

> diff --git a/storage/devicetree.py b/storage/devicetree.py
> index ffc1c90..4fb4e6c 100644
> --- a/storage/devicetree.py
> +++ b/storage/devicetree.py
> @@ -898,8 +898,9 @@ class DeviceTree(object):
> if udev_device_get_md_container(info) and
> udev_device_get_md_name(info):
> md_name = udev_device_get_md_name(info)
> - for disk in self.exclusiveDisks:
> - if re.match("isw_[a-z]*_%s" % md_name, disk):
> + for i in range(0, len(self.exclusiveDisks)):
> + if re.match("isw_[a-z]*_%s" % md_name, self.exclusiveDisks[i]):
> + self.exclusiveDisks[i] = name
> return False
>
> if udev_device_is_disk(info) and

The one thing that worries me here is that we're adding another
iteration over exclusiveDisks, which could potentially be very large.
However it's probably not worth worrying about until we test this stuff
out on a machine with tons of disks.

This looks fine, and reminds me that cleardisks_gui.py needs to become
more clever about what it does and does not display, instead of just
trusting exclusiveDisks to contain all the right information.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org