Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Fedora Development (http://www.linux-archive.org/fedora-development/)
-   -   autofs - patches in %doc? (http://www.linux-archive.org/fedora-development/201374-autofs-patches-doc.html)

Michael Schwendt 11-28-2008 09:20 AM

autofs - patches in %doc?
 
$ du -h /usr/share/doc/autofs-5.0.3/*.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.10-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.11-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.12-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.13-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.14-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.15-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.16-v5-update.patch
28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.17-v5-update.patch
28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.18-v5-update.patch
20K /usr/share/doc/autofs-5.0.3/autofs4-2.6.19-v5-update.patch
16K /usr/share/doc/autofs-5.0.3/autofs4-2.6.20-v5-update.patch
8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.21-v5-update.patch
8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.22-v5-update.patch
4.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.23-v5-update.patch
76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.9-v5-update.patch
4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12a-flock.patch
4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12q-flock.patch

[$ du -h autofs-5.0.4/patches
2.0M autofs-5.0.4/patches
]

So, we've got ~48K of %changelog details in the autofs.spec, but the
question why the %doc line explicitly includes patches/* is not answered.
That clutters up the docdir unnecessarily.

Who can tell why this is done?

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Jeff Moyer 12-01-2008 05:03 PM

autofs - patches in %doc?
 
Michael Schwendt <mschwendt@gmail.com> writes:

> $ du -h /usr/share/doc/autofs-5.0.3/*.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.10-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.11-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.12-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.13-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.14-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.15-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.16-v5-update.patch
> 28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.17-v5-update.patch
> 28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.18-v5-update.patch
> 20K /usr/share/doc/autofs-5.0.3/autofs4-2.6.19-v5-update.patch
> 16K /usr/share/doc/autofs-5.0.3/autofs4-2.6.20-v5-update.patch
> 8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.21-v5-update.patch
> 8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.22-v5-update.patch
> 4.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.23-v5-update.patch
> 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.9-v5-update.patch
> 4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12a-flock.patch
> 4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12q-flock.patch
>
> [$ du -h autofs-5.0.4/patches
> 2.0M autofs-5.0.4/patches
> ]
>
> So, we've got ~48K of %changelog details in the autofs.spec, but the
> question why the %doc line explicitly includes patches/* is not answered.
> That clutters up the docdir unnecessarily.
>
> Who can tell why this is done?

I presume Ian can.

Cheers,
Jeff

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Ian Kent 12-02-2008 01:18 AM

autofs - patches in %doc?
 
On Mon, 2008-12-01 at 13:03 -0500, Jeff Moyer wrote:
> Michael Schwendt <mschwendt@gmail.com> writes:
>
> > $ du -h /usr/share/doc/autofs-5.0.3/*.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.10-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.11-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.12-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.13-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.14-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.15-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.16-v5-update.patch
> > 28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.17-v5-update.patch
> > 28K /usr/share/doc/autofs-5.0.3/autofs4-2.6.18-v5-update.patch
> > 20K /usr/share/doc/autofs-5.0.3/autofs4-2.6.19-v5-update.patch
> > 16K /usr/share/doc/autofs-5.0.3/autofs4-2.6.20-v5-update.patch
> > 8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.21-v5-update.patch
> > 8.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.22-v5-update.patch
> > 4.0K /usr/share/doc/autofs-5.0.3/autofs4-2.6.23-v5-update.patch
> > 76K /usr/share/doc/autofs-5.0.3/autofs4-2.6.9-v5-update.patch
> > 4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12a-flock.patch
> > 4.0K /usr/share/doc/autofs-5.0.3/util-linux-2.12q-flock.patch
> >
> > [$ du -h autofs-5.0.4/patches
> > 2.0M autofs-5.0.4/patches
> > ]
> >
> > So, we've got ~48K of %changelog details in the autofs.spec, but the
> > question why the %doc line explicitly includes patches/* is not answered.
> > That clutters up the docdir unnecessarily.
> >
> > Who can tell why this is done?

Oh .. oops.

Once upon a time there were only a couple patches and they were small
and they weren't included in the kernel so it was sensible to place them
in the docs directory in case they were needed.

But nowadays they aren't needed so much, especially the patches for the
older kernels, as the updates make there way into Fedora kernels in
reasonable time.

Log a bug and we'll fix this.

Ian


--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list


All times are GMT. The time now is 03:57 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.