Hi all,

I am starting a project called review-o-matic which will do reviews of
Fedora packages based on discussions at
https://www.redhat.com/archives/fedora-packaging/2008-October/msg00023.html.
We know of having couple of scripts being used by different people to
do so, but this tool's target is to consolidate those efforts and add
a number of additional features as well. The basic idea is to remove
the grunt work from package reviews.

Wishlist:

Run rpmlint
Build the package in mock
verify the md5sum of upstream source matches what is in the srpm
<your ideas here>

Workflow:

The instance you submit a new review request, this tool will
automatically do the following:

* Download SRPM and SPEC as soon as new package review get submitted.
* Do a review , post it on bugzilla and also keep track to show on own
web front end
* People can upload their SRPS to the system to get a review done by the system.

Kushal
--
http://fedoraproject.org
http://kushaldas.in

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Kushal Das wrote:

Hi all,

I am starting a project called review-o-matic which will do reviews of
Fedora packages based on discussions at
https://www.redhat.com/archives/fedora-packaging/2008-October/msg00023.html.
We know of having couple of scripts being used by different people to
do so, but this tool's target is to consolidate those efforts and add
a number of additional features as well. The basic idea is to remove
the grunt work from package reviews.

Wishlist:

Run rpmlint
Build the package in mock
verify the md5sum of upstream source matches what is in the srpm

What about making directly the build on koji ?
It enables to test all version and all arch before the review.

I actually think that we should couple a bit more Koji and the BZ such as
- I submit a review
- I provide a build number from koji (me if I am approved or review-o-matic)
- Koji does not delete this build until the review is done
- When the package is approved (is so), koji remove the build.

Would that be an interesting feature ?

Best regards,

Pierre

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

On Thu, 2008-10-16 at 15:36 +0200, Pierre-Yves wrote:
> Kushal Das wrote:
> > Hi all,
> >
> > I am starting a project called review-o-matic which will do reviews of
> > Fedora packages based on discussions at
> > https://www.redhat.com/archives/fedora-packaging/2008-October/msg00023.html.
> > We know of having couple of scripts being used by different people to
> > do so, but this tool's target is to consolidate those efforts and add
> > a number of additional features as well. The basic idea is to remove
> > the grunt work from package reviews.
> >
> > Wishlist:
> >
> > Run rpmlint
> > Build the package in mock
> > verify the md5sum of upstream source matches what is in the srpm
> What about making directly the build on koji ?
> It enables to test all version and all arch before the review.
>
> I actually think that we should couple a bit more Koji and the BZ such as
> - I submit a review
> - I provide a build number from koji (me if I am approved or review-o-matic)
> - Koji does not delete this build until the review is done
> - When the package is approved (is so), koji remove the build.
>
> Would that be an interesting feature ?

Would a koji scratch-build work for this purpose?

--
Paul W. Frields
gpg fingerprint: 3DA6 A0AC 6D58 FEC4 0233 5906 ACDB C937 BD11 3717
http://paul.frields.org/ - - http://pfrields.fedorapeople.org/
irc.freenode.net: stickster @ #fedora-docs, #fedora-devel, #fredlug
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Pierre-Yves wrote:

Paul W. Frields wrote:

On Thu, 2008-10-16 at 15:36 +0200, Pierre-Yves wrote:

What about making directly the build on koji ?
It enables to test all version and all arch before the review.

I actually think that we should couple a bit more Koji and the BZ
such as

- I submit a review
- I provide a build number from koji (me if I am approved or
review-o-matic)

- Koji does not delete this build until the review is done
- When the package is approved (is so), koji remove the build.

Would that be an interesting feature ?


Would a koji scratch-build work for this purpose?

That my though, the only constraints here is for new packager.
Correct me if I am wrong but I think only people from the packager group
can do a scratch-build.
No.. anyone with a FAS account can do a scratch build. I think it would
be good to encourage scratch builds before reviews are done.


-- bk


--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Paul W. Frields wrote:

On Thu, 2008-10-16 at 15:36 +0200, Pierre-Yves wrote:

What about making directly the build on koji ?
It enables to test all version and all arch before the review.

I actually think that we should couple a bit more Koji and the BZ such as
- I submit a review
- I provide a build number from koji (me if I am approved or review-o-matic)
- Koji does not delete this build until the review is done
- When the package is approved (is so), koji remove the build.

Would that be an interesting feature ?


Would a koji scratch-build work for this purpose?

That my though, the only constraints here is for new packager.
Correct me if I am wrong but I think only people from the packager group
can do a scratch-build.


Best regards,

Pierre

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

>> What about making directly the build on koji ?
>> It enables to test all version and all arch before the review.
>>
>> I actually think that we should couple a bit more Koji and the BZ such as

> Would a koji scratch-build work for this purpose?

Currently Koji's scratch builds get removed after a fixed period of
time. If we can somehow manage to keep the build till the review is
finished, it would be perfect.

Often during the course of a review, the submitter and reviewer work
on fixing some issues which might need fresh builds. To save Koji's
disk space we can override an older build with a newer one.

What do you think?

Cheers,
Debarshi

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Debarshi Ray wrote:

What about making directly the build on koji ?
It enables to test all version and all arch before the review.

I actually think that we should couple a bit more Koji and the BZ such as



Would a koji scratch-build work for this purpose?


Currently Koji's scratch builds get removed after a fixed period of
time. If we can somehow manage to keep the build till the review is
finished, it would be perfect.

Often during the course of a review, the submitter and reviewer work
on fixing some issues which might need fresh builds. To save Koji's
disk space we can override an older build with a newer one.

What do you think?


You perfectly got my point.

Should I make a Feature Request on the bugzilla ?

Best regards,

Pierre

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

On Thu, 2008-10-16 at 15:46 +0200, Pierre-Yves wrote:
> Paul W. Frields wrote:
> > On Thu, 2008-10-16 at 15:36 +0200, Pierre-Yves wrote:
> >> What about making directly the build on koji ?
> >> It enables to test all version and all arch before the review.
> >>
> >> I actually think that we should couple a bit more Koji and the BZ such as
> >> - I submit a review
> >> - I provide a build number from koji (me if I am approved or review-o-matic)
> >> - Koji does not delete this build until the review is done
> >> - When the package is approved (is so), koji remove the build.
> >>
> >> Would that be an interesting feature ?
> >
> > Would a koji scratch-build work for this purpose?
> That my though, the only constraints here is for new packager.
> Correct me if I am wrong but I think only people from the packager group
> can do a scratch-build.

Presumably if we automate this to the point where it uses a bot to
"pre-review" then we could just put the bot in the group.

--
Ignacio Vazquez-Abrams <ivazqueznet@gmail.com>

PLEASE don't CC me; I'm already subscribed
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

On Thu, 2008-10-16 at 19:19 +0530, Debarshi Ray wrote:
> >> What about making directly the build on koji ?
> >> It enables to test all version and all arch before the review.
> >>
> >> I actually think that we should couple a bit more Koji and the BZ such as
>
> > Would a koji scratch-build work for this purpose?
>
> Currently Koji's scratch builds get removed after a fixed period of
> time. If we can somehow manage to keep the build till the review is
> finished, it would be perfect.

Presumably the scripts could check to see if the builds succeeded and
annotate the review appropriately.

--
Ignacio Vazquez-Abrams <ivazqueznet@gmail.com>

PLEASE don't CC me; I'm already subscribed
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list

Just for the record, Rakesh Pandit pointed us to this Python script on
the Fedora India mailing list:
http://gauret.free.fr/fichiers/rpms/fedora/fedora-qa

What we found was that rpmlint has incorporated some of the checks
implemented separately by the above script, and that it was generally
old and did not incorporate all the recent modifications made to our
guidelines.

If we can work on correcting these deficiencies, can it serve as the
backend of the "pre-review bot" or "review-o-matic" ?

Cheers,
Debarshi

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list