FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 08-29-2008, 11:41 AM
James Bowes
 
Default rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64

On Thu, Aug 28, 2008 at 07:04:43PM -0400, Todd Zullinger wrote:
> I almost hate to ask, but why are we differing from upstream here by
> setting gitexecdir=%{_bindir}? Moving the git-* commands out of the
> path has been on the agenda for git-1.6.0 for a long time. If distros
> like Fedora and others just set gitexecdir like this we've effectively
> negated upstream's intent to present less binaries in the users path.
>
> For those folks that want to continue using the git-* form, the simple
> solution is to add $(git --exec-path) to PATH.
>
> If we want to not break anyone's scripts by default in the update to
> git-1.6.0, we could add that to the PATH in the package rather than
> keep all the git binaries in %{_bindir}. At least that way, those who
> do not want or need all the extra commands there could just remove it
> from their PATH. (Personally, I'd prefer to not even do that and
> install git as closely to upstream as possible.)

I did this because someone else complained about not using gitexecdir first.
But it makes sense to me, since I have not yet done any due diligence to
see what might break when we do move the git-* commands. So no worries,
we will move the commands, but there's no real rush, is there?

-James
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 08-29-2008, 11:47 AM
Josh Boyer
 
Default rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64

On Fri, Aug 29, 2008 at 07:41:08AM -0400, James Bowes wrote:
>On Thu, Aug 28, 2008 at 07:04:43PM -0400, Todd Zullinger wrote:
>> I almost hate to ask, but why are we differing from upstream here by
>> setting gitexecdir=%{_bindir}? Moving the git-* commands out of the
>> path has been on the agenda for git-1.6.0 for a long time. If distros
>> like Fedora and others just set gitexecdir like this we've effectively
>> negated upstream's intent to present less binaries in the users path.
>>
>> For those folks that want to continue using the git-* form, the simple
>> solution is to add $(git --exec-path) to PATH.
>>
>> If we want to not break anyone's scripts by default in the update to
>> git-1.6.0, we could add that to the PATH in the package rather than
>> keep all the git binaries in %{_bindir}. At least that way, those who
>> do not want or need all the extra commands there could just remove it
>> from their PATH. (Personally, I'd prefer to not even do that and
>> install git as closely to upstream as possible.)
>
>I did this because someone else complained about not using gitexecdir first.
>But it makes sense to me, since I have not yet done any due diligence to
>see what might break when we do move the git-* commands. So no worries,
>we will move the commands, but there's no real rush, is there?

Though an F-9 update will not. You just don't yank out commands like that
from a stable release. (And that is what the original complaint was about,
even though it wasn't like that in Fedora.)

josh

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 08-29-2008, 04:23 PM
Josh Boyer
 
Default rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64

On Fri, Aug 29, 2008 at 11:56:55AM -0400, Todd Zullinger wrote:
>> Though an F-9 update will not. You just don't yank out commands
>> like that from a stable release.
>
>Yeah, I fully agree. And that said, is there a compelling reason to
>push git-1.6.0 as an F9 update¹ (aside from "we always have to have the
>very latest release" mantra that many users chant)? F9 should be fine
>with git-1.5.6.x, shouldn't it?

It fixes a security bug, but I think a later release of 1.5.6.x does as
well.

josh

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 08-30-2008, 07:06 AM
Andreas Ericsson
 
Default rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64

Josh Boyer wrote:

On Fri, Aug 29, 2008 at 11:56:55AM -0400, Todd Zullinger wrote:

Though an F-9 update will not. You just don't yank out commands
like that from a stable release.

Yeah, I fully agree. And that said, is there a compelling reason to
push git-1.6.0 as an F9 update� (aside from "we always have to have the
very latest release" mantra that many users chant)? F9 should be fine
with git-1.5.6.x, shouldn't it?


It fixes a security bug, but I think a later release of 1.5.6.x does as
well.



Also, git 1.6 moves all the git-<commands> away from /usr/bin. Judging by
the reactions on the git mailing list from people who install from sources,
you'd be better off shipping 1.6.0 with F10 and stick with 1.5.6.x for F9.

--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 08-30-2008, 01:07 PM
Josh Boyer
 
Default rpms/git/devel .cvsignore, 1.63, 1.64 git.spec, 1.70, 1.71 sources, 1.63, 1.64

On Sat, Aug 30, 2008 at 09:06:28AM +0200, Andreas Ericsson wrote:
> Josh Boyer wrote:
>> On Fri, Aug 29, 2008 at 11:56:55AM -0400, Todd Zullinger wrote:
>>>> Though an F-9 update will not. You just don't yank out commands
>>>> like that from a stable release.
>>> Yeah, I fully agree. And that said, is there a compelling reason to
>>> push git-1.6.0 as an F9 update� (aside from "we always have to have the
>>> very latest release" mantra that many users chant)? F9 should be fine
>>> with git-1.5.6.x, shouldn't it?
>>
>> It fixes a security bug, but I think a later release of 1.5.6.x does as
>> well.
>>
>
> Also, git 1.6 moves all the git-<commands> away from /usr/bin. Judging by
> the reactions on the git mailing list from people who install from sources,
> you'd be better off shipping 1.6.0 with F10 and stick with 1.5.6.x for F9.

Um. Perhaps you should read the whole email thread you're replying to
before you reply.

josh

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 

Thread Tools




All times are GMT. The time now is 02:44 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org