FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Development

 
 
LinkBack Thread Tools
 
Old 06-25-2008, 02:42 AM
Eric Sandeen
 
Default Custom DSDT Table in the fedora kernel at boot time

Joshua C. wrote:

> ok guys,
>
> then it is up to whether the patch is "clean" enough to go in the
> mainstream kernel.

Yes, that is basically it.

> I think the decision about a custom dsdt table in the kernel has
> been taken long time ago. and the answer is the option that enables
> the kernel to load a custom table. what the patch does is that it
> pospones the loading of the table until the initram is loaded. so
> the custom dsdt can be read from it.
>
> If someone thinks the patch isn't good enough, then he should
> suggest his own patch. but for now this is the only one available.
> Either in the kernel or in the initram, in both cases we can load
> our custom dsdt table. the only difference is that the kernel
> recompilation takes about 30 mins (compared to the 2mins for the
> repacking of the initram). I really don't see any objections to
> simplifying this process.
>
> Please, prove me wrong, but I'm just trying to make it easier to
> run linux on my machine. And the patch simlifies this process.

There's really nothing to prove. Fedora isn't in the business of
maintaining patches not in upstream for long periods of time; it hurts
Fedora because of the maintenance load, and it hurts the kernel in
general because the problem isn't being fixed at the source.

So if there's something you need, find a way to help it get upstream.

Probably the best thing you could do would be to email the patch author,
test the patch he plans to submit next time, and when he does, chime in
with the fact that it works well for you. If people have concerns about
ways it might break, see if you can break it in those ways, etc.

I do understand that the functionality provided by the patch makes your
life easier, but these things have to be done in maintainable ways. It
looks like there's a decent chance the patch will be upstream soon, then
we can all be happy.

-Eric

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-25-2008, 08:28 AM
"Joshua C."
 
Default Custom DSDT Table in the fedora kernel at boot time

On Wed, 25 Jun 2008 04:38:03 +0200 Arjan van de Ven
<arjan@infradead.org> wrote:
>
>as someone who works for Intel near the ACPI dev team (yes one
>cube
>away)... lets put it this way:
>If Windows works with the BIOS, and Linux does not, that is a bug
>that
>needs fixing in Linux. The ACPI team takes this and other bugs
>VERY
>seriously; especially if the impact is severe functional
>impairment and
>Windows does work. I would strongly suggest you file a bug in
>bugzilla.kernel.org attaching your dsdt....
>

Thank you for the advice. I filed a bugreport at
bugzilla.kernel.org and this is how we got the bad dsdt table
(vista and xp never expirienced this problem). the report is here:
http://bugzilla.kernel.org/show_bug.cgi?id=10237
As you can see all works well now. But I have to manually insert
the dsdt in the kernel and recompile it for every kernel.

I think the acpi-dev-team did a great job finding and repairing
this bug but there is nothing else they could do. Inclusion of my
dsdt in the mainstream kernel is a bad idea because:
1. in the future the table could be repaired but i don't believe
this.
2. en extra code will be needed to chack for the machine version
and the bios and apply the patch only on my machine type.
3. the kernel shouldn't be a place to put working dsdt tables

Now I'm waiting for another solution to save the 30 min (+ config
time) for recompilation.

--
Enter for Your Chance to WIN*
The TotalBeauty.com Summer Spa Sweepstakes!
http://tagline.hushmail.com/fc/JKFkuIjyZ57oJlsSjM42VuVf5IcP2M677NnHCXBFw04CPdXtDu uMV9/

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-25-2008, 08:41 AM
"Joshua C."
 
Default Custom DSDT Table in the fedora kernel at boot time

On Wed, 25 Jun 2008 04:42:24 +0200 Eric Sandeen
<sandeen@redhat.com> wrote:
>Joshua C. wrote:
>
>> ok guys,
>>
>> then it is up to whether the patch is "clean" enough to go in
>the
>> mainstream kernel.
>
>Yes, that is basically it.
>
>> I think the decision about a custom dsdt table in the kernel has
>
>> been taken long time ago. and the answer is the option that
>enables
>> the kernel to load a custom table. what the patch does is that
>it
>> pospones the loading of the table until the initram is loaded.
>so
>> the custom dsdt can be read from it.
>>
>> If someone thinks the patch isn't good enough, then he should
>> suggest his own patch. but for now this is the only one
>available.
>> Either in the kernel or in the initram, in both cases we can
>load
>> our custom dsdt table. the only difference is that the kernel
>> recompilation takes about 30 mins (compared to the 2mins for the
>
>> repacking of the initram). I really don't see any objections to
>> simplifying this process.
>>
>> Please, prove me wrong, but I'm just trying to make it easier to
>
>> run linux on my machine. And the patch simlifies this process.
>
>There's really nothing to prove. Fedora isn't in the business of
>maintaining patches not in upstream for long periods of time; it
>hurts
>Fedora because of the maintenance load, and it hurts the kernel in
>general because the problem isn't being fixed at the source.
>
>So if there's something you need, find a way to help it get
>upstream.
>
>Probably the best thing you could do would be to email the patch
>author,
>test the patch he plans to submit next time, and when he does,
>chime in
>with the fact that it works well for you. If people have concerns
>about
>ways it might break, see if you can break it in those ways, etc.
>
>I do understand that the functionality provided by the patch makes
>your
>life easier, but these things have to be done in maintainable
>ways. It
>looks like there's a decent chance the patch will be upstream
>soon, then
>we can all be happy.
>
>-Eric
>
>--
>fedora-devel-list mailing list
>fedora-devel-list@redhat.com
>https://www.redhat.com/mailman/listinfo/fedora-devel-list

I tried it (v.0.9) and it worked for me without any issues.

--
Smart Girls Secret Weapon
Read Unbiased Beauty Product Reviews, Get Helpful Tips, Tricks and Sam
http://tagline.hushmail.com/fc/JKFkuIjyaUNYxOtRufju68yr6F5O4Rtu6kypgcoGTywfjNAEWR Cqiv/

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-25-2008, 10:58 AM
Alan Cox
 
Default Custom DSDT Table in the fedora kernel at boot time

> Email the acpi-dev-team my custom dsdt so that they can include it
> in the mainline kernel . Since this is the "missing" code that
> breaks my machine, it should be send as a patch for inclussion. And

You do not have the rights or the permissions from the manufacturer to
distribute or generally make available copies of the DSDT (whether counted
as firmware or not) beyond limited 'fair use' rights in some part of the
world.

That is one big problem with this patch - Red Hat couldn't ship the modified
DSDTs without permission of each vendor or more likely whichever company
they paid to do the work.


--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-25-2008, 12:27 PM
"Joshua C."
 
Default Custom DSDT Table in the fedora kernel at boot time

On Wed, 25 Jun 2008 12:58:48 +0200 Alan Cox <alan@redhat.com> wrote:
>> Email the acpi-dev-team my custom dsdt so that they can include
>it
>> in the mainline kernel . Since this is the "missing" code that

>
>> breaks my machine, it should be send as a patch for inclussion.
>And
>
>You do not have the rights or the permissions from the
>manufacturer to
>distribute or generally make available copies of the DSDT (whether

>counted
>as firmware or not) beyond limited 'fair use' rights in some part
>of the
>world.
>
>That is one big problem with this patch - Red Hat couldn't ship
>the modified

>DSDTs without permission of each vendor or more likely whichever
>company
>they paid to do the work.

This with my dsdt in the maistream kernel (as missing code) was
just a joke. I think the kernel shouldn't collect fixes for broken

dsdt tables but just provide a way to insert a custom one at boot
time. I think it is poor judgemnt to incorporate anyones dsdt (or
other system specific code like bioses) in the mainstream kernel.

Just in case if this could have happended: at boot the kernel

should look throught a register with broken dsdt tables and apply
the "correct" one. and with new bios - should we incorporate our
new dsdt? Should the kernel check (on the millions of pcs it runs
on) for my/anyones dsdt? This is insane!
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-25-2008, 12:50 PM
"Dominik 'Rathann' Mierzejewski"
 
Default Custom DSDT Table in the fedora kernel at boot time

On Wednesday, 25 June 2008 at 14:27, Joshua C. wrote:
[...]
> This with my dsdt in the maistream kernel (as missing code) was
> just a joke. I think the kernel shouldn't collect fixes for broken
> dsdt tables but just provide a way to insert a custom one at boot
> time. I think it is poor judgemnt to incorporate anyones dsdt (or
> other system specific code like bioses) in the mainstream kernel.
>
> Just in case if this could have happended: at boot the kernel
> should look throught a register with broken dsdt tables and apply
> the "correct" one. and with new bios - should we incorporate our
> new dsdt? Should the kernel check (on the millions of pcs it runs
> on) for my/anyones dsdt? This is insane!

Nobody is suggesting anything of the sort. The fix (or probably
a workaround) should be done in the kernel acpi code, because if
Windows works, then so should Linux. We don't want users to mess
with their DSDT tables, however broken they may be.

Regards,
R.

--
Fedora http://fedoraproject.org/wiki/User:Rathann
Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 06-26-2008, 11:01 AM
"Joshua C."
 
Default Custom DSDT Table in the fedora kernel at boot time

I reopened my bug at http://bugzilla.kernel.org/show_bug.cgi?id=10237 . Maybe the acpi code should be corrected to circumvent the broken dsdt code. if windows works, why shouldn't linux do it either?



2008/6/25 Dominik 'Rathann' Mierzejewski <dominik@greysector.net>:

On Wednesday, 25 June 2008 at 14:27, Joshua C. wrote:

[...]

> This with my dsdt in the maistream kernel (as missing code) was

> just a joke. I think the kernel shouldn't collect fixes for broken

> dsdt tables but just provide a way to insert a custom one at boot

> time. I think it is poor judgemnt to incorporate anyones dsdt (or

> other system specific code like bioses) in the mainstream kernel.

>

> Just in case if this could have happended: at boot the kernel

> should look throught a register with broken dsdt tables and apply

> the "correct" one. and with new bios - should we incorporate our

> new dsdt? Should the kernel check (on the millions of pcs it runs

> on) for my/anyones dsdt? This is insane!



Nobody is suggesting anything of the sort. The fix (or probably

a workaround) should be done in the kernel acpi code, because if

Windows works, then so should Linux. We don't want users to mess

with their DSDT tables, however broken they may be.



Regards,

R.



--

Fedora http://fedoraproject.org/wiki/User:Rathann

Livna http://rpm.livna.org | MPlayer http://mplayerhq.hu

"Faith manages."

* * * *-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"



--

fedora-devel-list mailing list

fedora-devel-list@redhat.com

https://www.redhat.com/mailman/listinfo/fedora-devel-list



--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 

Thread Tools




All times are GMT. The time now is 09:45 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org