FAQ Search Today's Posts Mark Forums Read

» Linux Archive
Home
New Posts
Search
FAQ



 
 
LinkBack Thread Tools
 
Old 12-09-2007, 12:56 AM
"Paulo Cavalcanti"
 
Default mock 0.8.9

On Dec 7, 2007 5:58 AM, Paulo Cavalcanti <promac@gmail.com> wrote:



On Dec 7, 2007 5:04 AM, Michael E Brown <Michael_E_Brown@dell.com> wrote:


On Wed, Dec 05, 2007 at 07:56:11PM -0200, Paulo Cavalcanti wrote:
> On Dec 5, 2007 7:45 PM, Ville Skyttä <ville.skytta@iki.fi> wrote:
>
> > On Wednesday 05 December 2007, Michael E Brown wrote:

> > > On Tue, Dec 04, 2007 at 04:59:07PM -0500, Todd Zullinger wrote:
> > > > Okay, here's another set of patches to implement --with{,out} options.
> > > > I used git-format-patch this time, and probably did it awkwardly. *But

> > > > hopefully not too badly. *Just in case (and for non-git users), I'll
> > > > also attach a single diff that should apply cleanly to mock-0.8.14.
> > > >
> > > > Comments and improvements welcome.

> > >
> > > This looks great to me. I've committed this to the repo.
> >
> > Thanks, guys! *When there's a mock release out with these changes
> > (assuming

> > they work ), I think mock has finally caught up with essential features

> > in
> > mach and I'm ready to start using mock.
> >
> > <https://www.redhat.com/mailman/listinfo/fedora-devel-list
>
> >
>
> The only issue *I have so far is during init:
>
>
> mock -r fedora-7-i386 init
>
> INFO: mock.py version 0.8.14 starting...

> State Changed: init plugins
> State Changed: start
> State Changed: lock buildroot
> State Changed: clean
> State Changed: init
> State Changed: lock buildroot
> INFO: enabled yum cache

> State Changed: cleaning yum metadata
> INFO: enabled root cache
> State Changed: running yum
> ERROR: Command failed. See logs for output.
> *# mount -n --bind /home/mock/cache/fedora-7-i386/yum_cache/

> /home/mock/fedora-7-i386/root/var/cache/yum
>
> *But if the chroot is already initialized by a previous mock version, them
> everything goes fine.
>
> I have an updated mock rpm if anyone else is willing to try it.


Mock 0.8.15 is in updates-stable now and has a fix for this problem.

Thanks!

I installed* mock 0.8.15 yesterday and I did not see any problem yet.

This version seems to be very good.


Hi,

The --without option is not working.

I think that

*** options.rpmmacros.append("_with_%s 0" % option)


should be replaced for

*** options.rpmmacros.append("_without_%s 1" % option)

I am appending a patch to fix it

Thanks.

--
Paulo Roma Cavalcanti
LCG - UFRJ
diff -Naur mock-0.8.15/py/mock.py mock-0.8.15-new/py/mock.py
--- mock-0.8.15/py/mock.py 2007-12-06 03:09:01.000000000 -0200
+++ mock-0.8.15-new/py/mock.py 2007-12-08 22:45:46.000000000 -0200
@@ -234,7 +234,7 @@
options.rpmmacros.append("_with_%s 1" % option)

for option in options.rpmwithout:
- options.rpmmacros.append("_with_%s 0" % option)
+ options.rpmmacros.append("_without_%s 1" % option)

for macro in options.rpmmacros:
try:
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 12-09-2007, 05:13 AM
Todd Zullinger
 
Default mock 0.8.9

Paulo Cavalcanti wrote:
> The --without option is not working.
>
> I think that
>
> options.rpmmacros.append("_with_%s 0" % option)
>
> should be replaced for
>
> options.rpmmacros.append("_without_%s 1" % option)

What does the specfile look like? I may have done something wrong
with the options. I read the macros and rpmpopt-4.4.2.2 files in
/usr/lib/rpm to determine what they set when with or without was used
and it seemed to me that when --without foo was passed, rpm defined
_with_foo 0. Is that not how it works? (Mock's not actually passing
the --with/--without options to rpmbuild. It is writing the _with_foo
in ~/.rpmmacros of the chroot, in case that matters.)

--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
It's not denial. I'm just very selective about what I accept as
reality.
-- Calvin ("Calvin and Hobbes")

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 12-09-2007, 05:34 AM
Michael E Brown
 
Default mock 0.8.9

On Sun, Dec 09, 2007 at 12:13:33AM -0500, Todd Zullinger wrote:
> Paulo Cavalcanti wrote:
> > The --without option is not working.
> >
> > I think that
> >
> > options.rpmmacros.append("_with_%s 0" % option)
> >
> > should be replaced for
> >
> > options.rpmmacros.append("_without_%s 1" % option)
>
> What does the specfile look like? I may have done something wrong
> with the options. I read the macros and rpmpopt-4.4.2.2 files in
> /usr/lib/rpm to determine what they set when with or without was used
> and it seemed to me that when --without foo was passed, rpm defined
> _with_foo 0. Is that not how it works? (Mock's not actually passing
> the --with/--without options to rpmbuild. It is writing the _with_foo
> in ~/.rpmmacros of the chroot, in case that matters.)

Paulo appears to be correct. I will queue up this patch for the next
release.

/usr/share/doc/rpm-4.4.2.2/conditionalbuilds
==================
The new options are implemented using popt to add aliases to the
existing rpm
options --define to specify macros from the command line. The magic
necessary
to add the new options is (from the file /usr/lib/rpm/rpmpopt*)
verbatim
rpmb alias --with --define "_with_!#:+ --with-!#:+"
rpmb alias --without --define "_without_!#:+
--without-!#:+"
endverbatim
==================

--
Michael




> --
> fedora-devel-list mailing list
> fedora-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-devel-list

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 12-09-2007, 05:53 AM
Todd Zullinger
 
Default mock 0.8.9

Michael E Brown wrote:
> /usr/share/doc/rpm-4.4.2.2/conditionalbuilds
> ==================
> The new options are implemented using popt to add aliases to the
> existing rpm
> options --define to specify macros from the command line. The magic
> necessary
> to add the new options is (from the file /usr/lib/rpm/rpmpopt*)
> verbatim
> rpmb alias --with --define "_with_!#:+ --with-!#:+"
> rpmb alias --without --define "_without_!#:+
> --without-!#:+"
> endverbatim
> ==================

Bah. I was confused by reading the sections in /usr/lib/rpm/rpmpopt*
regarding %without() and %bcond_without(). Sorry for not catching
that with better testing. Thanks Paulo.


--
Todd OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
Giving a politician access to your wallet is like giving a dog access
to your refrigerator.
-- Tim Barber

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 12-09-2007, 10:19 AM
Ville Skyttä
 
Default mock 0.8.9

On Friday 07 December 2007, Michael E Brown wrote:

> Mock 0.8.15 is in updates-stable now and has a fix for this problem.

http://download.fedora.redhat.com/pub/fedora/linux/updates/8/x86_64/ still has
0.8.9 but bodhi shows 0.8.15 was pushed to stable updates on 6th. Anyone
know what's up?

--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 
Old 12-09-2007, 02:17 PM
Jesse Keating
 
Default mock 0.8.9

On Sun, 9 Dec 2007 12:19:49 +0200
Ville Skyttä <ville.skytta@iki.fi> wrote:

> http://download.fedora.redhat.com/pub/fedora/linux/updates/8/x86_64/
> still has 0.8.9 but bodhi shows 0.8.15 was pushed to stable updates
> on 6th. Anyone know what's up?

Strange, it looks like it never got the right tag in koji. Fixing.

--
Jesse Keating
Fedora -- All my bits are free, are yours?
--
fedora-devel-list mailing list
fedora-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-list
 

Thread Tools




All times are GMT. The time now is 03:25 PM.

VBulletin, Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org