empty versions shouldn't be upgradable or traceback (#791317)
From: "Brian C. Lane" <bcl@redhat.com>
Also don't use float to compare 2 numbers. Use Decimal instead.
---
pyanaconda/installclasses/fedora.py | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/installclasses/fedora.py b/pyanaconda/installclasses/fedora.py
index e96d525..e7b5c57 100644
--- a/pyanaconda/installclasses/fedora.py
+++ b/pyanaconda/installclasses/fedora.py
@@ -33,6 +33,7 @@ from pyanaconda import installmethod
from pyanaconda import yuminstall
import rpmUtils.arch
+from decimal import Decimal
class InstallClass(BaseInstallClass):
# name has underscore used for mnemonics, strip if you dont need it
@@ -113,10 +114,13 @@ class InstallClass(BaseInstallClass):
return False
def versionMatches(self, oldver):
+ if oldver is None:
+ return False
+
try:
- oldVer = float(oldver)
+ oldVer = Decimal(oldver)
# Trim off any "-Alpha" or "-Beta".
- newVer = float(productVersion.split('-')[0])
+ newVer = Decimal(productVersion.split('-')[0])
except ValueError:
return True
--
1.7.7.6
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list