Hi Mat,

On Thu, 2008-04-03 at 01:14 +0100, Mat Booth wrote:
> On Tue, Apr 1, 2008 at 3:29 AM, Andrew Overholt <overholt@redhat.com> wrote:
> >
> > Yes. I didn't want to mess with copy-platform since I wanted to get
> > this script into a build of the SDK. If you -- or anyone else -- has a
> > few minutes to make this modification, I'd appreciate any patches.
> >
> > Andrew
> >
>
> Sure thing, see attached. This patch changes
> "eclipse-copy-platform.sh" and "eclipse.spec" from the Rawhide eclipse
> package. I hope that's ok.

Awesome, thanks!

My only nit is this:

-sed -e's/^(.*)$/1 1/' -e's,^,ln -s $eclipse/,' >> copy-platform
+sed -e's/^(.*)$/1/' -e's,^(.*),[ ! -e 1 ] && ln -s $eclipse/1
1,' >> copy-platform

I don't think you need the first sed command, do you? Would removing it
still accomplish the same thing? Like this:

sed -e's,^(.*),[ ! -e 1 ] && ln -s $eclipse/1 1,'

Did you want to just commit this? If you request commit on the eclipse
module in the account system, I'll grant it.

Thanks again,

Andrew

--
fedora-devel-java-list mailing list
fedora-devel-java-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-java-list

On Thu, Apr 3, 2008 at 6:57 PM, Andrew Overholt <overholt@redhat.com> wrote:
>
> On Thu, 2008-04-03 at 17:22 +0100, Mat Booth wrote:
> > On Thu, Apr 3, 2008 at 2:16 PM, Andrew Overholt <overholt@redhat.com> wrote:
>
> > See attached for a better patch.
>
> Thanks. Note that I just updated rawhide to 3.3.2 so the patch *may* no
> longer apply cleanly. Sorry if that's the case.
>
>

No worries.

> > > Did you want to just commit this? If you request commit on the eclipse
> > > module in the account system, I'll grant it.
> > >
> >
> > Thanks, but I'm not sure I can do this. I don't have an account in the
> > system because I'm not yet sponsored.
>
> What's your username?
>

In FAS: mbooth

Sorry if this is a silly question, I'm still new at this. Do I need to
apply for the cvseclipse group in order to commit my patch?

Just in case you are thinking about sponsoring me, you should know
that since you last posted in my package review request
(https://bugzilla.redhat.com/show_bug.cgi?id=426884) I've been reading
through the packaging committee minutes and will update my packages
according to the new guidelines as soon as I can.

Regards,
Mat


--
Mat Booth
www.matbooth.co.uk

--
fedora-devel-java-list mailing list
fedora-devel-java-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-devel-java-list