What are we going to do about the broken modifiers?
 

Recent gtk updates have changed the way modifiers are handled and
therefor broken a lot of applications.
* ALT keys are broken in all gtk based terminals. There is a patch
for vte available at
https://bugzilla.redhat.com/show_bug.cgi?id=626792 but even
though it works, it seems controversial.
* xfwm4 has lost all keyboard shortcuts using CTRL. See bug
https://bugzilla.redhat.com/show_bug.cgi?id=759478

Even if the old to handle modifiers may have been wrong, this change
should not have gone into a stable release, because it breaks a lot of
applications (at least gnome-terminal, Terminal, lilyterm, sakura,
termit, terminator, xfwm4) and violates the "Avoid changing the user
experience if at all possible" rule of our updates policy.

What are we going to do now? Revert the change in gtk or fix all
applications?

Regards,
Christoph



--
desktop mailing list
desktop@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/desktop

What are we going to do about the broken modifiers?
 

On Sat, 2011-12-10 at 11:27 +0100, Christoph Wickert wrote:
> Recent gtk updates have changed the way modifiers are handled and
> therefor broken a lot of applications.
> * ALT keys are broken in all gtk based terminals. There is a patch
> for vte available at
> https://bugzilla.redhat.com/show_bug.cgi?id=626792 but even
> though it works, it seems controversial.
> * xfwm4 has lost all keyboard shortcuts using CTRL. See bug
> https://bugzilla.redhat.com/show_bug.cgi?id=759478
>
> Even if the old to handle modifiers may have been wrong, this change
> should not have gone into a stable release, because it breaks a lot of
> applications (at least gnome-terminal, Terminal, lilyterm, sakura,
> termit, terminator, xfwm4) and violates the "Avoid changing the user
> experience if at all possible" rule of our updates policy.
>
> What are we going to do now? Revert the change in gtk or fix all
> applications?

It seems that 'all' boils down to vte + xfwm. Which seems quite
manageable. I'll see if I can help the vte patch along today. As for
xfwm, it seems clear that it must be doing wrong since accels involving
Control work fine in other gtk2 apps.


--
desktop mailing list
desktop@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/desktop

What are we going to do about the broken modifiers?
 

On Sat, 2011-12-10 at 11:27 +0100, Christoph Wickert wrote:
> Recent gtk updates have changed the way modifiers are handled and
> therefor broken a lot of applications.
> * ALT keys are broken in all gtk based terminals. There is a patch
> for vte available at
> https://bugzilla.redhat.com/show_bug.cgi?id=626792 but even
> though it works, it seems controversial.
> * xfwm4 has lost all keyboard shortcuts using CTRL. See bug
> https://bugzilla.redhat.com/show_bug.cgi?id=759478
>
> Even if the old to handle modifiers may have been wrong, this change
> should not have gone into a stable release, because it breaks a lot of
> applications (at least gnome-terminal, Terminal, lilyterm, sakura,
> termit, terminator, xfwm4) and violates the "Avoid changing the user
> experience if at all possible" rule of our updates policy.
>
> What are we going to do now? Revert the change in gtk or fix all
> applications?

I built gtk2/3 and vte2/3 updates earlier this week. I've also tried to
look for problematic code in xfwm briefly, but couldn't find anything.
Where should I look ?

--
desktop mailing list
desktop@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/desktop

What are we going to do about the broken modifiers?
 

Am Mittwoch, den 14.12.2011, 11:38 -0500 schrieb Matthias Clasen:

> I built gtk2/3 and vte2/3 updates earlier this week.

Hi Matthias,

thanks a lot for these updates.

> I've also tried to
> look for problematic code in xfwm briefly, but couldn't find anything.
> Where should I look ?

I guess it is in libxfce4ui, more precisely in libxfce4kbd-private:
http://git.xfce.org/xfce/libxfce4ui/tree/libxfce4kbd-private

Regards,
Christoph

--
desktop mailing list
desktop@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/desktop

What are we going to do about the broken modifiers?
 

On Wed, 2011-12-14 at 19:35 +0100, Christoph Wickert wrote:


> I guess it is in libxfce4ui, more precisely in libxfce4kbd-private:
> http://git.xfce.org/xfce/libxfce4ui/tree/libxfce4kbd-private
>

Ok, I've taken a look now, sorry it took me so long.
https://bugzilla.redhat.com/show_bug.cgi?id=768704 has a fix for
libxfce4ui.


--
desktop mailing list
desktop@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/desktop