FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Redhat > Fedora Desktop

 
 
LinkBack Thread Tools
 
Old 10-27-2009, 11:55 PM
Bastien Nocera
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 00:19 +0100, Martin Sourada wrote:
> On Tue, 2009-10-27 at 22:42 +0000, Bastien Nocera wrote:
> > When trying to build the fix into F12, I noticed we have a few of our
> > own changes.
> >
> > Could you please make sure that:
> > http://koji.fedoraproject.org/koji/buildinfo?buildID=138682
> > also looks as expected for you?
> >
> It looks crisp, but the fill is one pixel smaller then it should be (see
> the attachment).

This should be all fixed in:
http://koji.fedoraproject.org/koji/buildinfo?buildID=138704

Let me know and I'll get it tagged for F12, and update
gnome-power-manager as well.

Cheers

--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 08:05 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> This should be all fixed in:
> http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
>
This one works as expected

> Let me know and I'll get it tagged for F12, and update
> gnome-power-manager as well.
>
> Cheers

Martin


--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 10:04 AM
Bastien Nocera
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 10:05 +0100, Martin Sourada wrote:
> On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> > This should be all fixed in:
> > http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
> >
> This one works as expected

Finally, I also updated gnome-power-manager:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1774321

Would appreciate if people could test as well before tagging.

Cheers

--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 10:15 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 11:04 +0000, Bastien Nocera wrote:
> On Wed, 2009-10-28 at 10:05 +0100, Martin Sourada wrote:
> > On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> > > This should be all fixed in:
> > > http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
> > >
> > This one works as expected
>
> Finally, I also updated gnome-power-manager:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1774321
>
hrm, that one has now wrong positioning (at the top-left corner of the
screen; testing brightness) and the progress bar is blurry. However,
looking at the code, I fail to see, why

Martin
--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 10:23 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 12:15 +0100, Martin Sourada wrote:
> On Wed, 2009-10-28 at 11:04 +0000, Bastien Nocera wrote:
> > On Wed, 2009-10-28 at 10:05 +0100, Martin Sourada wrote:
> > > On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> > > > This should be all fixed in:
> > > > http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
> > > >
> > > This one works as expected
> >
> > Finally, I also updated gnome-power-manager:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=1774321
> >
> hrm, that one has now wrong positioning (at the top-left corner of the
> screen; testing brightness) and the progress bar is blurry. However,
> looking at the code, I fail to see, why
>
Actually, I've just found the source of blurriness:
in draw_action_brightness():
+ /* draw volume meter */
+ draw_volume_boxes (window,
+ cr,
+ (double)window->priv->volume_level / 100.0,
+ bright_box_x0 + 0.5,
+ bright_box_y0 + 0.5,
+ bright_box_width,
+ bright_box_height);
should be
+ /* draw volume meter */
+ draw_volume_boxes (window,
+ cr,
+ (double)window->priv->volume_level / 100.0,
+ bright_box_x0,
+ bright_box_y0,
+ bright_box_width,
+ bright_box_height);
as you are adding the 0.5 inside the draw_volume_boxes() already.

Not sure about the positioning issue though.

Martin

--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 10:35 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Mon, 2009-10-26 at 09:48 -0400, Matthias Clasen wrote:
> On Mon, 2009-10-26 at 13:47 +0100, Martin Sourada wrote:
>
> >
> > I think fixing these would nicely fit with your "polishes for F12"
> > project.
> >
>
> Yes, thanks for pointing these out.
Matthias,

going through the tooltips patch, I found these problems:
in fill_background():
+ draw_round_rect (cr,
+ 1.0, 1, 1, radius,
+ widget->allocation.width - 2,
+ widget->allocation.height - 2);
should be
+ draw_round_rect (cr,
+ 1.0, 0.5, 0.5, radius,
+ widget->allocation.width - 1,
+ widget->allocation.height - 1);
and in update_shape()
+ draw_round_rect (cr, 1.0, 0, 0, 4, width, height);
you are ignoring radius setting.

I'm going to try build and test these fixes (if I find enough HDD space
for the gtk2 build) to see if it's enough.

Martin
--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 10:54 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 12:35 +0100, Martin Sourada wrote:
> and in update_shape()
> + draw_round_rect (cr, 1.0, 0, 0, 4, width, height);
> you are ignoring radius setting.
>
I forgot to mention, that you should use radius + 0.5 to get the shape
correctly.

I just thought about the actual implementation, and as an engine
developer, long-term I'd prefer more systematical change. I.e. let an
engine handle the drawing and ask the engine for the desired tooltip
shape as well (if not composited). That way we could implement it in a
clean way in engines, with radius as set in engine options (as opposed
to counting the radius from x/ythickness) and with our custom styling.

Martin
--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 11:45 AM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 12:35 +0100, Martin Sourada wrote:
> On Mon, 2009-10-26 at 09:48 -0400, Matthias Clasen wrote:
> > On Mon, 2009-10-26 at 13:47 +0100, Martin Sourada wrote:
> >
> > >
> > > I think fixing these would nicely fit with your "polishes for F12"
> > > project.
> > >
> >
> > Yes, thanks for pointing these out.
> Matthias,
>
> going through the tooltips patch, I found these problems:
> in fill_background():
> + draw_round_rect (cr,
> + 1.0, 1, 1, radius,
> + widget->allocation.width - 2,
> + widget->allocation.height - 2);
> should be
> + draw_round_rect (cr,
> + 1.0, 0.5, 0.5, radius,
> + widget->allocation.width - 1,
> + widget->allocation.height - 1);
So, just built and tested -> this is enough to make it look crisp.

> and in update_shape()
> + draw_round_rect (cr, 1.0, 0, 0, 4, width, height);
> you are ignoring radius setting.
Hrm, this one is hard to get looking good... The best setting I've came
up with is radius + 1 instead of 4.

Martin
--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 01:16 PM
Bastien Nocera
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 12:23 +0100, Martin Sourada wrote:
> On Wed, 2009-10-28 at 12:15 +0100, Martin Sourada wrote:
> > On Wed, 2009-10-28 at 11:04 +0000, Bastien Nocera wrote:
> > > On Wed, 2009-10-28 at 10:05 +0100, Martin Sourada wrote:
> > > > On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> > > > > This should be all fixed in:
> > > > > http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
> > > > >
> > > > This one works as expected
> > >
> > > Finally, I also updated gnome-power-manager:
> > > http://koji.fedoraproject.org/koji/taskinfo?taskID=1774321
> > >
> > hrm, that one has now wrong positioning (at the top-left corner of the
> > screen; testing brightness) and the progress bar is blurry. However,
> > looking at the code, I fail to see, why
> >
> Actually, I've just found the source of blurriness:
> in draw_action_brightness():
> + /* draw volume meter */
> + draw_volume_boxes (window,
> + cr,
> + (double)window->priv->volume_level / 100.0,
> + bright_box_x0 + 0.5,
> + bright_box_y0 + 0.5,
> + bright_box_width,
> + bright_box_height);
> should be
> + /* draw volume meter */
> + draw_volume_boxes (window,
> + cr,
> + (double)window->priv->volume_level / 100.0,
> + bright_box_x0,
> + bright_box_y0,
> + bright_box_width,
> + bright_box_height);
> as you are adding the 0.5 inside the draw_volume_boxes() already.

Good catch. That was some left-over from previous patches.

> Not sure about the positioning issue though.

Should be fixed in:
http://koji.fedoraproject.org/koji/buildinfo?buildID=138737

--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 
Old 10-28-2009, 02:07 PM
Martin Sourada
 
Default Some blurriness in gnome desktop

On Wed, 2009-10-28 at 14:16 +0000, Bastien Nocera wrote:
> On Wed, 2009-10-28 at 12:23 +0100, Martin Sourada wrote:
> > Actually, I've just found the source of blurriness:
> > in draw_action_brightness():
> > + /* draw volume meter */
> > + draw_volume_boxes (window,
> > + cr,
> > + (double)window->priv->volume_level / 100.0,
> > + bright_box_x0 + 0.5,
> > + bright_box_y0 + 0.5,
> > + bright_box_width,
> > + bright_box_height);
> > should be
> > + /* draw volume meter */
> > + draw_volume_boxes (window,
> > + cr,
> > + (double)window->priv->volume_level / 100.0,
> > + bright_box_x0,
> > + bright_box_y0,
> > + bright_box_width,
> > + bright_box_height);
> > as you are adding the 0.5 inside the draw_volume_boxes() already.
>
> Good catch. That was some left-over from previous patches.
>
> > Not sure about the positioning issue though.
>
> Should be fixed in:
> http://koji.fedoraproject.org/koji/buildinfo?buildID=138737
>

Thanks, it's now crisp and positioned correctly

Martin
--
Fedora-desktop-list mailing list
Fedora-desktop-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-desktop-list
 

Thread Tools




All times are GMT. The time now is 07:10 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org